Eclipse warning is correct, let's make sure we heed it.
Change-Id: I9e050f1e7f65ff417409a42aaa39434122497555
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
public class CloseTrackedRegistryTest {
private static class SomethingClosable extends AbstractCloseTracked<SomethingClosable> implements AutoCloseable {
public class CloseTrackedRegistryTest {
private static class SomethingClosable extends AbstractCloseTracked<SomethingClosable> implements AutoCloseable {
- SomethingClosable(CloseTrackedRegistry<SomethingClosable> transactionChainRegistry) {
+ SomethingClosable(final CloseTrackedRegistry<SomethingClosable> transactionChainRegistry) {
super(transactionChainRegistry);
}
super(transactionChainRegistry);
}
}
// Something like this really should be in Google Truth...
}
// Something like this really should be in Google Truth...
- private <T> void assertThatIterableContains(Iterable<T> iterable, Predicate<T> predicate) {
+ private static <T> void assertThatIterableContains(final Iterable<T> iterable, final Predicate<T> predicate) {
for (T element : iterable) {
if (predicate.test(element)) {
return;
for (T element : iterable) {
if (predicate.test(element)) {
return;
}
@SuppressWarnings({ "resource", "unused" })
}
@SuppressWarnings({ "resource", "unused" })
- private void someOtherMethodWhichDoesNotClose(CloseTrackedRegistry<SomethingClosable> registry) {
+ private static void someOtherMethodWhichDoesNotClose(final CloseTrackedRegistry<SomethingClosable> registry) {
new SomethingClosable(registry);
}
new SomethingClosable(registry);
}