Upgraded checkstyle is finding new violations, fix them up.
Change-Id: Ib95acc8bc7d738b620ce69ad6b54a9a539ff4b9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
*/
public class TyperUtilsTest {
@TypedTable(name = "TestTypedTable", database = "Open_vSwitch")
*/
public class TyperUtilsTest {
@TypedTable(name = "TestTypedTable", database = "Open_vSwitch")
- private class TestTypedTable {
+ private static final class TestTypedTable {
- private class TestUntypedTable {
+ private static final class TestUntypedTable {
- private class UpdateMonitor implements MonitorCallBack {
+ private final class UpdateMonitor implements MonitorCallBack {
@Override
public void update(TableUpdates result, DatabaseSchema unused) {
updateTableCache(result);
@Override
public void update(TableUpdates result, DatabaseSchema unused) {
updateTableCache(result);
+ "passive connection : mvn -Pintegrationtest -Dovsdbserver.connection=passive verify\n";
}
+ "passive connection : mvn -Pintegrationtest -Dovsdbserver.connection=passive verify\n";
}
- private static class PassiveListener implements Callable<OvsdbClient>, OvsdbConnectionListener {
+ private static final class PassiveListener implements Callable<OvsdbClient>, OvsdbConnectionListener {
OvsdbClient client = null;
@Override
OvsdbClient client = null;
@Override
- private static class SouthboundQueuesExternalIdsHelper
+ private static final class SouthboundQueuesExternalIdsHelper
implements SouthboundQueueHelper<QueuesExternalIdsKey, QueuesExternalIds> {
@Override
public void writeValues(final QueuesBuilder builder,
implements SouthboundQueueHelper<QueuesExternalIdsKey, QueuesExternalIds> {
@Override
public void writeValues(final QueuesBuilder builder,
- private static class SouthboundQueuesOtherConfigHelper
+ private static final class SouthboundQueuesOtherConfigHelper
implements SouthboundQueueHelper<QueuesOtherConfigKey, QueuesOtherConfig> {
@Override
public void writeValues(final QueuesBuilder builder,
implements SouthboundQueueHelper<QueuesOtherConfigKey, QueuesOtherConfig> {
@Override
public void writeValues(final QueuesBuilder builder,
- private static class SouthboundQosExternalIdsHelper
+ private static final class SouthboundQosExternalIdsHelper
implements SouthboundQosHelper<QosExternalIdsKey, QosExternalIds> {
@Override
public void writeValues(final QosEntriesBuilder builder, final Map<QosExternalIdsKey, QosExternalIds> values) {
implements SouthboundQosHelper<QosExternalIdsKey, QosExternalIds> {
@Override
public void writeValues(final QosEntriesBuilder builder, final Map<QosExternalIdsKey, QosExternalIds> values) {
- private static class SouthboundQosOtherConfigHelper
+ private static final class SouthboundQosOtherConfigHelper
implements SouthboundQosHelper<QosOtherConfigKey, QosOtherConfig> {
@Override
public void writeValues(final QosEntriesBuilder builder, final Map<QosOtherConfigKey, QosOtherConfig> values) {
implements SouthboundQosHelper<QosOtherConfigKey, QosOtherConfig> {
@Override
public void writeValues(final QosEntriesBuilder builder, final Map<QosOtherConfigKey, QosOtherConfig> values) {
- private static class PortExternalIdsSouthboundHelper
+ private static final class PortExternalIdsSouthboundHelper
implements SouthboundTerminationPointHelper<PortExternalIdsKey, PortExternalIds> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
implements SouthboundTerminationPointHelper<PortExternalIdsKey, PortExternalIds> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
- private static class InterfaceExternalIdsSouthboundHelper
+ private static final class InterfaceExternalIdsSouthboundHelper
implements SouthboundTerminationPointHelper<InterfaceExternalIdsKey, InterfaceExternalIds> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
implements SouthboundTerminationPointHelper<InterfaceExternalIdsKey, InterfaceExternalIds> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
- private static class InterfaceLldpSouthboundHelper
+ private static final class InterfaceLldpSouthboundHelper
implements SouthboundTerminationPointHelper<InterfaceLldpKey, InterfaceLldp> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
implements SouthboundTerminationPointHelper<InterfaceLldpKey, InterfaceLldp> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
- private static class OptionsSouthboundHelper implements SouthboundTerminationPointHelper<OptionsKey, Options> {
+ private static final class OptionsSouthboundHelper
+ implements SouthboundTerminationPointHelper<OptionsKey, Options> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
final Map<OptionsKey, Options> values) {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
final Map<OptionsKey, Options> values) {
- private static class InterfaceOtherConfigsSouthboundHelper
+ private static final class InterfaceOtherConfigsSouthboundHelper
implements SouthboundTerminationPointHelper<InterfaceOtherConfigsKey, InterfaceOtherConfigs> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
implements SouthboundTerminationPointHelper<InterfaceOtherConfigsKey, InterfaceOtherConfigs> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
- private static class PortOtherConfigsSouthboundHelper implements
+ private static final class PortOtherConfigsSouthboundHelper implements
SouthboundTerminationPointHelper<PortOtherConfigsKey, PortOtherConfigs> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
SouthboundTerminationPointHelper<PortOtherConfigsKey, PortOtherConfigs> {
@Override
public void writeValues(final OvsdbTerminationPointAugmentationBuilder builder,
- private static class BridgeExternalIdsSouthboundHelper
+ private static final class BridgeExternalIdsSouthboundHelper
implements SouthboundBridgeHelper<BridgeExternalIdsKey, BridgeExternalIds> {
@Override
public void writeValues(final OvsdbBridgeAugmentationBuilder builder,
implements SouthboundBridgeHelper<BridgeExternalIdsKey, BridgeExternalIds> {
@Override
public void writeValues(final OvsdbBridgeAugmentationBuilder builder,
- private static class BridgeOtherConfigsSouthboundHelper
+ private static final class BridgeOtherConfigsSouthboundHelper
implements SouthboundBridgeHelper<BridgeOtherConfigsKey, BridgeOtherConfigs> {
@Override
public void writeValues(final OvsdbBridgeAugmentationBuilder builder,
implements SouthboundBridgeHelper<BridgeOtherConfigsKey, BridgeOtherConfigs> {
@Override
public void writeValues(final OvsdbBridgeAugmentationBuilder builder,
}
// Helper classes used to de-mux mock behaviors
}
// Helper classes used to de-mux mock behaviors
- private static class ConfigPropertiesTestMockingBundleNoContext {
+ private static final class ConfigPropertiesTestMockingBundleNoContext {
- private static class ConfigPropertiesTestMocking {
+ private static final class ConfigPropertiesTestMocking {
private boolean runDocker;
private boolean createOdlNetwork;
private boolean runDocker;
private boolean createOdlNetwork;
- private static class DockerComposeServiceInfo {
+ private static final class DockerComposeServiceInfo {
String name;
String port;
}
String name;
String port;
}