summary |
shortlog |
log |
commit | commitdiff |
review |
tree
raw |
patch |
inline | side by side (from parent 1:
d4ce4bf)
Updated checkstyle is finding some issues, fix them up.
Change-Id: Id17bc94b4fdd2b8883dedc5e8736f9e1971aa900
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
1cb9037cc1a5e94001710d184748e0f752aec672)
package org.opendaylight.netconf.api.xml;
public final class XmlNetconfConstants {
package org.opendaylight.netconf.api.xml;
public final class XmlNetconfConstants {
+ private XmlNetconfConstants() {
- private XmlNetconfConstants() {}
public static final String CAPABILITY = "capability";
public static final String CAPABILITIES = "capabilities";
public static final String CAPABILITY = "capability";
public static final String CAPABILITIES = "capabilities";
XML_FACTORY.setProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES, false);
}
XML_FACTORY.setProperty(XMLOutputFactory.IS_REPAIRING_NAMESPACES, false);
}
- private NetconfUtil() {}
+ private NetconfUtil() {
+
+ }
public static Document checkIsMessageOk(final Document response) throws DocumentedException {
XmlElement element = XmlElement.fromDomDocument(response);
public static Document checkIsMessageOk(final Document response) throws DocumentedException {
XmlElement element = XmlElement.fromDomDocument(response);
private static final Logger LOG = LoggerFactory.getLogger(NetconfMessageUtil.class);
private static final Logger LOG = LoggerFactory.getLogger(NetconfMessageUtil.class);
- private NetconfMessageUtil() {}
+ private NetconfMessageUtil() {
+
+ }
public static boolean isOKMessage(final NetconfMessage message) throws NetconfDocumentedException {
return isOKMessage(message.getDocument());
public static boolean isOKMessage(final NetconfMessage message) throws NetconfDocumentedException {
return isOKMessage(message.getDocument());
public final class SendErrorExceptionUtil {
private static final Logger LOG = LoggerFactory.getLogger(SendErrorExceptionUtil.class);
public final class SendErrorExceptionUtil {
private static final Logger LOG = LoggerFactory.getLogger(SendErrorExceptionUtil.class);
- private SendErrorExceptionUtil() {}
+ private SendErrorExceptionUtil() {
+
+ }
public static void sendErrorMessage(final NetconfSession session,
final DocumentedException sendErrorException) {
public static void sendErrorMessage(final NetconfSession session,
final DocumentedException sendErrorException) {
import org.w3c.dom.Text;
public final class XmlUnitUtil {
import org.w3c.dom.Text;
public final class XmlUnitUtil {
+ private XmlUnitUtil() {
- private XmlUnitUtil() {}
public static void assertContainsElementWithText(final Document doc,
final String textToFind) throws NodeTestException {
public static void assertContainsElementWithText(final Document doc,
final String textToFind) throws NodeTestException {
boolean textFound = false;
@Override
boolean textFound = false;
@Override
- public void testText(Text text) throws NodeTestException {
+ public void testText(final Text text) throws NodeTestException {
if (!textFound) {
if (text.getData().equalsIgnoreCase(textToFind)) {
textFound = true;
if (!textFound) {
if (text.getData().equalsIgnoreCase(textToFind)) {
textFound = true;
- public void noMoreNodes(NodeTest forTest) throws NodeTestException {
+ public void noMoreNodes(final NodeTest forTest) throws NodeTestException {
assertTrue(textFound);
}
};
assertTrue(textFound);
}
};
private boolean elementFound = false;
@Override
private boolean elementFound = false;
@Override
- public void testElement(Element element) throws NodeTestException {
+ public void testElement(final Element element) throws NodeTestException {
if (!elementFound) {
if (element.isEqualNode(testElement)) {
elementFound = true;
if (!elementFound) {
if (element.isEqualNode(testElement)) {
elementFound = true;
- public void noMoreNodes(NodeTest forTest) throws NodeTestException {
+ public void noMoreNodes(final NodeTest forTest) throws NodeTestException {
assertTrue(elementFound);
}
};
assertTrue(elementFound);
}
};
private boolean elementFound = false;
@Override
private boolean elementFound = false;
@Override
- public void testElement(Element element) throws NodeTestException {
+ public void testElement(final Element element) throws NodeTestException {
if (!elementFound) {
if (element.getNodeName() != null && element.getNodeName().equals(elementName)) {
elementFound = true;
if (!elementFound) {
if (element.getNodeName() != null && element.getNodeName().equals(elementName)) {
elementFound = true;
- public void noMoreNodes(NodeTest forTest) throws NodeTestException {
+ public void noMoreNodes(final NodeTest forTest) throws NodeTestException {
assertTrue(XmlUtil.toString(doc), elementFound);
}
};
assertTrue(XmlUtil.toString(doc), elementFound);
}
};
private int elementFound = 0;
@Override
private int elementFound = 0;
@Override
- public void testElement(Element element) throws NodeTestException {
+ public void testElement(final Element element) throws NodeTestException {
if (element.getNodeName() != null && element.getNodeName().equals(elementName)) {
elementFound++;
}
}
@Override
if (element.getNodeName() != null && element.getNodeName().equals(elementName)) {
elementFound++;
}
}
@Override
- public void noMoreNodes(NodeTest forTest) throws NodeTestException {
+ public void noMoreNodes(final NodeTest forTest) throws NodeTestException {
assertEquals(expectedCount, elementFound);
}
};
assertEquals(expectedCount, elementFound);
}
};
private static final Document BLANK_DOCUMENT = XmlUtil.newDocument();
public static final String EVENT_TIME = "eventTime";
private static final Document BLANK_DOCUMENT = XmlUtil.newDocument();
public static final String EVENT_TIME = "eventTime";
- private NetconfMessageTransformUtil() {}
+ private NetconfMessageTransformUtil() {
+
+ }
public static final QName IETF_NETCONF_MONITORING =
QName.create(NetconfState.QNAME, "ietf-netconf-monitoring").intern();
public static final QName IETF_NETCONF_MONITORING =
QName.create(NetconfState.QNAME, "ietf-netconf-monitoring").intern();