NETCONF-526 : edit-config payload default-operation needs to be set to default-value 82/69482/4
authorBalaji Varadaraju <bvaradar@luminanetworks.com>
Wed, 14 Mar 2018 06:40:46 +0000 (01:40 -0500)
committerJakub Morvay <jakub.morvay@gmail.com>
Wed, 28 Mar 2018 13:08:14 +0000 (13:08 +0000)
For the PUT/POST calls right now default-operation tag in the edit-config is set to
"none". As per RFC with this value devices can reject a config operation when
elements present in the request whose structure is not already present in the tree.
For example a nested parent-child structure where parent structure does not yet exist
yet in the tree may result in an error based on implementation.
We should  leave this field out ( which will default to merge) and let the device make
the right decision.

Change-Id: I8b85ef072785381897a19724dc94003b8f315bd4
Signed-off-by: Balaji Varadaraju <bvaradar@luminanetworks.com>
netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/AbstractWriteTx.java

index 7d6dd3e9e862f3cc8e41caea0428f0e98563d3b1..8c5929752c97bf0ea056a41aea4165c3600808ac 100644 (file)
@@ -106,7 +106,7 @@ public abstract class AbstractWriteTx implements DOMDataWriteTransaction {
         final DataContainerChild<?, ?> editStructure =
                 netOps.createEditConfigStrcture(Optional.<NormalizedNode<?, ?>>fromNullable(data),
                         Optional.of(ModifyAction.REPLACE), path);
-        editConfig(path, Optional.fromNullable(data), editStructure, Optional.of(ModifyAction.NONE), "put");
+        editConfig(path, Optional.fromNullable(data), editStructure, Optional.<ModifyAction>absent(), "put");
     }
 
     @Override