Use ArrayList.sort() instead of Collections.sort() 61/76961/1
authorRobert Varga <robert.varga@pantheon.tech>
Sat, 13 Oct 2018 08:38:32 +0000 (10:38 +0200)
committerRobert Varga <nite@hq.sk>
Sat, 13 Oct 2018 08:56:25 +0000 (08:56 +0000)
We do not need Collections, as we have Java 8 and hence can
directly use List.sort(). This has the side-effect of
short-circuiting to ArrayList's implementation.

Change-Id: If978265242275014c586fcf92d96d5ba09bb7bca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding/mdsal-binding-java-api-generator/src/main/java/org/opendaylight/mdsal/binding/java/api/generator/AbstractBuilderTemplate.xtend

index 60e6983beeb8bfab5bebcaea8dfcf0aba6b87548..a725919d59fb0ed7255a1fea36e9ff0dc5067484 100644 (file)
@@ -136,7 +136,7 @@ abstract class AbstractBuilderTemplate extends BaseTemplate {
             «val isList = implementsIfc(targetType, Types.parameterizedTypeFor(Types.typeForClass(Identifiable), targetType))»
             «IF isList && keyType !== null»
                 «val keyProps = new ArrayList((keyType as GeneratedTransferObject).properties)»
-                «Collections.sort(keyProps, [ p1, p2 | return p1.name.compareTo(p2.name) ])»
+                «keyProps.sort([ p1, p2 | return p1.name.compareTo(p2.name) ])»
                 «FOR field : keyProps»
                     «removeProperty(allProps, field.name)»
                 «ENDFOR»