Move TpId allocation out of loop

The TpId being looked up is loop-invariant, hence it makes
sense to allocate it once rather than in a tight loop.

Change-Id: I8242754c61fa56b0779f164b001705fe252fe60e
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbPortUpdateCommand.java b/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbPortUpdateCommand.java
index 97d52d6197f83dc35d15c447c84c495786bc9c3c..81c39e861507418b3077621c3ac4fbaa9105f31a 100644 (file)
--- a/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbPortUpdateCommand.java
+++ b/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbPortUpdateCommand.java
@@ -216,12 +216,13 @@ public class OvsdbPortUpdateCommand extends AbstractTransactionCommand {
             final ReadWriteTransaction transaction, Node node, String tpName) {
         OvsdbNodeAugmentation ovsdbNode = node.getAugmentation(OvsdbNodeAugmentation.class);
         List<ManagedNodeEntry> managedNodes = ovsdbNode.getManagedNodeEntry();
+        TpId tpId = new TpId(tpName);
         for ( ManagedNodeEntry managedNodeEntry : managedNodes ) {
             @SuppressWarnings("unchecked")
             Node managedNode = readNode(transaction
                     ,(InstanceIdentifier<Node>)managedNodeEntry.getBridgeRef().getValue()).get();
             for (TerminationPoint tpEntry : managedNode.getTerminationPoint()) {
-                if (tpEntry.getTpId().equals(new TpId(tpName))) {
+                if (tpId.equals(tpEntry.getTpId())) {
                     return Optional.of((InstanceIdentifier<Node>)managedNodeEntry.getBridgeRef().getValue());
                 }
             }