logging issues in ipv6service

Change-Id: I0d7d727ea2072918b7a3370dd90ccb934f57afcb
Signed-off-by: Faseela K <faseela.k@ericsson.com>

diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java
index 4361c0ffb94e675e8fc8c82869af5f7e5f246dd0..97d174b188eeb74211b6e2e2eaaefe7afdc111a1 100644 (file)
--- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java
+++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/IfMgr.java
@@ -66,7 +66,8 @@ import org.slf4j.LoggerFactory;
 
 @Singleton
 public class IfMgr implements ElementCache, AutoCloseable {
-    static final Logger LOG = LoggerFactory.getLogger(IfMgr.class);
+
+    private static final Logger LOG = LoggerFactory.getLogger(IfMgr.class);
 
     private final ConcurrentMap<Uuid, VirtualRouter> vrouters = new ConcurrentHashMap<>();
     private final ConcurrentMap<Uuid, VirtualNetwork> vnetworks = new ConcurrentHashMap<>();
@@ -708,7 +709,7 @@ public class IfMgr implements ElementCache, AutoCloseable {
 
     public void transmitUnsolicitedRA(Uuid portId) {
         VirtualPort port = getPort(portId);
-        LOG.debug("in transmitUnsolicitedRA for {}, port", portId, port);
+        LOG.debug("in transmitUnsolicitedRA for {}, port {}", portId, port);
         if (port != null) {
             transmitUnsolicitedRA(port);
         }

diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6NeighborSolicitation.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6NeighborSolicitation.java
index 043ab2fca0e5f80afe35405c4fd995f3366519bc..15c6f02fe51869b742a8daa2fbb2d532ed9a8d83 100644 (file)
--- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6NeighborSolicitation.java
+++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6NeighborSolicitation.java
@@ -36,7 +36,9 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class Ipv6NeighborSolicitation {
-    private static final Logger LOG = LoggerFactory.getLogger(Ipv6RouterAdvt.class);
+
+    private static final Logger LOG = LoggerFactory.getLogger(Ipv6NeighborSolicitation.class);
+
     private final PacketProcessingService packetService;
 
     public Ipv6NeighborSolicitation(PacketProcessingService packetService) {

diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6ServiceEosHandler.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6ServiceEosHandler.java
index c71c482e0fafa58c891bf15c6e31fb2f23d0d8cf..52a5713f4bfa0215c630c278a6de7871d5028f4e 100644 (file)
--- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6ServiceEosHandler.java
+++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/Ipv6ServiceEosHandler.java
@@ -24,8 +24,9 @@ import org.slf4j.LoggerFactory;
 
 @Singleton
 public class Ipv6ServiceEosHandler implements EntityOwnershipListener, AutoCloseable {
+
     private static final Logger LOG = LoggerFactory.getLogger(Ipv6ServiceEosHandler.class);
-    private static String EOS_ENTITY_OWNER = "netvirt-ipv6service-owner-entity";
+    private static final String EOS_ENTITY_OWNER = "netvirt-ipv6service-owner-entity";
 
     private volatile boolean isEosOwner;
 
@@ -64,7 +65,7 @@ public class Ipv6ServiceEosHandler implements EntityOwnershipListener, AutoClose
         try {
             candidateRegistration = entityOwnershipService.registerCandidate(instanceEntity);
         } catch (CandidateAlreadyRegisteredException e) {
-            LOG.warn("Instance entity was already registered", instanceEntity);
+            LOG.warn("Instance entity {} was already registered", instanceEntity);
         }
         LOG.trace("Entity ownership registration successful");
     }

diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronNetworkChangeListener.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronNetworkChangeListener.java
index ca1d38d10f373e1c3ff8d86a60b797b4c6939755..5afbff0198cec6e3eab691851ab2eec569e1ae24 100644 (file)
--- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronNetworkChangeListener.java
+++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/NeutronNetworkChangeListener.java
@@ -23,7 +23,9 @@ import org.slf4j.LoggerFactory;
 @Singleton
 public class NeutronNetworkChangeListener extends AsyncClusteredDataTreeChangeListenerBase<Network,
         NeutronNetworkChangeListener> {
-    private static final Logger LOG = LoggerFactory.getLogger(NeutronRouterChangeListener.class);
+
+    private static final Logger LOG = LoggerFactory.getLogger(NeutronNetworkChangeListener.class);
+
     private final DataBroker dataBroker;
     private final IfMgr ifMgr;
 

diff --git a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualPort.java b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualPort.java
index 8bd93fd93f67b2a69de17e42c53f68e8084beb9b..f7ce4712a87b234f34e83c6c993f1536c07753d2 100644 (file)
--- a/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualPort.java
+++ b/ipv6service/impl/src/main/java/org/opendaylight/netvirt/ipv6service/VirtualPort.java
@@ -31,7 +31,8 @@ import org.slf4j.LoggerFactory;
 // This class needs to be overridden by Mockito
 @SuppressWarnings("checkstyle:FinalClass")
 public class VirtualPort implements IVirtualPort  {
-    static final Logger LOG = LoggerFactory.getLogger(VirtualPort.class);
+
+    private static final Logger LOG = LoggerFactory.getLogger(VirtualPort.class);
 
     private final Uuid intfUUID;
     private final Uuid networkID;