Removed unused logger and fixed javadoc links

Change-Id: I595c97b39b6093d0b96f1f00a2bbc08274c8fda5
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

diff --git a/applications/lldp-speaker/src/main/resources/org/opendaylight/blueprint/lldp-speaker.xml b/applications/lldp-speaker/src/main/resources/org/opendaylight/blueprint/lldp-speaker.xml
index 98fd805b4c97e5b439a81d05ce0c3ef63cc76b0b..ca8fa54dd97aae6a98ecf0fbb8c6045b31f63c14 100644 (file)
--- a/applications/lldp-speaker/src/main/resources/org/opendaylight/blueprint/lldp-speaker.xml
+++ b/applications/lldp-speaker/src/main/resources/org/opendaylight/blueprint/lldp-speaker.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0"
            xmlns:odl="http://opendaylight.org/xmlns/blueprint/v1.0.0"
-        odl:use-default-for-reference-types="true">
+           odl:use-default-for-reference-types="true">
 
   <reference id="dataBroker" interface="org.opendaylight.controller.md.sal.binding.api.DataBroker"/>
 

diff --git a/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeakerTest.java b/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeakerTest.java
index 13be394b4f33041cedcb221e83e66d0c21eae22d..cd77668eac4caf326a5cf53d16851c64d11c714b 100644 (file)
--- a/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeakerTest.java
+++ b/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/LLDPSpeakerTest.java
@@ -40,7 +40,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.openflow
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
 /**
- * Tests for @{LLDPSpeaker} class.
+ * Tests for {@link LLDPSpeaker}.
  */
 @RunWith(MockitoJUnitRunner.class)
 public class LLDPSpeakerTest {
@@ -71,7 +71,6 @@ public class LLDPSpeakerTest {
     private LLDPSpeaker lldpSpeaker;
 
     @Before
-    @SuppressWarnings("unchecked")
     public void setUp() {
         when(
                 scheduledExecutorService.scheduleAtFixedRate(
@@ -142,7 +141,7 @@ public class LLDPSpeakerTest {
     }
 
     /**
-     * Test that when @{LLDPSpeaker#nodeConnectorAdded} is called multiple times
+     * Test that when {@link LLDPSpeaker#nodeConnectorAdded} is called multiple times
      * with same arguments, only the first one have effect.
      */
     @Test

diff --git a/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java b/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java
index 391624c04a495b9e0df411eec1e64127c68716cf..9ee90e653aa3184be59bd1b186c62c6ccce156ac 100644 (file)
--- a/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java
+++ b/applications/lldp-speaker/src/test/java/org/opendaylight/openflowplugin/applications/lldpspeaker/NodeConnectorInventoryEventTranslatorTest.java
@@ -37,7 +37,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
 
 /**
- * Tests for @{NodeConnectorInventoryEventTranslator} class.
+ * Tests for {@link NodeConnectorInventoryEventTranslator}.
  */
 @RunWith(MockitoJUnitRunner.class)
 public class NodeConnectorInventoryEventTranslatorTest {
@@ -58,7 +58,7 @@ public class NodeConnectorInventoryEventTranslatorTest {
     }
 
     /**
-     * Test that checks if @{NodeConnectorEventsObserver#nodeConnectorAdded} is called
+     * Test that checks if {@link NodeConnectorEventsObserver#nodeConnectorAdded} is called
      * for each FlowCapableNodeConnector item that @{AsyncDataChangeEvent#getCreatedData} return.
      */
     @Test
@@ -91,7 +91,7 @@ public class NodeConnectorInventoryEventTranslatorTest {
     }
 
     /**
-     * Test that checks if @{NodeConnectorEventsObserver#nodeConnectorRemoved} is called
+     * Test that checks if {@link NodeConnectorEventsObserver#nodeConnectorRemoved} is called
      * for each FlowCapableNodeConnector item inside @{AsyncDataChangeEvent#getUpdatedData}
      * that have link down state.
      */
@@ -104,7 +104,7 @@ public class NodeConnectorInventoryEventTranslatorTest {
     }
 
     /**
-     * Test that checks if @{NodeConnectorEventsObserver#nodeConnectorRemoved} is called
+     * Test that checks if {@link NodeConnectorEventsObserver#nodeConnectorRemoved} is called
      * for each FlowCapableNodeConnector item inside @{AsyncDataChangeEvent#getUpdatedData}
      * that have administrative down state.
      */
@@ -117,7 +117,7 @@ public class NodeConnectorInventoryEventTranslatorTest {
     }
 
     /**
-     * Test that checks if @{NodeConnectorEventsObserver#nodeConnectorAdded} is called
+     * Test that checks if {@link NodeConnectorEventsObserver#nodeConnectorAdded} is called
      * for each FlowCapableNodeConnector item inside @{AsyncDataChangeEvent#getUpdatedData}
      * that have administrative up and link up state.
      */
@@ -129,7 +129,7 @@ public class NodeConnectorInventoryEventTranslatorTest {
     }
 
     /**
-     * Test that checks if @{NodeConnectorEventsObserver#nodeConnectorRemoved} is called
+     * Test that checks if {@link NodeConnectorEventsObserver#nodeConnectorRemoved} is called
      * for each FlowCapableNodeConnector path that @{AsyncDataChangeEvent#getRemovedPaths} return.
      */
     @Test
@@ -141,7 +141,7 @@ public class NodeConnectorInventoryEventTranslatorTest {
     }
 
     /**
-     * Test that checks if @{NodeConnectorEventsObserver#nodeConnectorAdded} and
+     * Test that checks if {@link NodeConnectorEventsObserver#nodeConnectorAdded} and
      * @{NodeConnectorEventsObserver#nodeConnectorRemoved} are called for each
      * observer when multiple observers are registered for notifications.
      */

diff --git a/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPDiscoveryListener.java b/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPDiscoveryListener.java
index 097d0edc4ebc0089c11375afa782ad9577ccb387..43225b987028b82f20baf4416a71dd9d3fbd1425 100644 (file)
--- a/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPDiscoveryListener.java
+++ b/applications/topology-lldp-discovery/src/main/java/org/opendaylight/openflowplugin/applications/topology/lldp/LLDPDiscoveryListener.java
@@ -1,4 +1,4 @@
-/*
+/**
  * Copyright (c) 2014 Cisco Systems, Inc. and others.  All rights reserved.
  *
  * This program and the accompanying materials are made available under the
@@ -14,12 +14,8 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.topology.discovery.rev
 import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingListener;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceived;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 public class LLDPDiscoveryListener implements PacketProcessingListener {
-    private static final Logger LOG = LoggerFactory.getLogger(LLDPDiscoveryListener.class);
-
     private final LLDPLinkAger lldpLinkAger;
     private final NotificationProviderService notificationService;