ContextChainHolderImpl maps are Concurrent 33/94733/1
authorRobert Varga <robert.varga@pantheon.tech>
Fri, 22 Jan 2021 12:23:20 +0000 (13:23 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 22 Jan 2021 12:24:13 +0000 (13:24 +0100)
Document the intended contract, allowing future improvements around
executed operations.

Change-Id: I778c4ecb82ec1e3be129bdcdce9e5fd925dc88a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/lifecycle/ContextChainHolderImpl.java

index a8d0362a353c64fa63b0cb9647f9f16033d1ee7c..73bb3fe0c65294220f07549411ba8972f2ad70c1 100644 (file)
@@ -20,6 +20,7 @@ import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.Executor;
 import java.util.concurrent.Executors;
@@ -74,8 +75,8 @@ public class ContextChainHolderImpl implements ContextChainHolder, MasterChecker
     private static final String ASYNC_SERVICE_ENTITY_TYPE = "org.opendaylight.mdsal.AsyncServiceCloseEntityType";
     private static final String SERVICE_ENTITY_TYPE = "org.opendaylight.mdsal.ServiceEntityType";
     private static final String SEPARATOR = ":";
-    private final Map<DeviceInfo, ContextChain> contextChainMap = new ConcurrentHashMap<>();
-    private final Map<DeviceInfo, ? super ConnectionContext> connectingDevices = new ConcurrentHashMap<>();
+    private final ConcurrentMap<DeviceInfo, ContextChain> contextChainMap = new ConcurrentHashMap<>();
+    private final ConcurrentMap<DeviceInfo, ? super ConnectionContext> connectingDevices = new ConcurrentHashMap<>();
     private final EntityOwnershipListenerRegistration eosListenerRegistration;
     private final ClusterSingletonServiceProvider singletonServiceProvider;
     private final Executor executor;