Clean up DefaultSslContextFactoryProviderTest 67/115467/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 18 Feb 2025 23:15:07 +0000 (00:15 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Tue, 18 Feb 2025 23:15:07 +0000 (00:15 +0100)
SecurityHelper.decodeCertificate() is a static method, use it as such.

Change-Id: Iad41f9e9ad41e156607f4c82cc4704417eeb7ae3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
plugins/netconf-client-mdsal/src/test/java/org/opendaylight/netconf/client/mdsal/impl/DefaultSslContextFactoryProviderTest.java

index 79c1e0adb163f97cf8a8b60ea46d44647509fdda..8e26c48ee2e4ee93a7331cf81a2849519e004d9a 100644 (file)
@@ -191,7 +191,7 @@ class DefaultSslContextFactoryProviderTest {
 
                 final var decodedCerts = new ArrayList<byte[]>();
                 for (final var cert : certChain) {
-                    decodedCerts.add(new SecurityHelper().decodeCertificate(cert).getEncoded());
+                    decodedCerts.add(SecurityHelper.decodeCertificate(cert).getEncoded());
                 }
 
 
@@ -217,7 +217,7 @@ class DefaultSslContextFactoryProviderTest {
                 final var certName = element.getElementsByTagName(XML_ELEMENT_NAME).item(0).getTextContent();
                 final var certData = element.getElementsByTagName(XML_ELEMENT_CERT).item(0).getTextContent();
 
-                final var cert = new SecurityHelper().decodeCertificate(certData).getEncoded();
+                final var cert = SecurityHelper.decodeCertificate(certData).getEncoded();
 
                 trustedCertificates.add(new TrustedCertificateBuilder()
                     .withKey(new TrustedCertificateKey(certName))