if (implementation == null) {
implementation = tryToLoadImplementationImpl(inputType);
}
-
- return null;
+ return implementation;
}
private T tryToLoadImplementationImpl(final Class<? extends DataContainer> inputType) {
}
protected List<PerFeatureRunner> runnersFromFeatures(final URL repoURL, final Features features,final Class<?> testClass) throws InitializationError {
- List<PerFeatureRunner> runners = new ArrayList<PerFeatureRunner>();
- List<Feature> featureList = new ArrayList<Feature>();
- featureList = features.getFeature();
- for(Feature f : featureList) {
+ final List<PerFeatureRunner> runners = new ArrayList<>();
+ final List<Feature> featureList = features.getFeature();
+ for(final Feature f : featureList) {
runners.add(new PerFeatureRunner(repoURL, f.getName(), f.getVersion(),testClass));
}
return runners;
*/
package org.opendaylight.yangtools.util;
+import com.google.common.base.Preconditions;
+import javax.annotation.Nonnull;
import org.opendaylight.yangtools.concepts.Identifiable;
import com.google.common.base.Function;
public final class Identifiables {
private static final Function<Identifiable<Object>, Object> EXTRACT_IDENTIFIER = new Function<Identifiable<Object>, Object>() {
@Override
- public Object apply(final Identifiable<Object> input) {
+ public Object apply(final @Nonnull Identifiable<Object> input) {
+ Preconditions.checkNotNull(input);
return input.getIdentifier();
}
};
@Override
public String toString() {
- return super.toString() + ", children.size = " + (getChildren() != null ? getChildren().size() : "n/a");
+ return super.toString() + ", children.size = " + (!getChildren().isEmpty() ? getChildren().size() : "n/a");
}
@Override
@Override
public String toString() {
- return super.toString() + ", children.size = " + (getChildren() != null ? getChildren().size() : "n/a");
+ return super.toString() + ", children.size = " + (!getChildren().isEmpty() ? getChildren().size() : "n/a");
}
@Override
import com.google.common.base.Function;
import com.google.common.base.Joiner;
+import com.google.common.base.Preconditions;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import java.util.List;
import java.util.Map;
+import javax.annotation.Nonnull;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
private static final Logger LOG = LoggerFactory.getLogger(NodeUtils.class);
private static final Function<QName, String> LOCALNAME_FUNCTION = new Function<QName, String>() {
@Override
- public String apply(final QName input) {
+ public String apply(final @Nonnull QName input) {
+ Preconditions.checkNotNull(input);
return input.getLocalName();
}
};
import java.util.Set;
import javax.activation.UnsupportedDataTypeException;
+import javax.annotation.Nonnull;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
}
public static List<Node<?>> toDomNodes(final Element element, final Optional<? extends Iterable<DataSchemaNode>> context, final SchemaContext schemaCtx) {
- return forEachChild(element.getChildNodes(),schemaCtx, new Function<ElementWithSchemaContext, Optional<Node<?>>>() {
+ return forEachChild(element.getChildNodes(), schemaCtx, new Function<ElementWithSchemaContext, Optional<Node<?>>>() {
@Override
- public Optional<Node<?>> apply(final ElementWithSchemaContext input) {
+ public Optional<Node<?>> apply(final @Nonnull ElementWithSchemaContext input) {
if (context.isPresent()) {
+ Preconditions.checkNotNull(input);
QName partialQName = qNameFromElement(input.getElement());
Optional<DataSchemaNode> schemaNode = findFirstSchema(partialQName, context.get());
if (schemaNode.isPresent()) {
}
});
-
}
public static List<Node<?>> toDomNodes(final Element element, final Optional<? extends Iterable<DataSchemaNode>> context) {
}
/**
- * Short-hand for {@link #writeDataDocument(XMLStreamWriter, CompositeNode, SchemaNode, XmlCodecProvider)} with
+ * Short-hand for {@link #writeDocument(XMLStreamWriter, CompositeNode, SchemaNode)})} with
* null SchemaNode.
*
* @param writer XML Stream writer
* @param data data node
- * @param schema corresponding schema node, may be null
* @throws XMLStreamException if an encoding problem occurs
*/
public void writeDocument(final XMLStreamWriter writer, final CompositeNode data) throws XMLStreamException {
DataSchemaNode childSchema = null;
if (schema instanceof DataNodeContainer) {
childSchema = SchemaUtils.findFirstSchema(child.getNodeType(), ((DataNodeContainer) schema).getChildNodes()).orNull();
- if (LOG.isDebugEnabled()) {
- if (childSchema == null) {
- LOG.debug("Probably the data node \"{}\" does not conform to schema", child == null ? "" : child.getNodeType().getLocalName());
- }
- }
+ } else if ((childSchema == null) && LOG.isDebugEnabled()) {
+ LOG.debug("Probably the data node \"{}\" does not conform to schema", child == null ? "" : child.getNodeType().getLocalName());
}
-
writeElement(writer, child, childSchema);
}
}
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
+import javax.annotation.Nonnull;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
import org.opendaylight.yangtools.yang.data.api.schema.AugmentationNode;
HashSet<QName> qNamesFromAugment = Sets.newHashSet(Collections2.transform(augment.getChildNodes(), new Function<DataSchemaNode, QName>() {
@Override
- public QName apply(final DataSchemaNode input) {
+ public QName apply(final @Nonnull DataSchemaNode input) {
+ Preconditions.checkNotNull(input);
return input.getQName();
}
}));
package org.opendaylight.yangtools.yang.data.impl.schema.tree;
import com.google.common.base.Optional;
+import com.google.common.base.Preconditions;
import com.google.common.base.Predicate;
import java.util.HashMap;
+import javax.annotation.Nonnull;
import org.opendaylight.yangtools.concepts.Identifiable;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument;
import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
public static final Predicate<ModifiedNode> IS_TERMINAL_PREDICATE = new Predicate<ModifiedNode>() {
@Override
- public boolean apply(final ModifiedNode input) {
+ public boolean apply(final @Nonnull ModifiedNode input) {
+ Preconditions.checkNotNull(input);
switch (input.getType()) {
case DELETE:
case MERGE:
@Override
public void verifyStructure(final ModifiedNode modification) throws IllegalArgumentException {
- if (modification.getType() == ModificationType.WRITE) {
-
- }
for (ModifiedNode childModification : modification.getChildren()) {
resolveChildOperation(childModification.getIdentifier()).verifyStructure(childModification);
}
Code Review / yangtools.git / commitdiff