String performance and maintenability

Use StringBuilder for strings built in loops. Use plain concatenation
for string construction not involving loops.

Change-Id: I8299eb54a347d132f0d19dfb39c8fb52366049f2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

diff --git a/node/utils/stream/NormalizedNodeStreamReaderWriterTest.java b/node/utils/stream/NormalizedNodeStreamReaderWriterTest.java
index 083a0497fc520a92bf93fa62c7dfac56fdc2f96a..81d97678b01762d456fb7c3a3af8d6c77203302a 100644 (file)
--- a/node/utils/stream/NormalizedNodeStreamReaderWriterTest.java
+++ b/node/utils/stream/NormalizedNodeStreamReaderWriterTest.java
@@ -229,12 +229,10 @@ public class NormalizedNodeStreamReaderWriterTest {
     }
 
     private static String largeString(final int pow) {
-        String str = "X";
+        StringBuilder sb = new StringBuilder("X");
         for (int i = 0; i < pow; i++) {
-            StringBuilder buf = new StringBuilder();
-            buf.append(str).append(str);
-            str = buf.toString();
+            sb.append(sb);
         }
-        return str;
+        return sb.toString();
     }
 }

diff --git a/node/utils/stream/ValueTypesTest.java b/node/utils/stream/ValueTypesTest.java
index 34b542105738617db80c412ee5a1ff57e5da0461..0395e94ee822cd6ca47e0f8dfbd66f7aaf53a7dd 100644 (file)
--- a/node/utils/stream/ValueTypesTest.java
+++ b/node/utils/stream/ValueTypesTest.java
@@ -22,12 +22,10 @@ public class ValueTypesTest {
 
     private static String largeString(int minSize) {
         final int pow = (int) (Math.log(minSize * 2) / Math.log(2));
-        String str = "X";
+        StringBuilder sb = new StringBuilder("X");
         for (int i = 0; i < pow; i++) {
-            StringBuilder buf = new StringBuilder();
-            buf.append(str).append(str);
-            str = buf.toString();
+            sb.append(sb);
         }
-        return str;
+        return sb.toString();
     }
 }