CachingNormalizedNodeSerializer should not be instantiated

We only use this class to act as a delegate towards the rest of the
infrastructure. Remove its constructor.

Change-Id: I245fe5204dc3872703c19df320a77789d5a4c6bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CachingNormalizedNodeSerializer.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CachingNormalizedNodeSerializer.java
index d746528b96c1dbd4ad0dcc00736f5f2e5c8cdb4e..373577dbe7c8dd2f7ec74f95708a1d75f7f26fa9 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CachingNormalizedNodeSerializer.java
+++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/CachingNormalizedNodeSerializer.java
@@ -38,12 +38,31 @@ final class CachingNormalizedNodeSerializer extends ForwardingBindingStreamEvent
     private final AbstractBindingNormalizedNodeCacheHolder cacheHolder;
     private final BindingToNormalizedStreamWriter delegate;
 
-    CachingNormalizedNodeSerializer(final AbstractBindingNormalizedNodeCacheHolder cacheHolder,
+    private CachingNormalizedNodeSerializer(final AbstractBindingNormalizedNodeCacheHolder cacheHolder,
             final DataContainerCodecContext<?, ?> subtreeRoot) {
         this.cacheHolder = requireNonNull(cacheHolder);
         delegate = new BindingToNormalizedStreamWriter(subtreeRoot, domWriter);
     }
 
+    /**
+     * Serializes supplied data using stream writer with child cache enabled.
+     *
+     * @param cacheHolder Binding to Normalized Node Cache holder
+     * @param subtreeRoot Codec Node for provided data object
+     * @param data Data to be serialized
+     * @return Normalized Node representation of data.
+     */
+    static NormalizedNode serializeUsingStreamWriter(final AbstractBindingNormalizedNodeCacheHolder cacheHolder,
+            final DataContainerCodecContext<?, ?> subtreeRoot, final DataObject data) {
+        final var writer = new CachingNormalizedNodeSerializer(cacheHolder, subtreeRoot);
+        try {
+            subtreeRoot.eventStreamSerializer().serialize(data, writer);
+        } catch (final IOException e) {
+            throw new IllegalStateException(e);
+        }
+        return writer.domResult.getResult();
+    }
+
     @Override
     protected AnydataBindingStreamWriter delegate() {
         return delegate;
@@ -109,23 +128,4 @@ final class CachingNormalizedNodeSerializer extends ForwardingBindingStreamEvent
         }
         return null;
     }
-
-    /**
-     * Serializes supplied data using stream writer with child cache enabled.
-     *
-     * @param cacheHolder Binding to Normalized Node Cache holder
-     * @param subtreeRoot Codec Node for provided data object
-     * @param data Data to be serialized
-     * @return Normalized Node representation of data.
-     */
-    static NormalizedNode serializeUsingStreamWriter(final AbstractBindingNormalizedNodeCacheHolder cacheHolder,
-            final DataContainerCodecContext<?, ?> subtreeRoot, final DataObject data) {
-        final var writer = new CachingNormalizedNodeSerializer(cacheHolder, subtreeRoot);
-        try {
-            subtreeRoot.eventStreamSerializer().serialize(data, writer);
-        } catch (final IOException e) {
-            throw new IllegalStateException(e);
-        }
-        return writer.domResult.getResult();
-    }
 }
\ No newline at end of file