Improve TypeProviderImpl.sortTypeDefinitionAccordingDepth() 61/10261/4
authorRobert Varga <rovarga@cisco.com>
Mon, 25 Aug 2014 20:13:20 +0000 (22:13 +0200)
committerRobert Varga <rovarga@cisco.com>
Wed, 27 Aug 2014 18:54:09 +0000 (20:54 +0200)
Follow-up patch to . We do not actually need the key, so just use
values() instead of full entries.

Change-Id: Ibb5679bdf0caca140d73eb9ef065db6a58505532
Signed-off-by: Robert Varga <rovarga@cisco.com>
code-generator/binding-type-provider/src/main/java/org/opendaylight/yangtools/sal/binding/yang/types/TypeProviderImpl.java

index f1864ab1b7e5af44810b1dd9a07d5d1e81e52d6a..d48046a48b23bc76cb174d92fe70b0e9d68f686d 100644 (file)
@@ -1299,9 +1299,10 @@ public final class TypeProviderImpl implements TypeProvider {
             }
             typeDefinitionsConcreteDepth.add(unsortedTypeDefinition);
         }
-        // keys are in ascending order
-        for (Map.Entry<Integer, List<TypeDefinition<?>>> entry : typeDefinitionsDepths.entrySet()) {
-            sortedTypeDefinition.addAll(entry.getValue());
+
+        // SortedMap guarantees order corresponding to keys in ascending order
+        for (List<TypeDefinition<?>> v : typeDefinitionsDepths.values()) {
+            sortedTypeDefinition.addAll(v);
         }
 
         return sortedTypeDefinition;