CrossSourceStatementReactor.BuildAction should be final 10/101610/2
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 20 Jun 2022 12:11:59 +0000 (14:11 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 20 Jun 2022 12:14:40 +0000 (14:14 +0200)
We do not want this class to be subclassed, make sure it is final.

Change-Id: I3f0e39b13a4f5b09fc454e27acd41a5229cf7a1d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
parser/yang-parser-reactor/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/CrossSourceStatementReactor.java

index c1f969e6be8ca89c4b7ac8bde1968fbdaf24c02a..d929dd5acac1c59ce0623dcdb0b60cabe7e1bfed 100644 (file)
@@ -82,8 +82,9 @@ public final class CrossSourceStatementReactor {
         }
     }
 
-    public static class BuildAction {
+    public static final class BuildAction {
         private final BuildGlobalContext context;
+
         private boolean supportedFeaturesSet = false;
         private boolean modulesDeviatedByModulesSet = false;
 
@@ -214,12 +215,19 @@ public final class CrossSourceStatementReactor {
         }
 
         /**
-         * Build the effective model context.
+         * Build the {@link ReactorDeclaredModel} view of this action.
+         *
+         * @return A declared view of selected models.
          */
         public ReactorDeclaredModel build() throws ReactorException {
             return context.build();
         }
 
+        /**
+         * Build the {@link EffectiveSchemaContext} view of this action.
+         *
+         * @return An effective view of selected models.
+         */
         public EffectiveSchemaContext buildEffective() throws ReactorException {
             return context.buildEffective();
         }