Invert check 85/94485/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 7 Jan 2021 18:25:30 +0000 (19:25 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 7 Jan 2021 18:56:28 +0000 (19:56 +0100)
The if-body is only a single line and may easily be missed. Save
us a negation and more readable as well.

Change-Id: I7021fec717883825b371115a09da6867505ffc1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java

index 2a8124a86e76e2ce402193c05a24383f599ae552..e75960818fd548d10cbc00b419144068fdbd4db6 100644 (file)
@@ -540,9 +540,7 @@ public class BGPPeer extends AbstractPeer implements BGPSessionListener {
         this.adjRibOutListenerSet.values().forEach(AdjRibOutListener::close);
         this.adjRibOutListenerSet.clear();
         final FluentFuture<? extends CommitInfo> future;
-        if (!isRestartingGracefully()) {
-            future = terminateConnection();
-        } else {
+        if (isRestartingGracefully()) {
             final Set<TablesKey> gracefulTables = getGracefulTables();
             this.ribWriter.storeStaleRoutes(gracefulTables);
             future = this.ribWriter.clearTables(Sets.difference(this.tables, gracefulTables));
@@ -550,6 +548,8 @@ public class BGPPeer extends AbstractPeer implements BGPSessionListener {
                 this.peerRestartStopwatch = Stopwatch.createStarted();
                 handleRestartTimer();
             }
+        } else {
+            future = terminateConnection();
         }
         releaseBindingChain(isWaitForSubmitted);