Remove unneeded SuppressWarnings 07/76507/2
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 1 Oct 2018 06:01:54 +0000 (08:01 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 1 Oct 2018 06:53:33 +0000 (08:53 +0200)
We no longer do unsafe casts, remove suppression.

Change-Id: Id8fbd7b9a156265b4a18457c18561129001402e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
binding2/mdsal-binding2-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/javav2/dom/adapter/impl/operation/BindingDOMOperationServiceAdapter.java

index 5a37937e955fbcbb2910acf0ba4d85b27b28d385..80c2843f824e16d7a0fa4edf76f07ab5bbaef614 100644 (file)
@@ -44,9 +44,9 @@ public class BindingDOMOperationServiceAdapter implements RpcActionConsumerRegis
     private final BindingToNormalizedNodeCodec codec;
     private final LoadingCache<Class<? extends Rpc<?, ?>>, RpcServiceAdapter> rpcProxies = CacheBuilder.newBuilder()
             .weakKeys().build(new CacheLoader<Class<? extends Rpc<?, ?>>, RpcServiceAdapter>() {
-
-                @SuppressWarnings("unchecked")
-                private RpcServiceAdapter createProxy(final Class<? extends Rpc<?, ?>> key) {
+                @Nonnull
+                @Override
+                public RpcServiceAdapter load(@Nonnull final Class<? extends Rpc<?, ?>> key) {
                     Preconditions.checkArgument(BindingReflections.isBindingClass(key));
                     Preconditions.checkArgument(key.isInterface(),
                             "Supplied Operation service type must be interface.");
@@ -56,21 +56,14 @@ public class BindingDOMOperationServiceAdapter implements RpcActionConsumerRegis
 
                     throw new UnsupportedOperationException();
                 }
-
-                @Nonnull
-                @Override
-                public RpcServiceAdapter load(@Nonnull final Class<? extends Rpc<?, ?>> key) {
-                    return createProxy(key);
-                }
-
             });
 
     private final LoadingCache<Class<? extends Action<? extends TreeNode, ?, ?, ?>>, ActionServiceAdapter>
             actionProxies = CacheBuilder.newBuilder().weakKeys().build(
                 new CacheLoader<Class<? extends Action<? extends TreeNode, ?, ?, ?>>, ActionServiceAdapter>() {
-
-                        @SuppressWarnings("unchecked")
-                        private ActionServiceAdapter createProxy(
+                        @Nonnull
+                        @Override
+                        public ActionServiceAdapter load(@Nonnull
                                 final Class<? extends Action<? extends TreeNode, ?, ?, ?>> key) {
                             Preconditions.checkArgument(BindingReflections.isBindingClass(key));
                             Preconditions.checkArgument(key.isInterface(),
@@ -81,13 +74,6 @@ public class BindingDOMOperationServiceAdapter implements RpcActionConsumerRegis
 
                             throw new UnsupportedOperationException();
                         }
-
-                        @Nonnull
-                        @Override
-                        public ActionServiceAdapter load(@Nonnull
-                                final Class<? extends Action<? extends TreeNode, ?, ?, ?>> key) {
-                            return createProxy(key);
-                        }
                     });
 
     public BindingDOMOperationServiceAdapter(final DOMRpcService domRpcService, final DOMActionService domActionService,