Adjust for odlparent 3 Checkstyle settings 59/66459/4
authorStephen Kitt <skitt@redhat.com>
Thu, 14 Dec 2017 08:45:43 +0000 (09:45 +0100)
committerStephen Kitt <skitt@redhat.com>
Fri, 12 Jan 2018 17:24:44 +0000 (17:24 +0000)
This fixes the enforcing modules, library-impl and southbound-impl,
along with a few other violations in other modules.

Change-Id: I79a4872df64c01ae7d7e6a0722fe473576b3cff1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
37 files changed:
hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/reconciliation/connection/ConnectionReconciliationTask.java
hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transact/AbstractTransactCommand.java
hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transact/UnMetDependencyGetter.java
hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transactions/md/AbstractTransactionCommand.java
hwvtepsouthbound/hwvtepsouthbound-impl/src/test/java/org/opendaylight/ovsdb/hwvtepsouthbound/DataChangeListenerTestBase.java
hwvtepsouthbound/hwvtepsouthbound-impl/src/test/java/org/opendaylight/ovsdb/hwvtepsouthbound/UnMetDependencyGetterTest.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/impl/FutureTransformUtils.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonUtils.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/message/MonitorRequestBuilder.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/notation/json/Converter.java
library/impl/src/main/java/org/opendaylight/ovsdb/lib/schema/typed/TyperUtils.java
library/impl/src/test/java/org/opendaylight/ovsdb/lib/schema/typed/TyperUtilsTest.java
library/it/src/test/java/org/opendaylight/ovsdb/integrationtest/ovsdbclient/VersionIncompatibleBridge.java
schemas/hardwarevtep/src/main/java/org/opendaylight/ovsdb/schema/hardwarevtep/ACL.java
schemas/hardwarevtep/src/main/java/org/opendaylight/ovsdb/schema/hardwarevtep/ACLEntry.java
schemas/hardwarevtep/src/main/java/org/opendaylight/ovsdb/schema/hardwarevtep/ArpSourcesLocal.java
schemas/hardwarevtep/src/main/java/org/opendaylight/ovsdb/schema/hardwarevtep/ArpSourcesRemote.java
schemas/hardwarevtep/src/main/java/org/opendaylight/ovsdb/schema/hardwarevtep/Global.java
schemas/openvswitch/src/main/java/org/opendaylight/ovsdb/schema/openvswitch/AutoAttach.java
schemas/openvswitch/src/main/java/org/opendaylight/ovsdb/schema/openvswitch/Bridge.java
schemas/openvswitch/src/main/java/org/opendaylight/ovsdb/schema/openvswitch/Capability.java
schemas/openvswitch/src/main/java/org/opendaylight/ovsdb/schema/openvswitch/Controller.java
schemas/openvswitch/src/main/java/org/opendaylight/ovsdb/schema/openvswitch/FlowSampleCollectorSet.java
schemas/openvswitch/src/main/java/org/opendaylight/ovsdb/schema/openvswitch/FlowTable.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbSchemaContants.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundConstants.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundMapper.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundUtil.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/TransactUtils.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/transactions/md/OpenVSwitchUpdateCommand.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManagerTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/transactions/md/OpenVSwitchUpdateCommandTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbControllerUpdateCommandTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/transactions/md/OvsdbManagersUpdateCommandTest.java
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/transactions/md/TransactionInvokerImplTest.java
utils/config/src/test/java/org/opendaylight/ovsdb/utils/config/ConfigPropertiesTest.java
utils/yang-utils/src/main/java/org/opendaylight/ovsdb/utils/yang/YangUtils.java

index 476765ffe4e4cca191f2450054c74967ee0d3f2c..8a06294f7241c7066d80d8514336457fa97819b4 100644 (file)
@@ -7,10 +7,13 @@
  */
 package org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.connection;
 
+import java.net.ConnectException;
+import java.net.UnknownHostException;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager;
 import org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.ReconciliationManager;
 import org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.ReconciliationTask;
 import org.opendaylight.ovsdb.lib.OvsdbClient;
-import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepGlobalAugmentation;
 import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node;
 import org.opendaylight.yangtools.yang.binding.DataObject;
@@ -18,13 +21,10 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.net.ConnectException;
-import java.net.UnknownHostException;
-import java.util.concurrent.atomic.AtomicInteger;
-
 /**
- * Copied from org.opendaylight.ovsdb.southbound.reconciliation.connection.ConnectionReconciliationTask
+ * Copied from org.opendaylight.ovsdb.southbound.reconciliation.connection.ConnectionReconciliationTask.
  *
+ * <p>
  * Created by Anil Vishnoi (avishnoi@Brocade.com) on 3/9/16.
  */
 public class ConnectionReconciliationTask extends ReconciliationTask {
@@ -47,7 +47,7 @@ public class ConnectionReconciliationTask extends ReconciliationTask {
         boolean result = false;
         connectionAttempt.incrementAndGet();
         InstanceIdentifier<Node> nIid = (InstanceIdentifier<Node>) nodeIid;
-        HwvtepGlobalAugmentation hwvtepNode = (HwvtepGlobalAugmentation)configData;
+        HwvtepGlobalAugmentation hwvtepNode = (HwvtepGlobalAugmentation) configData;
 
         LOG.info("Retry({}) connection to Ovsdb Node {} ", connectionAttempt.get(), hwvtepNode.getConnectionInfo());
         OvsdbClient client = null;
@@ -61,7 +61,7 @@ public class ConnectionReconciliationTask extends ReconciliationTask {
                         connectionAttempt.get(), hwvtepNode.getConnectionInfo());
             }
         } catch (UnknownHostException | ConnectException e) {
-            LOG.warn("Connection retry({}) failed with exception. ",connectionAttempt.get(), e);
+            LOG.warn("Connection retry({}) failed with exception. ", connectionAttempt.get(), e);
         }
         return result;
     }
@@ -69,7 +69,7 @@ public class ConnectionReconciliationTask extends ReconciliationTask {
     @Override
     public void doRetry(boolean wasLastAttemptSuccessful) {
 
-        if( !wasLastAttemptSuccessful && connectionAttempt.get() <= MAX_ATTEMPT ) {
+        if (!wasLastAttemptSuccessful && connectionAttempt.get() <= MAX_ATTEMPT) {
             reconciliationManager.enqueueForRetry(ConnectionReconciliationTask.this);
         } else {
             reconciliationManager.dequeue(this);
index 8a997b136cef1ca0eae2936899d3ecf866e8783b..34e1165f286a72473aa06463f4bcb23f7cf29e58 100644 (file)
@@ -38,7 +38,8 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public abstract class AbstractTransactCommand<T extends Identifiable, Aug extends Augmentation<Node>> implements TransactCommand<T> {
+public abstract class AbstractTransactCommand<T extends Identifiable, A extends Augmentation<Node>>
+        implements TransactCommand<T> {
 
     private static final Logger LOG = LoggerFactory.getLogger(AbstractTransactCommand.class);
     protected static final UUID TXUUID = new UUID("TXUUID");
@@ -88,10 +89,10 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
     }
 
     void processDependencies(final UnMetDependencyGetter<T> unMetDependencyGetter,
-                             final TransactionBuilder transaction,
-                             final InstanceIdentifier<Node> nodeIid,
-                             final InstanceIdentifier key,
-                             final T data, final Object... extraData) {
+            final TransactionBuilder transaction,
+            final InstanceIdentifier<Node> nodeIid,
+            final InstanceIdentifier key,
+            final T data, final Object... extraData) {
 
         this.threadLocalDeviceTransaction.set(transaction);
         HwvtepDeviceInfo deviceInfo = getOperationalState().getDeviceInfo();
@@ -106,14 +107,15 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
         }
 
         Type type = getClass().getGenericSuperclass();
-        Type classType = ((ParameterizedType)type).getActualTypeArguments()[0];
+        Type classType = ((ParameterizedType) type).getActualTypeArguments()[0];
 
         //If this key itself is in transit wait for the response of this key itself
         if (deviceInfo.isKeyInTransit((Class<? extends Identifiable>) classType, key)) {
             inTransitDependencies.put(classType, Collections.singletonList(key));
         }
 
-        if (HwvtepSouthboundUtil.isEmptyMap(confingDependencies) && HwvtepSouthboundUtil.isEmptyMap(inTransitDependencies)) {
+        if (HwvtepSouthboundUtil.isEmptyMap(confingDependencies) && HwvtepSouthboundUtil.isEmptyMap(
+                inTransitDependencies)) {
             doDeviceTransaction(transaction, nodeIid, data, key, extraData);
             if (isRemoveCommand()) {
                 getDeviceInfo().clearConfigData((Class<? extends Identifiable>) classType, key);
@@ -127,7 +129,7 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
 
                 @Override
                 public void onDependencyResolved(HwvtepOperationalState operationalState,
-                                                 TransactionBuilder transactionBuilder) {
+                        TransactionBuilder transactionBuilder) {
                     AbstractTransactCommand.this.threadLocalOperationalState.set(operationalState);
                     AbstractTransactCommand.this.threadLocalDeviceTransaction.set(transactionBuilder);
                     onConfigUpdate(transactionBuilder, nodeIid, data, key, extraData);
@@ -150,11 +152,11 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
 
                 @Override
                 public void onDependencyResolved(HwvtepOperationalState operationalState,
-                                                 TransactionBuilder transactionBuilder) {
+                        TransactionBuilder transactionBuilder) {
                     //data would have got deleted by , push the data only if it is still in configds
                     threadLocalOperationalState.set(operationalState);
                     threadLocalDeviceTransaction.set(transactionBuilder);
-                    T data = (T)new MdsalUtils(operationalState.getDataBroker()).read(
+                    T data = (T) new MdsalUtils(operationalState.getDataBroker()).read(
                             LogicalDatastoreType.CONFIGURATION, key);
                     if (data != null) {
                         onConfigUpdate(transactionBuilder, nodeIid, data, key, extraData);
@@ -176,31 +178,32 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
     }
 
     public void doDeviceTransaction(TransactionBuilder transaction, InstanceIdentifier<Node> nodeIid, T data,
-                                    InstanceIdentifier key, Object... extraData) {
+            InstanceIdentifier key, Object... extraData) {
         //tobe removed as part of refactoring patch
     }
 
     public void onConfigUpdate(TransactionBuilder transaction, InstanceIdentifier<Node> nodeIid, T data,
-                               InstanceIdentifier key, Object... extraData) {
+            InstanceIdentifier key, Object... extraData) {
         //tobe removed as part of refactoring patch
     }
 
-    protected Aug getAugmentation(Node node) {
+    protected A getAugmentation(Node node) {
         if (node == null) {
             return null;
         }
         ParameterizedType parameterizedType = (ParameterizedType) getClass().getGenericSuperclass();
-        Class<? extends Augmentation<Node>> augType = (Class<? extends Augmentation<Node>>) parameterizedType.getActualTypeArguments()[1];
+        Class<? extends Augmentation<Node>> augType =
+                (Class<? extends Augmentation<Node>>) parameterizedType.getActualTypeArguments()[1];
         Augmentation<Node> augmentation = node.getAugmentation(augType);
-        return (Aug)augmentation;
+        return (Aaugmentation;
     }
 
-    protected List<T> getData(Aug augmentation) {
+    protected List<T> getData(A augmentation) {
         return Collections.EMPTY_LIST;
     }
 
     protected List<T> getData(Node node) {
-        Aug augmentation = getAugmentation(node);
+        A augmentation = getAugmentation(node);
         if (augmentation != null) {
             List<T> data = getData(augmentation);
             if (data != null) {
@@ -249,7 +252,7 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
         return result;
     }
 
-    List<T>  getCascadeDeleteData(DataTreeModification<Node> change) {
+    List<T> getCascadeDeleteData(DataTreeModification<Node> change) {
         if (!cascadeDelete()) {
             return Collections.EMPTY_LIST;
         }
@@ -258,7 +261,8 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
         List<T> updatedData = getData(updatedNode);
         Set<InstanceIdentifier> deleted = getOperationalState().getDeletedKeysInCurrentTx(LogicalSwitches.class);
         UnMetDependencyGetter dependencyGetter = getDependencyGetter();
-        if (!HwvtepSouthboundUtil.isEmpty(deleted) && !HwvtepSouthboundUtil.isEmpty(updatedData) && dependencyGetter != null) {
+        if (!HwvtepSouthboundUtil.isEmpty(deleted) && !HwvtepSouthboundUtil.isEmpty(updatedData)
+                && dependencyGetter != null) {
             List<T> removed = new ArrayList<>();
             for (T ele : updatedData) {
                 if (deleted.containsAll(dependencyGetter.getLogicalSwitchDependencies(ele))) {
@@ -312,14 +316,14 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
 
         Iterator<T> it1 = list1.iterator();
 
-        while(it1.hasNext()) {
+        while (it1.hasNext()) {
             T ele = it1.next();
             Iterator<T> it2 = list2.iterator();
             boolean found = false;
             while (it2.hasNext()) {
-                T other  = it2.next();
+                T other = it2.next();
                 found = compareKeyOnly ? Objects.equals(ele.getKey(), other.getKey()) : areEqual(ele, other);
-                if ( found ) {
+                if (found) {
                     it2.remove();
                     break;
                 }
@@ -334,11 +338,11 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
 
     protected Type getClassType() {
         Type type = getClass().getGenericSuperclass();
-        Type classType = ((ParameterizedType)type).getActualTypeArguments()[0];
+        Type classType = ((ParameterizedType) type).getActualTypeArguments()[0];
         return classType;
     }
 
-    protected boolean areEqual(T a , T b) {
+    protected boolean areEqual(T a, T b) {
         return a.getKey().equals(b.getKey());
     }
 
@@ -349,6 +353,7 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
     /**
      * Tells if this object needs to be deleted if its dependent object gets deleted
      * Ex : LocalUcastMac and LocalMacstMac
+     *
      * @return true if this object needs to be deleted if its dependent object gets deleted
      */
     protected boolean cascadeDelete() {
@@ -379,7 +384,8 @@ public abstract class AbstractTransactCommand<T extends Identifiable, Aug extend
             return;
         }
         for (MdsalUpdate mdsalUpdate : updates.get(deviceTransaction)) {
-            getDeviceInfo().clearInTransit((Class<? extends Identifiable>)mdsalUpdate.getClass(), mdsalUpdate.getKey());
+            getDeviceInfo().clearInTransit((Class<? extends Identifiable>) mdsalUpdate.getClass(),
+                    mdsalUpdate.getKey());
         }
         onCommandFailed();
     }
index 2141925e217e98f1bf124e10557fd02f20205bfe..71cca6c68b537e81995c5e04f00540d8bf0414a8 100644 (file)
@@ -24,7 +24,8 @@ import java.util.List;
 import java.util.Map;
 
 /**
- * Utility class to retrieve the unmet dependencies (config/operational) of the given object
+ * Utility class to retrieve the unmet dependencies (config/operational) of the given object.
+ *
  * @param <T>
  */
 public abstract class UnMetDependencyGetter<T extends Identifiable> {
@@ -34,10 +35,11 @@ public abstract class UnMetDependencyGetter<T extends Identifiable> {
 
     /**
      * Returns the iids this data depends upon
-     * which are already intransit in the previous transaction if any
-     * @param opState   The operatonal state
-     * @param data      The data object
-     * @return          The depenencies
+     * which are already intransit in the previous transaction if any.
+     *
+     * @param opState The operatonal state
+     * @param data The data object
+     * @return The depenencies
      */
     public Map<Class<? extends Identifiable>, List<InstanceIdentifier>> getInTransitDependencies(
             HwvtepOperationalState opState, T data) {
@@ -46,9 +48,10 @@ public abstract class UnMetDependencyGetter<T extends Identifiable> {
 
     /**
      * Returns the iids this data depends upon
-     * which are not yet present in the config data store if any
-     * @param opState   The operatonal state
-     * @param data      The data object
+     * which are not yet present in the config data store if any.
+     *
+     * @param opState The operatonal state
+     * @param data The data object
      * @return the      depenencies
      */
     public Map<Class<? extends Identifiable>, List<InstanceIdentifier>> getUnMetConfigDependencies(
@@ -91,12 +94,12 @@ public abstract class UnMetDependencyGetter<T extends Identifiable> {
         }
 
         abstract boolean isDependencyMet(HwvtepOperationalState opState, HwvtepDeviceInfo deviceInfo,
-                                         Class<? extends Identifiable> cls, InstanceIdentifier<? extends DataObject> key);
+                Class<? extends Identifiable> cls, InstanceIdentifier<? extends DataObject> key);
     }
 
     class ConfigDependencyGetter extends DependencyGetter {
         boolean isDependencyMet(HwvtepOperationalState opState, HwvtepDeviceInfo deviceInfo,
-                                Class<? extends Identifiable> cls, InstanceIdentifier<? extends DataObject> key) {
+                Class<? extends Identifiable> cls, InstanceIdentifier<? extends DataObject> key) {
             return deviceInfo.isConfigDataAvailable(cls, key) || isConfigDataAvailable(opState, key);
         }
 
@@ -109,7 +112,7 @@ public abstract class UnMetDependencyGetter<T extends Identifiable> {
 
     class InTransitDependencyGetter extends DependencyGetter {
         boolean isDependencyMet(HwvtepOperationalState opState, HwvtepDeviceInfo deviceInfo,
-                                Class<? extends Identifiable> cls, InstanceIdentifier<? extends DataObject> key) {
+                Class<? extends Identifiable> cls, InstanceIdentifier<? extends DataObject> key) {
             return opState.isKeyPartOfCurrentTx(cls, key) || !deviceInfo.isKeyInTransit(cls, key);
         }
     }
index 8e513e8bb2a1637dfa292991d021948689a2b7ad..ec19f3b5b023c64489fcc78dd50fb46fa5ff8921 100644 (file)
@@ -11,14 +11,11 @@ package org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md;
 import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionInstance;
 import org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDeviceInfo;
 import org.opendaylight.ovsdb.lib.message.TableUpdates;
-import org.opendaylight.ovsdb.lib.notation.UUID;
 import org.opendaylight.ovsdb.lib.schema.DatabaseSchema;
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.hwvtep.global.attributes.ConnectionInfo;
 import org.opendaylight.yangtools.yang.binding.DataObject;
-import org.opendaylight.yangtools.yang.binding.Identifiable;
-import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
-public abstract class AbstractTransactionCommand<T extends DataObject> implements TransactionCommand{
+public abstract class AbstractTransactionCommand<T extends DataObject> implements TransactionCommand {
 
     private TableUpdates updates;
     private DatabaseSchema dbSchema;
@@ -40,7 +37,7 @@ public abstract class AbstractTransactionCommand<T extends DataObject> implement
         return key;
     }
 
-    public AbstractTransactionCommand(HwvtepConnectionInstance key,TableUpdates updates, DatabaseSchema dbSchema) {
+    public AbstractTransactionCommand(HwvtepConnectionInstance key, TableUpdates updates, DatabaseSchema dbSchema) {
         this.updates = updates;
         this.dbSchema = dbSchema;
         this.key = key;
index f8ec1133039671179b21ac55044f19c1fb69f405..6bd9eed7e6f6315701795abef0e8429f8b153fab 100644 (file)
@@ -8,9 +8,25 @@
 
 package org.opendaylight.ovsdb.hwvtepsouthbound;
 
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyString;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
+import static org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType.CONFIGURATION;
+import static org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType.OPERATIONAL;
+import static org.powermock.api.support.membermodification.MemberMatcher.field;
+import static org.powermock.api.support.membermodification.MemberModifier.suppress;
+
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.util.concurrent.ListenableFuture;
+import java.io.IOException;
+import java.io.InputStream;
+import java.lang.reflect.Field;
+import java.lang.reflect.Modifier;
+import java.net.InetAddress;
+import java.util.List;
+import java.util.concurrent.ExecutionException;
 import org.apache.commons.lang3.reflect.FieldUtils;
 import org.junit.After;
 import org.junit.Before;
@@ -57,22 +73,6 @@ import org.powermock.api.mockito.PowerMockito;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.InputStream;
-import java.lang.reflect.Field;
-import java.lang.reflect.Modifier;
-import java.net.InetAddress;
-import java.util.List;
-
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyString;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-import static org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType.CONFIGURATION;
-import static org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType.OPERATIONAL;
-import static org.powermock.api.support.membermodification.MemberMatcher.field;
-import static org.powermock.api.support.membermodification.MemberModifier.suppress;
-
 public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
 
     static Logger LOG = LoggerFactory.getLogger(DataChangeListenerTestBase.class);
@@ -111,10 +111,10 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
         entityOwnershipService = mock(EntityOwnershipService.class);
         nodeUuid = java.util.UUID.randomUUID().toString();
         nodeIid = createInstanceIdentifier(nodeUuid);
-        ls0Iid = nodeIid.augmentation(HwvtepGlobalAugmentation.class).
-                child(LogicalSwitches.class, new LogicalSwitchesKey(new HwvtepNodeName("ls0")));
-        ls1Iid = nodeIid.augmentation(HwvtepGlobalAugmentation.class).
-                child(LogicalSwitches.class, new LogicalSwitchesKey(new HwvtepNodeName("ls1")));
+        ls0Iid = nodeIid.augmentation(HwvtepGlobalAugmentation.class).child(LogicalSwitches.class,
+                new LogicalSwitchesKey(new HwvtepNodeName("ls0")));
+        ls1Iid = nodeIid.augmentation(HwvtepGlobalAugmentation.class).child(LogicalSwitches.class,
+                new LogicalSwitchesKey(new HwvtepNodeName("ls1")));
         loadSchema();
         mockConnectionInstance();
         mockConnectionManager();
@@ -133,7 +133,7 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
     }
 
     void setFinalStatic(Class cls, String fieldName, Object newValue) throws Exception {
-        Field fields[] = FieldUtils.getAllFields(cls);
+        Field[] fields = FieldUtils.getAllFields(cls);
         for (Field field : fields) {
             if (fieldName.equals(field.getName())) {
                 field.setAccessible(true);
@@ -147,14 +147,15 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
     }
 
     void loadSchema() {
-        try (InputStream resourceAsStream = DataChangeListenerTestBase.class.getResourceAsStream("hwvtep_schema.json")) {
+        try (InputStream resourceAsStream = DataChangeListenerTestBase.class.getResourceAsStream(
+                "hwvtep_schema.json")) {
             ObjectMapper mapper = new ObjectMapper();
             JsonNode jsonNode = mapper.readTree(resourceAsStream);
             dbSchema = DatabaseSchema.fromJson(HwvtepSchemaConstants.HARDWARE_VTEP,
                     jsonNode.get("result"));
             listenableDbSchema = mock(ListenableFuture.class);
             doReturn(dbSchema).when(listenableDbSchema).get();
-        } catch (Exception e) {
+        } catch (IOException | ExecutionException | InterruptedException e) {
             LOG.error("Failed to load schema", e);
         }
     }
@@ -163,8 +164,10 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
         hwvtepConnectionManager = PowerMockito.mock(HwvtepConnectionManager.class, Mockito.CALLS_REAL_METHODS);
         field(HwvtepConnectionManager.class, "db").set(hwvtepConnectionManager, dataBroker);
         field(HwvtepConnectionManager.class, "txInvoker").set(hwvtepConnectionManager, transactionInvoker);
-        field(HwvtepConnectionManager.class, "entityOwnershipService").set(hwvtepConnectionManager, entityOwnershipService);
-        suppress(PowerMockito.method(HwvtepConnectionManager.class, "getConnectionInstance", HwvtepPhysicalSwitchAttributes.class));
+        field(HwvtepConnectionManager.class, "entityOwnershipService").set(hwvtepConnectionManager,
+                entityOwnershipService);
+        suppress(PowerMockito.method(HwvtepConnectionManager.class, "getConnectionInstance",
+                HwvtepPhysicalSwitchAttributes.class));
         suppress(PowerMockito.method(HwvtepConnectionManager.class, "getConnectionInstanceFromNodeIid",
                 InstanceIdentifier.class));
         doReturn(connectionInstance).when(
@@ -183,7 +186,7 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
         doReturn(true).when(ovsdbClient).isActive();
         doReturn(connectionInfo).when(ovsdbClient).getConnectionInfo();
 
-        transactionInvoker =  new TransactionInvokerImpl(dataBroker);
+        transactionInvoker = new TransactionInvokerImpl(dataBroker);
 
         connectionInstance = PowerMockito.mock(HwvtepConnectionInstance.class, Mockito.CALLS_REAL_METHODS);
         field(HwvtepConnectionInstance.class, "instanceIdentifier").set(connectionInstance, nodeIid);
@@ -193,7 +196,8 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
         doReturn(listenableDbSchema).when(connectionInstance).getSchema(anyString());
         doReturn(dataBroker).when(connectionInstance).getDataBroker();
         doReturn(nodeIid).when(connectionInstance).getInstanceIdentifier();
-        field(HwvtepConnectionInstance.class, "deviceInfo").set(connectionInstance, new HwvtepDeviceInfo(connectionInstance));
+        field(HwvtepConnectionInstance.class, "deviceInfo").set(connectionInstance,
+                new HwvtepDeviceInfo(connectionInstance));
         connectionInstance.createTransactInvokers();
     }
 
@@ -202,18 +206,18 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
     }
 
     /**
-     * resets the captures so that we can validate the captors of the immediate next execution
+     * Resets the captures so that we can validate the captors of the immediate next execution.
      */
     void resetOperations() {
         insertOpCapture = ArgumentCaptor.forClass(TypedBaseTable.class);
-        Update update = mock(Update.class);
-        Insert insert = mock(Insert.class);
         Delete delete = mock(Delete.class);
         Where where = mock(Where.class);
         doReturn(where).when(delete).where(any());
+        Insert insert = mock(Insert.class);
         doReturn(insert).when(insert).withId(any(String.class));
         Operations.op = PowerMockito.mock(Operations.class);
         doReturn(insert).when(Operations.op).insert(insertOpCapture.capture());
+        Update update = mock(Update.class);
         doReturn(update).when(Operations.op).update(insertOpCapture.capture());
         doReturn(where).when(update).where(any());
         doReturn(delete).when(Operations.op).delete(any());
@@ -238,7 +242,7 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
     }
 
     Node addData(LogicalDatastoreType logicalDatastoreType, Class<? extends DataObject> dataObject,
-                 String[]... data) {
+            String[]... data) {
         NodeBuilder nodeBuilder = prepareNode(nodeIid);
         HwvtepGlobalAugmentationBuilder builder = new HwvtepGlobalAugmentationBuilder();
         if (LogicalSwitches.class == dataObject) {
@@ -258,7 +262,7 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
     }
 
     void deleteData(LogicalDatastoreType logicalDatastoreType, Class<? extends DataObject> dataObject,
-                 String[]... data) {
+            String[]... data) {
         NodeBuilder nodeBuilder = prepareNode(nodeIid);
         ReadWriteTransaction tx = dataBroker.newReadWriteTransaction();
         HwvtepGlobalAugmentationBuilder builder = new HwvtepGlobalAugmentationBuilder();
@@ -266,8 +270,8 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
             List<LogicalSwitches> logicalSwitches = TestBuilders.addLogicalSwitches(builder, data);
 
             for (LogicalSwitches ls : logicalSwitches) {
-                InstanceIdentifier<LogicalSwitches> key = nodeIid.augmentation(HwvtepGlobalAugmentation.class).
-                        child(LogicalSwitches.class, ls.getKey());
+                InstanceIdentifier<LogicalSwitches> key =
+                        nodeIid.augmentation(HwvtepGlobalAugmentation.class).child(LogicalSwitches.class, ls.getKey());
                 tx.delete(logicalDatastoreType, key);
             }
         }
@@ -277,16 +281,16 @@ public class DataChangeListenerTestBase extends AbstractDataBrokerTest {
         if (RemoteUcastMacs.class == dataObject) {
             List<RemoteUcastMacs> macs = TestBuilders.addRemoteUcastMacs(nodeIid, builder, data);
             for (RemoteUcastMacs mac : macs) {
-                InstanceIdentifier<RemoteUcastMacs> key = nodeIid.augmentation(HwvtepGlobalAugmentation.class).
-                        child(RemoteUcastMacs.class, mac.getKey());
+                InstanceIdentifier<RemoteUcastMacs> key =
+                        nodeIid.augmentation(HwvtepGlobalAugmentation.class).child(RemoteUcastMacs.class, mac.getKey());
                 tx.delete(logicalDatastoreType, key);
             }
         }
         if (RemoteMcastMacs.class == dataObject) {
             List<RemoteMcastMacs> macs = TestBuilders.addRemoteMcastMacs(nodeIid, builder, data);
             for (RemoteMcastMacs mac : macs) {
-                InstanceIdentifier<RemoteMcastMacs> key = nodeIid.augmentation(HwvtepGlobalAugmentation.class).
-                        child(RemoteMcastMacs.class, mac.getKey());
+                InstanceIdentifier<RemoteMcastMacs> key =
+                        nodeIid.augmentation(HwvtepGlobalAugmentation.class).child(RemoteMcastMacs.class, mac.getKey());
                 tx.delete(logicalDatastoreType, key);
             }
         }
index 1cd938df3d7d0383a5dfbad7f6377bc7451255ac..3a4075bb8c62bad6e8072c75326c03eba929720e 100644 (file)
@@ -44,10 +44,11 @@ public class UnMetDependencyGetterTest extends DataChangeListenerTestBase {
     Map<Class<? extends Identifiable>, List<InstanceIdentifier>> unMetDependencies;
 
     void setupForTest() {
-        MCAST_MAC_DATA_VALIDATOR = Whitebox.getInternalState(McastMacsRemoteUpdateCommand.class, UnMetDependencyGetter.class);
+        MCAST_MAC_DATA_VALIDATOR =
+                Whitebox.getInternalState(McastMacsRemoteUpdateCommand.class, UnMetDependencyGetter.class);
         opState = new HwvtepOperationalState(connectionInstance);
-        mac = TestBuilders.buildRemoteMcastMacs(nodeIid,"FF:FF:FF:FF:FF:FF", "ls0",
-                new String[]{"192.168.122.20", "192.168.122.30"});
+        mac = TestBuilders.buildRemoteMcastMacs(nodeIid, "FF:FF:FF:FF:FF:FF", "ls0",
+                new String[] {"192.168.122.20", "192.168.122.30"});
         lsIid = nodeIid.augmentation(HwvtepGlobalAugmentation.class).
                 child(LogicalSwitches.class, new LogicalSwitchesKey(new HwvtepNodeName("ls0")));
     }
index e81ddb4a97a2d40efeb0ce6ad8cb3e9454061d63..026fcaa15a35232407e4ee16de4e1dc59a313bea 100644 (file)
@@ -11,7 +11,6 @@ package org.opendaylight.ovsdb.lib.impl;
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import com.google.common.base.Function;
 import com.google.common.util.concurrent.Futures;
 import com.google.common.util.concurrent.ListenableFuture;
 import java.util.ArrayList;
@@ -19,58 +18,57 @@ import java.util.List;
 import org.opendaylight.ovsdb.lib.operations.Operation;
 import org.opendaylight.ovsdb.lib.operations.OperationResult;
 
-public class FutureTransformUtils {
+public final class FutureTransformUtils {
     private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
 
     private FutureTransformUtils() {
     }
 
-    public static final ListenableFuture<List<OperationResult>> transformTransactResponse(
+    public static ListenableFuture<List<OperationResult>> transformTransactResponse(
             ListenableFuture<List<JsonNode>> transactResponseFuture, final List<Operation> operations) {
         OBJECT_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
-        return Futures.transform(transactResponseFuture,
-            (Function<List<JsonNode>, List<OperationResult>>) jsonNodes -> {
-                final List<OperationResult> operationResults = new ArrayList<>();
-                for (int index = 0; index < jsonNodes.size(); index++) {
-                    JsonNode jsonNode = jsonNodes.get(index);
-                    OperationResult or;
-                    if (jsonNode != null && jsonNode.size() > 0) {
-                        /*
-                         * As per RFC 7047, section 4.1.3 :
-                         * "In general, "result" contains some number of successful results,
-                         * possibly followed by an error, in turn followed by enough JSON null
-                         * values to match the number of elements in "params".  There is one
-                         * exception: if all of the operations succeed, but the results cannot
-                         * be committed, then "result" will have one more element than "params",
-                         * with the additional element being an <error>."
-                         *
-                         * Hence, it is possible for a transaction response to contain more
-                         * json elements than the transaction operation request.
-                         * Also handle that case by checking for i < operations.size().
-                         */
-                        if (index < operations.size()) {
-                            Operation op = operations.get(index);
-                            switch (op.getOp()) {
-                                case "select":
-                                    or = new OperationResult();
-                                    or.setRows(op.getTableSchema().createRows(jsonNode));
-                                    break;
+        return Futures.transform(transactResponseFuture, jsonNodes -> {
+            final List<OperationResult> operationResults = new ArrayList<>();
+            for (int index = 0; index < jsonNodes.size(); index++) {
+                JsonNode jsonNode = jsonNodes.get(index);
+                OperationResult or;
+                if (jsonNode != null && jsonNode.size() > 0) {
+                    /*
+                     * As per RFC 7047, section 4.1.3 :
+                     * "In general, "result" contains some number of successful results,
+                     * possibly followed by an error, in turn followed by enough JSON null
+                     * values to match the number of elements in "params".  There is one
+                     * exception: if all of the operations succeed, but the results cannot
+                     * be committed, then "result" will have one more element than "params",
+                     * with the additional element being an <error>."
+                     *
+                     * Hence, it is possible for a transaction response to contain more
+                     * json elements than the transaction operation request.
+                     * Also handle that case by checking for i < operations.size().
+                     */
+                    if (index < operations.size()) {
+                        Operation op = operations.get(index);
+                        switch (op.getOp()) {
+                            case "select":
+                                or = new OperationResult();
+                                or.setRows(op.getTableSchema().createRows(jsonNode));
+                                break;
 
-                                default:
-                                    or = OBJECT_MAPPER.convertValue(jsonNode, OperationResult.class);
+                            default:
+                                or = OBJECT_MAPPER.convertValue(jsonNode, OperationResult.class);
 
-                                    break;
-                            }
-                        } else {
-                            or = OBJECT_MAPPER.convertValue(jsonNode, OperationResult.class);
+                                break;
                         }
                     } else {
-                        or = new OperationResult();
+                        or = OBJECT_MAPPER.convertValue(jsonNode, OperationResult.class);
                     }
-                    operationResults.add(or);
+                } else {
+                    or = new OperationResult();
                 }
+                operationResults.add(or);
+            }
 
-                return operationResults;
-            });
+            return operationResults;
+        });
     }
 }
index 3b4c542978dedab7043f251be32d4c4f71314635..a0a4ddd598f2fade422a19fcf3c2af87d030cc40 100644 (file)
@@ -11,7 +11,7 @@ import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectWriter;
 
-public class JsonUtils {
+public final class JsonUtils {
 
     private static ObjectMapper mapper = new ObjectMapper();
     private static ObjectWriter prettyWriter = mapper.writerWithDefaultPrettyPrinter();
index f04dd19ede9e385aa92672549125e7165bbd8174..95e9d4924fee9a471f1a3dead8bacbb5ab0ccfa3 100644 (file)
@@ -34,13 +34,13 @@ public class MonitorRequestBuilder<E extends TableSchema<E>> {
         return this;
     }
 
-    public MonitorRequestBuilder<E> addColumns(Collection<String> columns) {
-        this.columns.addAll(columns);
+    public MonitorRequestBuilder<E> addColumns(Collection<String> extraColumns) {
+        this.columns.addAll(extraColumns);
         return this;
     }
 
-    public MonitorRequestBuilder<E> addColumns(List<ColumnSchema<E, ?>> columns) {
-        for (ColumnSchema<E, ?> schema : columns) {
+    public MonitorRequestBuilder<E> addColumns(List<ColumnSchema<E, ?>> extraColumns) {
+        for (ColumnSchema<E, ?> schema : extraColumns) {
             this.addColumn(schema);
         }
         return this;
@@ -50,8 +50,8 @@ public class MonitorRequestBuilder<E extends TableSchema<E>> {
         return this.columns;
     }
 
-    public MonitorRequestBuilder<E> with(MonitorSelect select) {
-        this.select = select;
+    public MonitorRequestBuilder<E> with(MonitorSelect what) {
+        this.select = what;
         return this;
     }
 
index 028506e33e7d71406b1f4baad4b657af0c4cddd2..97e588c6f8db3cc17058997a0b31301397369371 100644 (file)
@@ -18,7 +18,7 @@ import org.opendaylight.ovsdb.lib.notation.OvsdbMap;
 import org.opendaylight.ovsdb.lib.notation.OvsdbSet;
 import org.opendaylight.ovsdb.lib.notation.UUID;
 
-public class Converter {
+public final class Converter {
 
     static AtomDeser atomDeser = new AtomDeser();
     static MapDeser mapDeser = new MapDeser();
index 3025ebe66da96f548d1f018002ff66b57d3df7e3..c9ef9ebefc2d79c45101139b70515daeea3011ea 100644 (file)
@@ -33,7 +33,7 @@ import org.opendaylight.ovsdb.lib.schema.TableSchema;
 /**
  * Utility methods for typed OVSDB schema data.
  */
-public class TyperUtils {
+public final class TyperUtils {
 
     private static final String GET_STARTS_WITH = "get";
     private static final String SET_STARTS_WITH = "set";
index 823d89f2e0b855fcf6a8549ca1007ecd884df025..e64203b3fc6c10a9f525ede3e1584e3b4a1ea2a4 100644 (file)
@@ -170,6 +170,8 @@ public class TyperUtilsTest {
      * @param to The maximum supported version.
      * @throws SchemaVersionMismatchException if the schema version isn't supported.
      */
+    // We extract the real cause, which “loses” the original cause, but that’s fine
+    @SuppressWarnings("checkstyle:AvoidHidingCauseException")
     private void callCheckVersion(Version schema, Version from, Version to) throws SchemaVersionMismatchException {
         try {
             Method method =
index 243c1a344a52cd522888b4d181b7a7c0f16f157f..1d99dc3e04b43073d5a29e7f4d0a885ff5c4e358 100644 (file)
@@ -14,6 +14,6 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
  * VersionIncompatibleBridge is used to test the Version Compatibility logic in the Library
  * with an absurdly low fromVersion and untilVersion which will fail for all the OVS versions.
  */
-@TypedTable(name="Bridge", database="Open_vSwitch", fromVersion="0.0.1", untilVersion="0.0.2")
+@TypedTable(name = "Bridge", database = "Open_vSwitch", fromVersion = "0.0.1", untilVersion = "0.0.2")
 public interface VersionIncompatibleBridge extends TypedBaseTable {
 }
index 7167b0af1530fd13719dacd36908bb9c870e03c6..664fc5a24ad7cce51f9ce52499b43ceeabc11eef 100644 (file)
@@ -9,7 +9,6 @@
 package org.opendaylight.ovsdb.schema.hardwarevtep;
 
 import java.util.Map;
-
 import org.opendaylight.ovsdb.lib.notation.Column;
 import org.opendaylight.ovsdb.lib.notation.UUID;
 import org.opendaylight.ovsdb.lib.schema.GenericTableSchema;
@@ -18,28 +17,28 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedBaseTable;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
-@TypedTable(name="ACL", database="hardware_vtep", fromVersion="1.4.0")
+@TypedTable(name = "ACL", database = "hardware_vtep", fromVersion = "1.4.0")
 public interface ACL extends TypedBaseTable<GenericTableSchema> {
-    @TypedColumn(name="acl_name", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_name", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, String> getAclNameColumn();
 
-    @TypedColumn(name="acl_name", method=MethodType.GETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_name", method = MethodType.GETDATA, fromVersion = "1.4.0")
     String getAclName();
 
-    @TypedColumn(name="acl_name", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_name", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setAclName(String aclName);
 
 
-    @TypedColumn(name="acl_entries", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_entries", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, UUID> getAclEntriesColumn();
 
-    @TypedColumn(name="acl_entries", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_entries", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setAclEntry(UUID aclEntry);
 
 
-    @TypedColumn(name="acl_fault_status", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_fault_status", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Map<String, String>> getAclFaultStatusColumn();
 
-    @TypedColumn(name="acl_fault_status", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "acl_fault_status", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setAclFaultStatus(Map<String, String> aclFaultStatus);
 }
index a68ad9fe5d88199dfe4a18b12da8553cb610e3e1..9135abf7a8263b7f4e80c4155f61bc826ff093d7 100644 (file)
@@ -18,143 +18,143 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedBaseTable;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
-@TypedTable(name="ACL_entry", database="hardware_vtep", fromVersion="1.4.0")
+@TypedTable(name = "ACL_entry", database = "hardware_vtep", fromVersion = "1.4.0")
 public interface ACLEntry extends TypedBaseTable<GenericTableSchema> {
-    @TypedColumn(name="sequence", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "sequence", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Long> getSequenceColumn();
 
-    @TypedColumn(name="sequence", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "sequence", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setSequence(Long sequence);
 
 
-    @TypedColumn(name="source_mac", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "source_mac", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getSourceMacColumn();
 
-    @TypedColumn(name="source_mac", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "source_mac", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setSourceMac(Set<String> sourceMac);
 
 
-    @TypedColumn(name="dest_mac", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_mac", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getDestMacColumn();
 
-    @TypedColumn(name="dest_mac", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_mac", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setDestMac(Set<String> destMac);
 
 
-    @TypedColumn(name="ethertype", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "ethertype", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getEtherTypeColumn();
 
-    @TypedColumn(name="ethertype", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "ethertype", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setEtherType(Set<String> etherType);
 
 
-    @TypedColumn(name="source_ip", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "source_ip", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getSourceIpColumn();
 
-    @TypedColumn(name="source_ip", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "source_ip", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setSourceIp(Set<String> sourceIp);
 
 
-    @TypedColumn(name="source_mask", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "source_mask", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getSourceMaskColumn();
 
-    @TypedColumn(name="source_mask", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "source_mask", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setSourceMask(Set<String> sourceMask);
 
 
-    @TypedColumn(name="dest_ip", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_ip", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getDestIpColumn();
 
-    @TypedColumn(name="dest_ip", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_ip", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setDestIp(Set<String> destIp);
 
 
-    @TypedColumn(name="dest_mask", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_mask", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getDestMaskColumn();
 
-    @TypedColumn(name="dest_mask", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_mask", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setDestMask(Set<String> destMask);
 
 
-    @TypedColumn(name="protocol", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "protocol", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getProtocolColumn();
 
-    @TypedColumn(name="protocol", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "protocol", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setProtocol(Set<Long> protocol);
 
 
-    @TypedColumn(name="source_port_min", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "source_port_min", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getSourcePortMinColumn();
 
-    @TypedColumn(name="source_port_min", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "source_port_min", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setSourcePortMin(Set<Long> sourcePortMin);
 
 
-    @TypedColumn(name="source_port_max", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "source_port_max", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getSourcePortMaxColumn();
 
-    @TypedColumn(name="source_port_max", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "source_port_max", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setSourcePortMax(Set<Long> sourcePortMax);
 
 
-    @TypedColumn(name="dest_port_min", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_port_min", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getDestPortMinColumn();
 
-    @TypedColumn(name="dest_port_min", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_port_min", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setDestPortMin(Set<Long> destPortMin);
 
 
-    @TypedColumn(name="dest_port_max", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_port_max", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getDestPortMaxColumn();
 
-    @TypedColumn(name="dest_port_max", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "dest_port_max", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setDestPortMax(Set<Long> destPortMax);
 
 
-    @TypedColumn(name="tcp_flags", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "tcp_flags", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getTcpFlagsColumn();
 
-    @TypedColumn(name="tcp_flags", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "tcp_flags", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setTcpFlags(Set<Long> tcpFlags);
 
 
-    @TypedColumn(name="tcp_flags_mask", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "tcp_flags_mask", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getTcpFlagsMaskColumn();
 
-    @TypedColumn(name="tcp_flags_mask", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "tcp_flags_mask", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setTcpFlagsMask(Set<Long> tcpFlagsMask);
 
 
-    @TypedColumn(name="icmp_code", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "icmp_code", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getIcmpCodeColumn();
 
-    @TypedColumn(name="icmp_code", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "icmp_code", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setIcmpCode(Set<Long> icmpCode);
 
 
-    @TypedColumn(name="icmp_type", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "icmp_type", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<Long>> getIcmpTypeColumn();
 
-    @TypedColumn(name="icmp_type", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "icmp_type", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setIcmpType(Set<Long> icmpType);
 
 
-    @TypedColumn(name="direction", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "direction", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getDirectionColumn();
 
-    @TypedColumn(name="direction", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "direction", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setDirection(Set<String> direction);
 
 
-    @TypedColumn(name="action", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "action", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Set<String>> getActionColumn();
 
-    @TypedColumn(name="action", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "action", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setAction(Set<String> action);
 
-    @TypedColumn(name="acle_fault_status", method=MethodType.GETCOLUMN, fromVersion="1.4.0")
+    @TypedColumn(name = "acle_fault_status", method = MethodType.GETCOLUMN, fromVersion = "1.4.0")
     Column<GenericTableSchema, Map<String, String>> getAcleFaultStatusColumn();
 
-    @TypedColumn(name="acle_fault_status", method=MethodType.SETDATA, fromVersion="1.4.0")
+    @TypedColumn(name = "acle_fault_status", method = MethodType.SETDATA, fromVersion = "1.4.0")
     void setAcleFaultStatus(Map<String, String> acleFaultStatus);
 }
index d6be9d43d4a6cd2ae184fe11ea379e89316a6235..f84b6c63c289ae4eed1a97d6fea629fa17ccb379 100644 (file)
@@ -16,20 +16,20 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedBaseTable;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
-@TypedTable(name="Arp_Sources_Local", database="hardware_vtep", fromVersion="1.2.0")
+@TypedTable(name = "Arp_Sources_Local", database = "hardware_vtep", fromVersion = "1.2.0")
 public interface ArpSourcesLocal extends TypedBaseTable<GenericTableSchema> {
-    @TypedColumn(name="src_mac", method=MethodType.GETCOLUMN, fromVersion="1.2.0")
+    @TypedColumn(name = "src_mac", method = MethodType.GETCOLUMN, fromVersion = "1.2.0")
     Column<GenericTableSchema, String> getSrcMacColumn();
 
-    @TypedColumn(name="src_mac", method=MethodType.GETDATA, fromVersion="1.2.0")
+    @TypedColumn(name = "src_mac", method = MethodType.GETDATA, fromVersion = "1.2.0")
     String getSrcMac();
 
-    @TypedColumn(name="src_mac", method=MethodType.SETDATA, fromVersion="1.2.0")
+    @TypedColumn(name = "src_mac", method = MethodType.SETDATA, fromVersion = "1.2.0")
     void setSrcMac(String srcMac);
 
-    @TypedColumn(name="locator", method=MethodType.GETCOLUMN, fromVersion="1.2.0")
+    @TypedColumn(name = "locator", method = MethodType.GETCOLUMN, fromVersion = "1.2.0")
     Column<GenericTableSchema, UUID> getLocatorColumn();
 
-    @TypedColumn(name="locator", method=MethodType.SETDATA, fromVersion="1.2.0")
+    @TypedColumn(name = "locator", method = MethodType.SETDATA, fromVersion = "1.2.0")
     void setLocator(UUID locator);
 }
index 849dd07203275fc60c6a45a0adef2b9e74d21e4b..2886fde8053fa12af5fe7c95e7e5f403c6943755 100644 (file)
@@ -16,20 +16,20 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedBaseTable;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
-@TypedTable(name="Arp_Sources_Remote", database="hardware_vtep", fromVersion="1.2.0")
+@TypedTable(name = "Arp_Sources_Remote", database = "hardware_vtep", fromVersion = "1.2.0")
 public interface ArpSourcesRemote extends TypedBaseTable<GenericTableSchema> {
-    @TypedColumn(name="src_mac", method=MethodType.GETCOLUMN, fromVersion="1.2.0")
+    @TypedColumn(name = "src_mac", method = MethodType.GETCOLUMN, fromVersion = "1.2.0")
     Column<GenericTableSchema, String> getSrcMacColumn();
 
-    @TypedColumn(name="src_mac", method=MethodType.GETDATA, fromVersion="1.2.0")
+    @TypedColumn(name = "src_mac", method = MethodType.GETDATA, fromVersion = "1.2.0")
     String getSrcMac();
 
-    @TypedColumn(name="src_mac", method=MethodType.SETDATA, fromVersion="1.2.0")
+    @TypedColumn(name = "src_mac", method = MethodType.SETDATA, fromVersion = "1.2.0")
     void setSrcMac(String srcMac);
 
-    @TypedColumn(name="locator", method=MethodType.GETCOLUMN, fromVersion="1.2.0")
+    @TypedColumn(name = "locator", method = MethodType.GETCOLUMN, fromVersion = "1.2.0")
     Column<GenericTableSchema, UUID> getLocatorColumn();
 
-    @TypedColumn(name="locator", method=MethodType.SETDATA, fromVersion="1.2.0")
+    @TypedColumn(name = "locator", method = MethodType.SETDATA, fromVersion = "1.2.0")
     void setLocator(UUID locator);
 }
index b3f028f312705b04f275c2c676e9e1b9b83ad8d5..17bd043310e1c12a739edb3945e44c1146ce9ecb 100644 (file)
@@ -19,25 +19,25 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedBaseTable;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
-@TypedTable(name="Global", database="hardware_vtep", fromVersion="1.0.0")
+@TypedTable(name = "Global", database = "hardware_vtep", fromVersion = "1.0.0")
 public interface Global extends TypedBaseTable<GenericTableSchema> {
 
-    @TypedColumn(name="managers", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "managers", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getManagersColumn();
 
-    @TypedColumn(name="managers", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "managers", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setManagers(Set<UUID> managers);
 
-    @TypedColumn(name="switches", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "switches", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getSwitchesColumn();
 
-    @TypedColumn(name="switches", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "switches", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setSwitches(Set<UUID> switches);
 
 
-    @TypedColumn(name="other_config", method=MethodType.GETCOLUMN, fromVersion="1.7.0")
+    @TypedColumn(name = "other_config", method = MethodType.GETCOLUMN, fromVersion = "1.7.0")
     Column<GenericTableSchema, Map<String, String>> getOtherConfigColumn();
 
-    @TypedColumn(name="other_config", method=MethodType.SETDATA, fromVersion="1.7.0")
+    @TypedColumn(name = "other_config", method = MethodType.SETDATA, fromVersion = "1.7.0")
     void setOtherConfig(Map<String, String> otherConfig);
 }
index 28ad9baeece4609618a36fa47243e649194300f8..fa5fa208fe5b64a05f68a1adb11d319797b8007d 100644 (file)
@@ -18,24 +18,27 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
 /**
- * This class is a typed interface to the AutoAttach Table
+ * This class is a typed interface to the AutoAttach Table.
  */
-@TypedTable(name="AutoAttach", database="Open_vSwitch", fromVersion="7.11.2")
+@TypedTable(name = "AutoAttach", database = "Open_vSwitch", fromVersion = "7.11.2")
 public interface AutoAttach extends TypedBaseTable<GenericTableSchema> {
 
-    @TypedColumn(name="system_name", method=MethodType.GETCOLUMN, fromVersion="7.11.2")
+    @TypedColumn(name = "system_name", method = MethodType.GETCOLUMN, fromVersion = "7.11.2")
     Column<GenericTableSchema, String> getSystemNameColumn();
-    @TypedColumn(name="system_name", method=MethodType.SETDATA, fromVersion="7.11.2")
+
+    @TypedColumn(name = "system_name", method = MethodType.SETDATA, fromVersion = "7.11.2")
     void setSystemName(String systemName);
 
-    @TypedColumn(name="system_description", method=MethodType.GETCOLUMN, fromVersion="7.11.2")
+    @TypedColumn(name = "system_description", method = MethodType.GETCOLUMN, fromVersion = "7.11.2")
     Column<GenericTableSchema, String> getSystemDescriptionColumn();
-    @TypedColumn(name="system_description", method=MethodType.SETDATA, fromVersion="7.11.2")
+
+    @TypedColumn(name = "system_description", method = MethodType.SETDATA, fromVersion = "7.11.2")
     void setSystemDescription(String systemDescription);
 
-    @TypedColumn(name="mappings", method=MethodType.GETCOLUMN, fromVersion="7.11.2")
+    @TypedColumn(name = "mappings", method = MethodType.GETCOLUMN, fromVersion = "7.11.2")
     Column<GenericTableSchema, Map<Long, Long>> getMappingsColumn();
-    @TypedColumn(name="mappings", method=MethodType.SETDATA, fromVersion="7.11.2")
+
+    @TypedColumn(name = "mappings", method = MethodType.SETDATA, fromVersion = "7.11.2")
     void setMappings(Map<Long, Long> mappings);
 
     // FIXME: To be uncommented when Open vSwitch supports external_ids column
index d7f74f3d27c016450f7d0515b7cba47574ffeaf8..72ac4a4f9308be78c9c102fa2f83a178cfeabb08 100644 (file)
@@ -7,6 +7,7 @@
  */
 
 package org.opendaylight.ovsdb.schema.openvswitch;
+
 import java.util.Map;
 import java.util.Set;
 
@@ -19,119 +20,119 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
 /**
- * This class is a typed interface to the Bridge Table
+ * This class is a typed interface to the Bridge Table.
  */
-@TypedTable(name="Bridge", database="Open_vSwitch", fromVersion="1.0.0")
+@TypedTable(name = "Bridge", database = "Open_vSwitch", fromVersion = "1.0.0")
 public interface Bridge extends TypedBaseTable<GenericTableSchema> {
 
-    @TypedColumn(name="name", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "name", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, String> getNameColumn();
 
-    @TypedColumn(name="name", method=MethodType.GETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "name", method = MethodType.GETDATA, fromVersion = "1.0.0")
     String getName();
 
-    @TypedColumn(name="name", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "name", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setName(String name);
 
-    @TypedColumn(name="datapath_type", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "datapath_type", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, String> getDatapathTypeColumn();
 
-    @TypedColumn(name="datapath_type", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "datapath_type", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setDatapathType(String datapathType);
 
-    @TypedColumn(name="datapath_id", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "datapath_id", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<String>> getDatapathIdColumn();
 
-    @TypedColumn(name="datapath_id", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "datapath_id", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setDatapathId(Set<String> datapathId);
 
-    @TypedColumn(name="stp_enable", method=MethodType.GETCOLUMN, fromVersion="6.2.0")
+    @TypedColumn(name = "stp_enable", method = MethodType.GETCOLUMN, fromVersion = "6.2.0")
     Column<GenericTableSchema, Boolean> getStpEnableColumn();
 
-    @TypedColumn(name="stp_enable", method=MethodType.SETDATA, fromVersion="6.2.0")
-    void setStpEnable(Boolean stp_enable);
+    @TypedColumn(name = "stp_enable", method = MethodType.SETDATA, fromVersion = "6.2.0")
+    void setStpEnable(Boolean stpEnable);
 
-    @TypedColumn(name="ports", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "ports", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getPortsColumn();
 
-    @TypedColumn(name="ports", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "ports", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setPorts(Set<UUID> ports);
 
-    @TypedColumn(name="mirrors", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "mirrors", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getMirrorsColumn();
 
-    @TypedColumn(name="mirrors", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "mirrors", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setMirrors(Set<UUID> mirrors);
 
-    @TypedColumn(name="netflow", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "netflow", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getNetflowColumn();
 
-    @TypedColumn(name="netflow", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "netflow", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setNetflow(Set<UUID> netflow);
 
-    @TypedColumn(name="sflow", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "sflow", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getSflowColumn();
 
-    @TypedColumn(name="sflow", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "sflow", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setSflow(Set<UUID> sflow);
 
-    @TypedColumn(name="ipfix", method=MethodType.GETCOLUMN, fromVersion="7.1.0")
+    @TypedColumn(name = "ipfix", method = MethodType.GETCOLUMN, fromVersion = "7.1.0")
     Column<GenericTableSchema, Set<UUID>> getIpfixColumn();
 
-    @TypedColumn(name="ipfix", method=MethodType.SETDATA, fromVersion="7.1.0")
+    @TypedColumn(name = "ipfix", method = MethodType.SETDATA, fromVersion = "7.1.0")
     void setIpfix(Set<UUID> ipfix);
 
-    @TypedColumn(name="controller", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "controller", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<UUID>> getControllerColumn();
 
-    @TypedColumn(name="controller", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "controller", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setController(Set<UUID> controller);
 
-    @TypedColumn(name="protocols", method=MethodType.GETCOLUMN, fromVersion="6.11.1")
+    @TypedColumn(name = "protocols", method = MethodType.GETCOLUMN, fromVersion = "6.11.1")
     Column<GenericTableSchema, Set<String>> getProtocolsColumn();
 
-    @TypedColumn(name="protocols", method=MethodType.SETDATA, fromVersion="6.11.1")
+    @TypedColumn(name = "protocols", method = MethodType.SETDATA, fromVersion = "6.11.1")
     void setProtocols(Set<String> protocols);
 
-    @TypedColumn(name="fail_mode", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "fail_mode", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<String>> getFailModeColumn();
 
-    @TypedColumn(name="fail_mode", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "fail_mode", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setFailMode(Set<String> failMode);
 
-    @TypedColumn(name="status", method=MethodType.GETCOLUMN, fromVersion="6.2.0")
+    @TypedColumn(name = "status", method = MethodType.GETCOLUMN, fromVersion = "6.2.0")
     Column<GenericTableSchema, Map<String, String>> getStatusColumn();
 
-    @TypedColumn(name="status", method=MethodType.SETDATA, fromVersion="6.2.0")
+    @TypedColumn(name = "status", method = MethodType.SETDATA, fromVersion = "6.2.0")
     void setStatus(Map<String, String> status);
 
-    @TypedColumn(name="other_config", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "other_config", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Map<String, String>> getOtherConfigColumn();
 
-    @TypedColumn(name="other_config", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "other_config", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setOtherConfig(Map<String, String> otherConfig);
 
-    @TypedColumn(name="external_ids", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "external_ids", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Map<String, String>> getExternalIdsColumn();
 
-    @TypedColumn(name="external_ids", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "external_ids", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setExternalIds(Map<String, String> externalIds);
 
-    @TypedColumn(name="flood_vlans", method=MethodType.GETCOLUMN, fromVersion="1.0.0")
+    @TypedColumn(name = "flood_vlans", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<Long>> getFloodVlansColumn();
 
-    @TypedColumn(name="flood_vlans", method=MethodType.SETDATA, fromVersion="1.0.0")
+    @TypedColumn(name = "flood_vlans", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setFloodVlans(Set<Long> vlans);
 
-    @TypedColumn(name="flow_tables", method=MethodType.GETCOLUMN, fromVersion="6.5.0")
+    @TypedColumn(name = "flow_tables", method = MethodType.GETCOLUMN, fromVersion = "6.5.0")
     Column<GenericTableSchema, Map<Long, UUID>> getFlowTablesColumn();
 
-    @TypedColumn(name="flow_tables", method=MethodType.SETDATA, fromVersion="6.5.0")
+    @TypedColumn(name = "flow_tables", method = MethodType.SETDATA, fromVersion = "6.5.0")
     void setFlowTables(Map<Long, UUID> flowTables);
 
-    @TypedColumn(name="auto_attach", method=MethodType.GETCOLUMN, fromVersion="7.11.2")
+    @TypedColumn(name = "auto_attach", method = MethodType.GETCOLUMN, fromVersion = "7.11.2")
     Column<GenericTableSchema, Set<UUID>> getAutoAttachColumn();
 
-    @TypedColumn(name="auto_attach", method=MethodType.SETDATA, fromVersion="7.11.2")
+    @TypedColumn(name = "auto_attach", method = MethodType.SETDATA, fromVersion = "7.11.2")
     void setAutoAttach(Set<UUID> autoAttach);
 }
index ef1c4e68565d626dc8fe1e512b41b480f05801fc..30d1cc62243398330f8e7755a7da9fbb81314817 100644 (file)
@@ -21,11 +21,11 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
  * Reusing the existing Table definitions and many of columns are not defined here
  * TODO : Fill up the missing Columns and include Supported DB Version
  */
-@TypedTable(name="Capability", database="Open_vSwitch")
+@TypedTable(name = "Capability", database = "Open_vSwitch")
 public interface Capability extends TypedBaseTable<GenericTableSchema> {
-    @TypedColumn(name="details", method=MethodType.GETCOLUMN)
+    @TypedColumn(name = "details", method = MethodType.GETCOLUMN)
     Column<GenericTableSchema, Map<String, String>> getDetailsColumn();
 
-    @TypedColumn(name="details", method=MethodType.SETDATA)
+    @TypedColumn(name = "details", method = MethodType.SETDATA)
     void setDetails(Map<String, String> details);
 }
index bce5d75a04eab476108dfe361d1ffb1c9e2da55d..f5af220bd79c1a858e2c45d99cbe40d53648219c 100644 (file)
@@ -8,6 +8,8 @@
 
 package org.opendaylight.ovsdb.schema.openvswitch;
 
+import java.util.Map;
+import java.util.Set;
 import org.opendaylight.ovsdb.lib.notation.Column;
 import org.opendaylight.ovsdb.lib.schema.GenericTableSchema;
 import org.opendaylight.ovsdb.lib.schema.typed.MethodType;
@@ -15,119 +17,116 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedBaseTable;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedColumn;
 import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 
-import java.util.Map;
-import java.util.Set;
-
 /**
- * This class is a typed interface to the Controller Table
+ * This class is a typed interface to the Controller Table.
  */
 
-@TypedTable (name="Controller", database="Open_vSwitch", fromVersion="1.0.0")
+@TypedTable(name = "Controller", database = "Open_vSwitch", fromVersion = "1.0.0")
 public interface Controller extends TypedBaseTable<GenericTableSchema> {
 
-    @TypedColumn (name = "target", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "target", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, String> getTargetColumn();
 
-    @TypedColumn (name = "target", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "target", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setTarget(String target);
 
-    @TypedColumn (name = "controller_burst_limit", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "controller_burst_limit", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Long> getBurstLimitColumn();
 
-    @TypedColumn (name = "controller_burst_limit", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "controller_burst_limit", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setBurstLimit(Long burstLimit);
 
-    @TypedColumn (name = "controller_rate_limit", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "controller_rate_limit", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Long> getRateLimitColumn();
 
-    @TypedColumn (name = "controller_rate_limit", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "controller_rate_limit", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setRateLimit(Long rateLimit);
 
-    @TypedColumn (name = "connection_mode", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "connection_mode", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<String>> getConnectionModeColumn();
 
-    @TypedColumn (name = "connection_mode", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "connection_mode", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setConnectionMode(Set<String> connectionMode);
 
-    @TypedColumn (name = "enable_async_messages", method = MethodType.GETCOLUMN, fromVersion = "6.7.0")
+    @TypedColumn(name = "enable_async_messages", method = MethodType.GETCOLUMN, fromVersion = "6.7.0")
     Column<GenericTableSchema, Set<Boolean>> getEnableAsyncMessagesColumn();
 
-    @TypedColumn (name = "enable_async_messages", method = MethodType.SETDATA, fromVersion = "6.7.0")
+    @TypedColumn(name = "enable_async_messages", method = MethodType.SETDATA, fromVersion = "6.7.0")
     void setEnableAsyncMessages(Set<Boolean> enableAsyncMessages);
 
-    @TypedColumn (name = "external_ids", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "external_ids", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Map<String, String>> getExternalIdsColumn();
 
-    @TypedColumn (name = "external_ids", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "external_ids", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setExternalIds(Map<String, String> externalIds);
 
-    @TypedColumn (name = "local_netmask", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "local_netmask", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<String>> getLocalNetmaskColumn();
 
-    @TypedColumn (name = "local_netmask", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "local_netmask", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setLocalNetmask(Set<String> localNetmask);
 
-    @TypedColumn (name = "local_gateway", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "local_gateway", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<String>> getLocalGatewayColumn();
 
-    @TypedColumn (name = "local_gateway", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "local_gateway", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setLocalGateway(Set<String> localGateway);
 
-    @TypedColumn (name = "status", method = MethodType.GETCOLUMN, fromVersion = "1.1.0")
+    @TypedColumn(name = "status", method = MethodType.GETCOLUMN, fromVersion = "1.1.0")
     Column<GenericTableSchema, Map<String, String>> getStatusColumn();
 
-    @TypedColumn (name = "status", method = MethodType.SETDATA, fromVersion = "1.1.0")
+    @TypedColumn(name = "status", method = MethodType.SETDATA, fromVersion = "1.1.0")
     void setStatus(Map<String, String> status);
 
-    @TypedColumn (name = "role", method = MethodType.GETCOLUMN, fromVersion = "1.1.0")
+    @TypedColumn(name = "role", method = MethodType.GETCOLUMN, fromVersion = "1.1.0")
     Column<GenericTableSchema, Set<String>> getRoleColumn();
 
-    @TypedColumn (name = "role", method = MethodType.SETDATA, fromVersion = "1.1.0")
+    @TypedColumn(name = "role", method = MethodType.SETDATA, fromVersion = "1.1.0")
     void setRole(Set<String> role);
 
-    @TypedColumn (name = "inactivity_probe", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "inactivity_probe", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<Long>> getInactivityProbeColumn();
 
-    @TypedColumn (name = "inactivity_probe", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "inactivity_probe", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setInactivityProbe(Set<Long> inactivityProbe);
 
-    @TypedColumn (name = "is_connected", method = MethodType.GETCOLUMN, fromVersion = "1.1.0")
+    @TypedColumn(name = "is_connected", method = MethodType.GETCOLUMN, fromVersion = "1.1.0")
     Column<GenericTableSchema, Boolean> getIsConnectedColumn();
 
-    @TypedColumn (name = "is_connected", method = MethodType.SETDATA, fromVersion = "1.1.0")
+    @TypedColumn(name = "is_connected", method = MethodType.SETDATA, fromVersion = "1.1.0")
     void setIsConnected(Boolean isConnected);
 
-    @TypedColumn (name = "other_config", method = MethodType.GETCOLUMN, fromVersion = "6.8.0")
+    @TypedColumn(name = "other_config", method = MethodType.GETCOLUMN, fromVersion = "6.8.0")
     Column<GenericTableSchema, Map<String, String>> getOtherConfigColumn();
 
-    @TypedColumn (name = "other_config", method = MethodType.SETDATA, fromVersion = "6.8.0")
+    @TypedColumn(name = "other_config", method = MethodType.SETDATA, fromVersion = "6.8.0")
     void setOtherConfig(Map<String, String> otherConfig);
 
-    @TypedColumn (name = "max_backoff", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "max_backoff", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<Long>> getMaxBackoffColumn();
 
-    @TypedColumn (name = "max_backoff", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "max_backoff", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setMaxBackoff(Set<Long> maxBackoff);
 
-    @TypedColumn (name = "local_ip", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
+    @TypedColumn(name = "local_ip", method = MethodType.GETCOLUMN, fromVersion = "1.0.0")
     Column<GenericTableSchema, Set<String>> getLocalIpColumn();
 
-    @TypedColumn (name = "local_ip", method = MethodType.SETDATA, fromVersion = "1.0.0")
+    @TypedColumn(name = "local_ip", method = MethodType.SETDATA, fromVersion = "1.0.0")
     void setLocalIp(Set<String> localIp);
 
-    @TypedColumn (name = "discover_update_resolv_conf", method = MethodType.GETCOLUMN,
-                  fromVersion="1.0.0", untilVersion="3.0.0")
+    @TypedColumn(name = "discover_update_resolv_conf", method = MethodType.GETCOLUMN,
+            fromVersion = "1.0.0", untilVersion = "3.0.0")
     Column<GenericTableSchema, Set<String>> getDiscoverUpdateResolvConfColumn();
 
-    @TypedColumn (name = "discover_update_resolv_conf", method = MethodType.SETDATA,
-                  fromVersion="1.0.0", untilVersion="3.0.0")
+    @TypedColumn(name = "discover_update_resolv_conf", method = MethodType.SETDATA,
+            fromVersion = "1.0.0", untilVersion = "3.0.0")
     void setDiscoverUpdateResolvConf(Set<String> discoverUpdateResolvConf);
 
-    @TypedColumn (name = "discover_accept_regex", method = MethodType.GETCOLUMN,
-                  fromVersion="1.0.0", untilVersion="3.0.0")
+    @TypedColumn(name = "discover_accept_regex", method = MethodType.GETCOLUMN,
+            fromVersion = "1.0.0", untilVersion = "3.0.0")
     Column<GenericTableSchema, Set<String>> getDiscoverAcceptRegexColumn();
 
-    @TypedColumn (name = "discover_accept_regex", method = MethodType.SETDATA,
-                  fromVersion="1.0.0", untilVersion="3.0.0")
+    @TypedColumn(name = "discover_accept_regex", method = MethodType.SETDATA,
+            fromVersion = "1.0.0", untilVersion = "3.0.0")
     void setDiscoverAcceptRegex(Set<String> discoverAcceptRegex);
 }
index 6b28804d8a166181f07c15d3508db5f9f3aecc23..926267319a34f026173d939887ce533b254c7dba 100644 (file)
@@ -21,30 +21,30 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 /**
  * This class is a typed interface to the Flow_Sample_Collector_Set Table
  */
-@TypedTable(name="Flow_Sample_Collector_Set", database="Open_vSwitch", fromVersion="7.1.0")
+@TypedTable(name = "Flow_Sample_Collector_Set", database = "Open_vSwitch", fromVersion = "7.1.0")
 public interface FlowSampleCollectorSet extends TypedBaseTable<GenericTableSchema> {
 
-    @TypedColumn(name="id", method=MethodType.GETCOLUMN, fromVersion="7.1.0")
+    @TypedColumn(name = "id", method = MethodType.GETCOLUMN, fromVersion = "7.1.0")
     Column<GenericTableSchema, Long> getIdColumn();
 
-    @TypedColumn(name="id", method=MethodType.SETDATA, fromVersion="7.1.0")
+    @TypedColumn(name = "id", method = MethodType.SETDATA, fromVersion = "7.1.0")
     void setId(Long id);
 
-    @TypedColumn(name="bridge", method=MethodType.GETCOLUMN, fromVersion="7.1.0")
+    @TypedColumn(name = "bridge", method = MethodType.GETCOLUMN, fromVersion = "7.1.0")
     Column<GenericTableSchema, UUID> getBridgeColumn();
 
-    @TypedColumn(name="bridge", method=MethodType.SETDATA, fromVersion="7.1.0")
+    @TypedColumn(name = "bridge", method = MethodType.SETDATA, fromVersion = "7.1.0")
     void setBridge(UUID bridge);
 
-    @TypedColumn(name="ipfix", method=MethodType.GETCOLUMN, fromVersion="7.1.0")
+    @TypedColumn(name = "ipfix", method = MethodType.GETCOLUMN, fromVersion = "7.1.0")
     Column<GenericTableSchema, UUID> getIpfixColumn();
 
-    @TypedColumn(name="ipfix", method=MethodType.SETDATA, fromVersion="7.1.0")
+    @TypedColumn(name = "ipfix", method = MethodType.SETDATA, fromVersion = "7.1.0")
     void setIpfix(UUID ipfix);
 
-    @TypedColumn(name="external_ids", method=MethodType.GETCOLUMN, fromVersion="7.1.0")
+    @TypedColumn(name = "external_ids", method = MethodType.GETCOLUMN, fromVersion = "7.1.0")
     Column<GenericTableSchema, Map<String, String>> getExternalIdsColumn();
 
-    @TypedColumn(name="external_ids", method=MethodType.SETDATA, fromVersion="7.1.0")
+    @TypedColumn(name = "external_ids", method = MethodType.SETDATA, fromVersion = "7.1.0")
     void setExternalIds(Map<String, String> externalIds);
 }
index 3219d0152237a36c031f877956fb298d1ec3ed4d..09b74ce8b6f3f64393af3c0ee27523297351deb7 100644 (file)
@@ -21,43 +21,43 @@ import org.opendaylight.ovsdb.lib.schema.typed.TypedTable;
 /**
  * This class is a typed interface to the Flow_Table Table
  */
-@TypedTable(name="Flow_Table", database="Open_vSwitch", fromVersion="6.5.0")
+@TypedTable(name = "Flow_Table", database = "Open_vSwitch", fromVersion = "6.5.0")
 public interface FlowTable extends TypedBaseTable<GenericTableSchema> {
 
-    @TypedColumn(name="flow_limit", method=MethodType.GETCOLUMN, fromVersion="6.5.0")
-    Column<GenericTableSchema, Set<Long>> getFlowLimitColumn() ;
+    @TypedColumn(name = "flow_limit", method = MethodType.GETCOLUMN, fromVersion = "6.5.0")
+    Column<GenericTableSchema, Set<Long>> getFlowLimitColumn();
 
-    @TypedColumn(name="flow_limit", method=MethodType.SETDATA, fromVersion="6.5.0")
-    void setFlowLimit(Set<Long> flowLimit) ;
+    @TypedColumn(name = "flow_limit", method = MethodType.SETDATA, fromVersion = "6.5.0")
+    void setFlowLimit(Set<Long> flowLimit);
 
-    @TypedColumn(name="overflow_policy", method=MethodType.GETCOLUMN, fromVersion="6.5.0")
-    Column<GenericTableSchema, Set<String>> getOverflowPolicyColumn() ;
+    @TypedColumn(name = "overflow_policy", method = MethodType.GETCOLUMN, fromVersion = "6.5.0")
+    Column<GenericTableSchema, Set<String>> getOverflowPolicyColumn();
 
-    @TypedColumn(name="overflow_policy", method=MethodType.SETDATA, fromVersion="6.5.0")
-    void setOverflowPolicy(Set<String> overflowPolicy) ;
+    @TypedColumn(name = "overflow_policy", method = MethodType.SETDATA, fromVersion = "6.5.0")
+    void setOverflowPolicy(Set<String> overflowPolicy);
 
-    @TypedColumn(name="groups", method=MethodType.GETCOLUMN, fromVersion="6.5.0")
-    Column<GenericTableSchema, Set<String>> getGroupsColumn() ;
+    @TypedColumn(name = "groups", method = MethodType.GETCOLUMN, fromVersion = "6.5.0")
+    Column<GenericTableSchema, Set<String>> getGroupsColumn();
 
-    @TypedColumn(name="groups", method=MethodType.SETDATA, fromVersion="6.5.0")
-    void setGroups(Set<String> groups) ;
+    @TypedColumn(name = "groups", method = MethodType.SETDATA, fromVersion = "6.5.0")
+    void setGroups(Set<String> groups);
 
-    @TypedColumn(name="name", method=MethodType.GETCOLUMN, fromVersion="6.5.0")
+    @TypedColumn(name = "name", method = MethodType.GETCOLUMN, fromVersion = "6.5.0")
     Column<GenericTableSchema, Set<String>> getNameColumn();
 
-    @TypedColumn(name="name", method=MethodType.SETDATA, fromVersion="6.5.0")
+    @TypedColumn(name = "name", method = MethodType.SETDATA, fromVersion = "6.5.0")
     void setName(Set<String> name);
 
-    @TypedColumn(name="prefixes", method=MethodType.GETCOLUMN, fromVersion="7.4.0")
+    @TypedColumn(name = "prefixes", method = MethodType.GETCOLUMN, fromVersion = "7.4.0")
     Column<GenericTableSchema, Set<String>> getPrefixesColumn();
 
-    @TypedColumn(name="prefixes", method=MethodType.SETDATA, fromVersion="7.4.0")
+    @TypedColumn(name = "prefixes", method = MethodType.SETDATA, fromVersion = "7.4.0")
     void setPrefixes(Set<String> prefixes);
 
-    @TypedColumn(name="external_ids", method=MethodType.GETCOLUMN, fromVersion="7.5.0")
+    @TypedColumn(name = "external_ids", method = MethodType.GETCOLUMN, fromVersion = "7.5.0")
     Column<GenericTableSchema, Map<String, String>> getExternalIdsColumn();
 
-    @TypedColumn(name="external_ids", method=MethodType.SETDATA, fromVersion="7.5.0")
+    @TypedColumn(name = "external_ids", method = MethodType.SETDATA, fromVersion = "7.5.0")
     void setExternalIds(Map<String, String> externalIds);
 
 }
index 8ef7684ab4d288462ca474d65968ba678c6b12ef..4d0672a3d9f21c8518d3b3061da4eb771f4bfe1e 100644 (file)
@@ -7,14 +7,12 @@
  */
 package org.opendaylight.ovsdb.southbound;
 
-public class OvsdbSchemaContants {
+public interface OvsdbSchemaContants {
 
-    public static final String DATABASE_NAME = "Open_vSwitch";
-    private static final String BRIDGE_NAME = "Bridge";
+    String DATABASE_NAME = "Open_vSwitch";
+    String BRIDGE_NAME = "Bridge";
 
-    private OvsdbSchemaContants() { }
-
-    public enum OvsdbSchemaTables {
+    enum OvsdbSchemaTables {
         OPENVSWITCH(DATABASE_NAME,null,null),
         BRIDGE(BRIDGE_NAME, DATABASE_NAME, "bridges"),
         PORT("Port", BRIDGE_NAME, "ports"),
index f1b1f9689880f4b2af0e74aee1fb75864573d947..1b7a03c44c100076277eae93ffcb658d242a897b 100755 (executable)
@@ -58,35 +58,33 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.re
 import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.QosTypeLinuxSfq;
 import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.TopologyId;
 
-public class SouthboundConstants {
-
-    private SouthboundConstants() { }
-
-    public static final String OPEN_V_SWITCH = "Open_vSwitch";
-    public static final TopologyId OVSDB_TOPOLOGY_ID = new TopologyId(new Uri("ovsdb:1"));
-    public static final String OVSDB_URI_PREFIX = "ovsdb";
-    public static final String BRIDGE_URI_PREFIX = "bridge";
-    public static final String TP_URI_PREFIX = "terminationpoint";
-    public static final String QOS_URI_PREFIX = "qos";
-    public static final String QOS_NAMED_UUID_PREFIX = "QOS";
-    public static final Integer PORT_QOS_LIST_KEY = 1;
-    public static final String QUEUE_URI_PREFIX = "queue";
-    public static final String QUEUE_NAMED_UUID_PREFIX = "QUEUE";
-    public static final String AUTOATTACH_URI_PREFIX = "autoattach";
-    public static final String AUTOATTACH_SUPPORTED_OVS_SCHEMA_VERSION = "7.11.2";
-    public static final Integer DEFAULT_OVSDB_PORT = 6640;
-    public static final String DEFAULT_OPENFLOW_PORT = "6653";
-    public static final String OPENFLOW_CONNECTION_PROTOCOL = "tcp";
-    public static final String UUID = "uuid";
-    public static final String QOS_LINUX_HTB = "linux-htb";
-    public static final String QOS_LINUX_HFSC = "linux-hfsc";
+public interface SouthboundConstants {
+
+    String OPEN_V_SWITCH = "Open_vSwitch";
+    TopologyId OVSDB_TOPOLOGY_ID = new TopologyId(new Uri("ovsdb:1"));
+    String OVSDB_URI_PREFIX = "ovsdb";
+    String BRIDGE_URI_PREFIX = "bridge";
+    String TP_URI_PREFIX = "terminationpoint";
+    String QOS_URI_PREFIX = "qos";
+    String QOS_NAMED_UUID_PREFIX = "QOS";
+    Integer PORT_QOS_LIST_KEY = 1;
+    String QUEUE_URI_PREFIX = "queue";
+    String QUEUE_NAMED_UUID_PREFIX = "QUEUE";
+    String AUTOATTACH_URI_PREFIX = "autoattach";
+    String AUTOATTACH_SUPPORTED_OVS_SCHEMA_VERSION = "7.11.2";
+    Integer DEFAULT_OVSDB_PORT = 6640;
+    String DEFAULT_OPENFLOW_PORT = "6653";
+    String OPENFLOW_CONNECTION_PROTOCOL = "tcp";
+    String UUID = "uuid";
+    String QOS_LINUX_HTB = "linux-htb";
+    String QOS_LINUX_HFSC = "linux-hfsc";
     // The following four QoS types are present in OVS 2.5+
     // Refer to http://openvswitch.org/support/dist-docs/ovs-vswitchd.conf.db.5.txt
-    public static final String QOS_LINUX_SFQ = "linux-sfq";
-    public static final String QOS_LINUX_CODEL = "linux-codel";
-    public static final String QOS_LINUX_FQ_CODEL = "linux-fq_codel";
-    public static final String QOS_EGRESS_POLICER = "egress-policer";
-    public static final ImmutableBiMap<Class<? extends QosTypeBase>,String> QOS_TYPE_MAP
+    String QOS_LINUX_SFQ = "linux-sfq";
+    String QOS_LINUX_CODEL = "linux-codel";
+    String QOS_LINUX_FQ_CODEL = "linux-fq_codel";
+    String QOS_EGRESS_POLICER = "egress-policer";
+    ImmutableBiMap<Class<? extends QosTypeBase>,String> QOS_TYPE_MAP
         = new ImmutableBiMap.Builder<Class<? extends QosTypeBase>,String>()
             .put(QosTypeLinuxHtb.class,QOS_LINUX_HTB)
             .put(QosTypeLinuxHfsc.class,QOS_LINUX_HFSC)
@@ -96,7 +94,7 @@ public class SouthboundConstants {
             .put(QosTypeEgressPolicer.class,QOS_EGRESS_POLICER)
             .build();
 
-    public static final ImmutableBiMap<Class<? extends OvsdbBridgeProtocolBase>,String> OVSDB_PROTOCOL_MAP
+    ImmutableBiMap<Class<? extends OvsdbBridgeProtocolBase>,String> OVSDB_PROTOCOL_MAP
         = new ImmutableBiMap.Builder<Class<? extends OvsdbBridgeProtocolBase>,String>()
             .put(OvsdbBridgeProtocolOpenflow10.class,"OpenFlow10")
             .put(OvsdbBridgeProtocolOpenflow11.class,"OpenFlow11")
@@ -106,13 +104,13 @@ public class SouthboundConstants {
             .put(OvsdbBridgeProtocolOpenflow15.class,"OpenFlow15")
             .build();
 
-    public static final ImmutableBiMap<Class<? extends OvsdbFailModeBase>,String> OVSDB_FAIL_MODE_MAP
+    ImmutableBiMap<Class<? extends OvsdbFailModeBase>,String> OVSDB_FAIL_MODE_MAP
         = new ImmutableBiMap.Builder<Class<? extends OvsdbFailModeBase>,String>()
             .put(OvsdbFailModeStandalone.class,"standalone")
             .put(OvsdbFailModeSecure.class,"secure")
             .build();
 
-    public static final ImmutableBiMap<String, Class<? extends InterfaceTypeBase>> OVSDB_INTERFACE_TYPE_MAP
+    ImmutableBiMap<String, Class<? extends InterfaceTypeBase>> OVSDB_INTERFACE_TYPE_MAP
         = new ImmutableBiMap.Builder<String, Class<? extends InterfaceTypeBase>>()
             .put("internal", InterfaceTypeInternal.class)
             .put("vxlan", InterfaceTypeVxlan.class)
@@ -134,18 +132,18 @@ public class SouthboundConstants {
             .put("stt", InterfaceTypeStt.class)
             .build();
 
-    public static final ImmutableBiMap<Class<? extends DatapathTypeBase>,String> DATAPATH_TYPE_MAP
+    ImmutableBiMap<Class<? extends DatapathTypeBase>,String> DATAPATH_TYPE_MAP
         = new ImmutableBiMap.Builder<Class<? extends DatapathTypeBase>,String>()
             .put(DatapathTypeSystem.class,"system")
             .put(DatapathTypeNetdev.class,"netdev")
             .build();
 
-    public static final String IID_EXTERNAL_ID_KEY = "opendaylight-iid";
-    public static final String QOS_ID_EXTERNAL_ID_KEY = "opendaylight-qos-id";
-    public static final String QUEUE_ID_EXTERNAL_ID_KEY = "opendaylight-queue-id";
-    public static final String AUTOATTACH_ID_EXTERNAL_ID_KEY = "opendaylight-autoattach-id";
+    String IID_EXTERNAL_ID_KEY = "opendaylight-iid";
+    String QOS_ID_EXTERNAL_ID_KEY = "opendaylight-qos-id";
+    String QUEUE_ID_EXTERNAL_ID_KEY = "opendaylight-queue-id";
+    String AUTOATTACH_ID_EXTERNAL_ID_KEY = "opendaylight-autoattach-id";
 
-    static final ImmutableCollection<String> SKIP_OVSDB_TABLE = new ImmutableSet.Builder<String>()
+    ImmutableCollection<String> SKIP_OVSDB_TABLE = new ImmutableSet.Builder<String>()
             .add("Flow_Table")
             .add("Mirror")
             .add("NetFlow")
@@ -157,7 +155,7 @@ public class SouthboundConstants {
     //Note: _version is an internal column of ovsdb schema, that gets updated
     //with every change in the row of the table.
     // The "Manager" entry needs to be a modifiable list, SouthboundProvider::setSkipManagerStatus() modifies it
-    static final ImmutableMap<String,List<String>> SKIP_COLUMN_FROM_TABLE
+    ImmutableMap<String,List<String>> SKIP_COLUMN_FROM_TABLE
             = new ImmutableMap.Builder<String,List<String>>()
             .put("Open_vSwitch", Arrays.asList("statistics","_version"))
             .put("Port", Arrays.asList("statistics","_version"))
@@ -170,7 +168,7 @@ public class SouthboundConstants {
             .put("Controller", Arrays.asList("status","_version"))
             .build();
 
-    public enum VlanModes {
+    enum VlanModes {
         ACCESS("access"),
         NATIVE_TAGGED("native-tagged"),
         NATIVE_UNTAGGED("native-untagged"),
@@ -192,7 +190,7 @@ public class SouthboundConstants {
         }
     }
 
-    public enum OwnershipStates {
+    enum OwnershipStates {
         OWNER("OWNER"),
         NONOWNER("NON-OWNER");
 
index 27fa966d996473b98df1e8b80a4c44d07cce8e9d..4c56e6f408689881855af874aeff6eb41008559b 100644 (file)
@@ -69,7 +69,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class SouthboundMapper {
+public final class SouthboundMapper {
 
     private SouthboundMapper() { }
 
index 63bf657b4ed67d2e6aa246af21f2d036ff798d83..b3f659decf43289ce159ee69f656fc1e37aa6655 100644 (file)
@@ -31,7 +31,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class SouthboundUtil {
+public final class SouthboundUtil {
 
     private static final Logger LOG = LoggerFactory.getLogger(SouthboundUtil.class);
     private static final String SCHEMA_VERSION_MISMATCH =
index eb425d2010585fa1dc62705871a649294a3d06c8..1b7a5893db11b9016cd7e024fc9350e91f150a69 100644 (file)
@@ -49,6 +49,8 @@ import org.opendaylight.yangtools.yang.binding.Identifier;
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier;
 
+// This class needs to be mocked
+@SuppressWarnings("checkstyle:FinalClass")
 public class TransactUtils {
 
     private TransactUtils() { }
index 5f5783650d89c18d34d3d8f7ae108d8099b33c73..5905a061a33a8f0d4308a3e961531a6fbd191645 100644 (file)
@@ -75,7 +75,7 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
 
         for (Entry<UUID, OpenVSwitch> entry : updatedOpenVSwitchRows.entrySet()) {
             OpenVSwitch openVSwitch = entry.getValue();
-            final InstanceIdentifier<Node> nodePath = getInstanceIdentifier(instanceIdentifierCodec, openVSwitch);
+            final InstanceIdentifier<Node> nodePath = getInstanceIdentifier(openVSwitch);
 
             OvsdbNodeAugmentationBuilder ovsdbNodeBuilder = new OvsdbNodeAugmentationBuilder();
 
@@ -84,12 +84,12 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
             setDataPathTypes(ovsdbNodeBuilder, openVSwitch);
             setInterfaceTypes(ovsdbNodeBuilder, openVSwitch);
             OpenVSwitch oldEntry = deletedOpenVSwitchRows.get(entry.getKey());
-            setExternalIds(instanceIdentifierCodec, transaction, ovsdbNodeBuilder, oldEntry, openVSwitch);
-            setOtherConfig(instanceIdentifierCodec, transaction, ovsdbNodeBuilder, oldEntry, openVSwitch);
+            setExternalIds(transaction, ovsdbNodeBuilder, oldEntry, openVSwitch);
+            setOtherConfig(transaction, ovsdbNodeBuilder, oldEntry, openVSwitch);
             ovsdbNodeBuilder.setConnectionInfo(getConnectionInfo());
 
             NodeBuilder nodeBuilder = new NodeBuilder();
-            nodeBuilder.setNodeId(getNodeId(instanceIdentifierCodec, openVSwitch));
+            nodeBuilder.setNodeId(getNodeId(openVSwitch));
             nodeBuilder.addAugmentation(OvsdbNodeAugmentation.class,
                     ovsdbNodeBuilder.build());
             transaction.merge(LogicalDatastoreType.OPERATIONAL, nodePath,
@@ -97,7 +97,7 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
         }
     }
 
-    private void setOtherConfig(InstanceIdentifierCodec instanceIdentifierCodec, ReadWriteTransaction transaction,
+    private void setOtherConfig(ReadWriteTransaction transaction,
             OvsdbNodeAugmentationBuilder ovsdbNodeBuilder, OpenVSwitch oldEntry, OpenVSwitch openVSwitch) {
         Map<String, String> oldOtherConfigs = null;
         Map<String, String> otherConfigs = null;
@@ -110,19 +110,19 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
         }
 
         if ((oldOtherConfigs != null) && (!oldOtherConfigs.isEmpty())) {
-            removeOldConfigs(instanceIdentifierCodec, transaction, oldOtherConfigs, openVSwitch);
+            removeOldConfigs(transaction, oldOtherConfigs, openVSwitch);
         }
         if ((otherConfigs != null) && (!otherConfigs.isEmpty())) {
             setNewOtherConfigs(ovsdbNodeBuilder, otherConfigs);
         }
     }
 
-    private void removeOldConfigs(InstanceIdentifierCodec instanceIdentifierCodec, ReadWriteTransaction transaction,
+    private void removeOldConfigs(ReadWriteTransaction transaction,
             Map<String, String> oldOtherConfigs, OpenVSwitch ovs) {
         InstanceIdentifier<OvsdbNodeAugmentation> nodeAugmentataionIid = InstanceIdentifier
                 .create(NetworkTopology.class)
                 .child(Topology.class, new TopologyKey(SouthboundConstants.OVSDB_TOPOLOGY_ID))
-                .child(Node.class, new NodeKey(getNodeId(instanceIdentifierCodec, ovs)))
+                .child(Node.class, new NodeKey(getNodeId(ovs)))
                 .augmentation(OvsdbNodeAugmentation.class);
         Set<String> otherConfigKeys = oldOtherConfigs.keySet();
         for (String otherConfigKey : otherConfigKeys) {
@@ -148,7 +148,7 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
         ovsdbNodeBuilder.setOpenvswitchOtherConfigs(otherConfigsList);
     }
 
-    private void setExternalIds(InstanceIdentifierCodec instanceIdentifierCodec, ReadWriteTransaction transaction,
+    private void setExternalIds(ReadWriteTransaction transaction,
             OvsdbNodeAugmentationBuilder ovsdbNodeBuilder, OpenVSwitch oldEntry, OpenVSwitch openVSwitch) {
         Map<String, String> oldExternalIds = null;
         Map<String, String> externalIds = null;
@@ -162,17 +162,17 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
         if ((oldExternalIds == null) || oldExternalIds.isEmpty()) {
             setNewExternalIds(ovsdbNodeBuilder, externalIds);
         } else if (externalIds != null && !externalIds.isEmpty()) {
-            removeExternalIds(instanceIdentifierCodec, transaction, oldExternalIds, openVSwitch);
+            removeExternalIds(transaction, oldExternalIds, openVSwitch);
             setNewExternalIds(ovsdbNodeBuilder, externalIds);
         }
     }
 
-    private void removeExternalIds(InstanceIdentifierCodec instanceIdentifierCodec, ReadWriteTransaction transaction,
+    private void removeExternalIds(ReadWriteTransaction transaction,
             Map<String, String> oldExternalIds, OpenVSwitch ovs) {
         InstanceIdentifier<OvsdbNodeAugmentation> nodeAugmentataionIid = InstanceIdentifier
                 .create(NetworkTopology.class)
                 .child(Topology.class, new TopologyKey(SouthboundConstants.OVSDB_TOPOLOGY_ID))
-                .child(Node.class, new NodeKey(getNodeId(instanceIdentifierCodec, ovs)))
+                .child(Node.class, new NodeKey(getNodeId(ovs)))
                 .augmentation(OvsdbNodeAugmentation.class);
         Set<String> externalIdKeys = oldExternalIds.keySet();
         for (String externalIdKey : externalIdKeys) {
@@ -261,8 +261,7 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
         }
     }
 
-    private InstanceIdentifier<Node> getInstanceIdentifier(InstanceIdentifierCodec instanceIdentifierCodec,
-            OpenVSwitch ovs) {
+    private InstanceIdentifier<Node> getInstanceIdentifier(OpenVSwitch ovs) {
         if (ovs.getExternalIdsColumn() != null
                 && ovs.getExternalIdsColumn().getData() != null
                 && ovs.getExternalIdsColumn().getData().containsKey(SouthboundConstants.IID_EXTERNAL_ID_KEY)) {
@@ -284,8 +283,8 @@ public class OpenVSwitchUpdateCommand extends AbstractTransactionCommand {
         return getOvsdbConnectionInstance().getInstanceIdentifier();
     }
 
-    private NodeId getNodeId(InstanceIdentifierCodec instanceIdentifierCodec, OpenVSwitch ovs) {
-        NodeKey nodeKey = getInstanceIdentifier(instanceIdentifierCodec, ovs).firstKeyOf(Node.class);
+    private NodeId getNodeId(OpenVSwitch ovs) {
+        NodeKey nodeKey = getInstanceIdentifier(ovs).firstKeyOf(Node.class);
         return nodeKey.getNodeId();
     }
 }
index 2f3519229b7176b75046b5475e17a86351b4a5f8..63c7b4d322df70778d93e8a3a206b0a80b3780ed 100644 (file)
@@ -108,8 +108,7 @@ public class OvsdbConnectionManagerTest {
         doNothing().when(client).registerCallbacks(any());
 
         //TODO: Write unit tests for EntityOwnershipService
-        InstanceIdentifier<Node> iid = mock(InstanceIdentifier.class);
-        when(client.getInstanceIdentifier()).thenReturn(iid);
+        when(client.getInstanceIdentifier()).thenReturn(mock(InstanceIdentifier.class));
         field(OvsdbConnectionManager.class, "entityConnectionMap").set(ovsdbConnManager, entityConnectionMap);
         suppress(MemberMatcher.method(OvsdbConnectionManager.class, "getEntityFromConnectionInstance",
                 OvsdbConnectionInstance.class));
@@ -136,8 +135,7 @@ public class OvsdbConnectionManagerTest {
         when(SouthboundMapper.createConnectionInfo(any(OvsdbClient.class))).thenReturn(key);
 
         suppress(MemberMatcher.method(OvsdbConnectionManager.class, "getInstanceIdentifier", ConnectionInfo.class));
-        InstanceIdentifier<Node> iid = mock(InstanceIdentifier.class);
-        when(ovsdbConnManager.getInstanceIdentifier(key)).thenReturn(iid);
+        when(ovsdbConnManager.getInstanceIdentifier(key)).thenReturn(mock(InstanceIdentifier.class));
 
         suppress(MemberMatcher.method(OvsdbConnectionManager.class, "getConnectionInstance", ConnectionInfo.class));
         when(ovsdbConnManager.getConnectionInstance(key)).thenReturn(null);
@@ -350,8 +348,7 @@ public class OvsdbConnectionManagerTest {
         when(ovsdbConnManager.connectedButCallBacksNotRegistered(any(OvsdbClient.class)))
                 .thenReturn(ovsdbConnectionInstance);
 
-        InstanceIdentifier<Node> iid = mock(InstanceIdentifier.class);
-        when(ovsdbConnectionInstance.getInstanceIdentifier()).thenReturn(iid);
+        when(ovsdbConnectionInstance.getInstanceIdentifier()).thenReturn(mock(InstanceIdentifier.class));
         field(OvsdbConnectionManager.class, "entityConnectionMap").set(ovsdbConnManager, entityConnectionMap);
         suppress(MemberMatcher.method(OvsdbConnectionManager.class, "getEntityFromConnectionInstance",
                 OvsdbConnectionInstance.class));
index e5a1eba66c2c0bb2a8ff7b5ef6b15645c265d3b4..20b2f3ca8177dc4aafdb3ed9a22a85da2f897bae 100644 (file)
@@ -138,8 +138,7 @@ public class OpenVSwitchUpdateCommandTest {
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "setInterfaceTypes",
                 OvsdbNodeAugmentationBuilder.class, OpenVSwitch.class));
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "setExternalIds",
-                InstanceIdentifierCodec.class, ReadWriteTransaction.class, OvsdbNodeAugmentationBuilder.class,
-                OpenVSwitch.class, OpenVSwitch.class));
+                ReadWriteTransaction.class, OvsdbNodeAugmentationBuilder.class, OpenVSwitch.class, OpenVSwitch.class));
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "setOtherConfig",
                 InstanceIdentifierCodec.class, ReadWriteTransaction.class, OvsdbNodeAugmentationBuilder.class,
                 OpenVSwitch.class, OpenVSwitch.class));
@@ -187,18 +186,18 @@ public class OpenVSwitchUpdateCommandTest {
         when(column.getData()).thenReturn(map);
         when(oldEntry.getOtherConfigColumn()).thenReturn(column);
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "removeOldConfigs",
-                InstanceIdentifierCodec.class, ReadWriteTransaction.class, Map.class, OpenVSwitch.class));
+                ReadWriteTransaction.class, Map.class, OpenVSwitch.class));
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "setNewOtherConfigs",
                 OvsdbNodeAugmentationBuilder.class, Map.class));
 
         ReadWriteTransaction transaction = mock(ReadWriteTransaction.class);
         OvsdbNodeAugmentationBuilder ovsdbNodeBuilder = mock(OvsdbNodeAugmentationBuilder.class);
-        Whitebox.invokeMethod(openVSwitchUpdateCommand, "setOtherConfig", mock(InstanceIdentifierCodec.class),
+        Whitebox.invokeMethod(openVSwitchUpdateCommand, "setOtherConfig",
                 transaction, ovsdbNodeBuilder, oldEntry, openVSwitch);
         verify(openVSwitch, times(2)).getOtherConfigColumn();
         verify(oldEntry, times(2)).getOtherConfigColumn();
         PowerMockito.verifyPrivate(openVSwitchUpdateCommand).invoke("removeOldConfigs",
-                any(InstanceIdentifierCodec.class), any(ReadWriteTransaction.class),
+                any(ReadWriteTransaction.class),
                 any(Map.class), any(OpenVSwitch.class));
     }
 
@@ -211,11 +210,10 @@ public class OpenVSwitchUpdateCommandTest {
 
         //suppress getNodeId()
         MemberModifier.suppress(
-                MemberMatcher.method(OpenVSwitchUpdateCommand.class, "getNodeId", InstanceIdentifierCodec.class,
-                        OpenVSwitch.class));
+                MemberMatcher.method(OpenVSwitchUpdateCommand.class, "getNodeId", OpenVSwitch.class));
         PowerMockito.whenNew(NodeKey.class).withAnyArguments().thenReturn(mock(NodeKey.class));
         OpenVSwitch ovs = mock(OpenVSwitch.class);
-        Whitebox.invokeMethod(openVSwitchUpdateCommand, "removeOldConfigs", mock(InstanceIdentifierCodec.class),
+        Whitebox.invokeMethod(openVSwitchUpdateCommand, "removeOldConfigs",
                 transaction, oldOtherConfigs, ovs);
         verify(transaction).delete(any(LogicalDatastoreType.class), any(KeyedInstanceIdentifier.class));
     }
@@ -254,18 +252,18 @@ public class OpenVSwitchUpdateCommandTest {
         when(column.getData()).thenReturn(map);
         when(oldEntry.getExternalIdsColumn()).thenReturn(column);
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "removeExternalIds",
-                InstanceIdentifierCodec.class, ReadWriteTransaction.class, Map.class, OpenVSwitch.class));
+                ReadWriteTransaction.class, Map.class, OpenVSwitch.class));
         MemberModifier.suppress(MemberMatcher.method(OpenVSwitchUpdateCommand.class, "setNewExternalIds",
                 OvsdbNodeAugmentationBuilder.class, Map.class));
 
         ReadWriteTransaction transaction = mock(ReadWriteTransaction.class);
         OvsdbNodeAugmentationBuilder ovsdbNodeBuilder = mock(OvsdbNodeAugmentationBuilder.class);
-        Whitebox.invokeMethod(openVSwitchUpdateCommand, "setExternalIds", mock(InstanceIdentifierCodec.class),
+        Whitebox.invokeMethod(openVSwitchUpdateCommand, "setExternalIds",
                 transaction, ovsdbNodeBuilder, oldEntry, openVSwitch);
         verify(openVSwitch, times(2)).getExternalIdsColumn();
         verify(oldEntry, times(2)).getExternalIdsColumn();
         PowerMockito.verifyPrivate(openVSwitchUpdateCommand).invoke("removeExternalIds",
-                any(InstanceIdentifierCodec.class), any(ReadWriteTransaction.class), any(Map.class),
+                any(ReadWriteTransaction.class), any(Map.class),
                 any(OpenVSwitch.class));
     }
 
@@ -278,11 +276,10 @@ public class OpenVSwitchUpdateCommandTest {
 
         //suppress getNodeId()
         MemberModifier.suppress(
-                MemberMatcher.method(OpenVSwitchUpdateCommand.class, "getNodeId", InstanceIdentifierCodec.class,
-                        OpenVSwitch.class));
+                MemberMatcher.method(OpenVSwitchUpdateCommand.class, "getNodeId", OpenVSwitch.class));
         PowerMockito.whenNew(NodeKey.class).withAnyArguments().thenReturn(mock(NodeKey.class));
         OpenVSwitch ovs = mock(OpenVSwitch.class);
-        Whitebox.invokeMethod(openVSwitchUpdateCommand, "removeExternalIds", mock(InstanceIdentifierCodec.class),
+        Whitebox.invokeMethod(openVSwitchUpdateCommand, "removeExternalIds",
                 transaction, oldExternalIds, ovs);
         verify(transaction).delete(any(LogicalDatastoreType.class), any(KeyedInstanceIdentifier.class));
     }
index e5b5c9e2387ea2bd9e63447cf870343cdcd64e69..c0e7ceb235d2d58f8960341d57901b1de707fc3f 100644 (file)
@@ -59,13 +59,11 @@ import org.powermock.reflect.Whitebox;
 @PrepareForTest({ OvsdbControllerUpdateCommand.class, SouthboundMapper.class, SouthboundUtil.class,
         InstanceIdentifier.class })
 public class OvsdbControllerUpdateCommandTest {
-    private Map<UUID, Controller> updatedControllerRows;
-    private Map<UUID, Bridge> updatedBridgeRows;
-    private OvsdbControllerUpdateCommand ovsdbControllerUpdateCommand;
-
     private static final String BRIDGE_NAME = "br-int";
     private static final String NODE_ID = "OF|00:00:00:0c:29:70:45:9b";
 
+    private OvsdbControllerUpdateCommand ovsdbControllerUpdateCommand;
+
     @Before
     public void setUp() {
         ovsdbControllerUpdateCommand = PowerMockito.mock(OvsdbControllerUpdateCommand.class,
@@ -86,7 +84,7 @@ public class OvsdbControllerUpdateCommandTest {
 
     @Test
     public void testExecute() throws Exception {
-        updatedControllerRows = new HashMap<>();
+        Map<UUID, Controller> updatedControllerRows = new HashMap<>();
         updatedControllerRows.put(mock(UUID.class), mock(Controller.class));
         MemberModifier.field(OvsdbControllerUpdateCommand.class, "updatedControllerRows")
                 .set(ovsdbControllerUpdateCommand, updatedControllerRows);
@@ -102,7 +100,7 @@ public class OvsdbControllerUpdateCommandTest {
                 any(ReadWriteTransaction.class), any(Map.class));
 
         // updatedBridgeRows not null case
-        updatedBridgeRows = new HashMap<>();
+        Map<UUID, Bridge> updatedBridgeRows = new HashMap<>();
         updatedBridgeRows.put(mock(UUID.class), mock(Bridge.class));
         MemberModifier.field(OvsdbControllerUpdateCommand.class, "updatedBridgeRows").set(ovsdbControllerUpdateCommand,
                 updatedBridgeRows);
index c8dcb136d79369d2744a4ba53d27021b0288243c..cf638f7340e79127d297b35500ba2a0db4393b4e 100644 (file)
@@ -57,8 +57,7 @@ public class OvsdbManagersUpdateCommandTest {
 
     private static final String TARGET_COLUMN_DATA = "Manager Column";
     private static final String NODE_ID = "Node ID String";
-    private Map<UUID, Manager> updatedManagerRows;
-    private Map<UUID, OpenVSwitch> updatedOpenVSwitchRows;
+
     private OvsdbManagersUpdateCommand ovsdbManagersUpdateCommand;
 
     @Before
@@ -79,7 +78,7 @@ public class OvsdbManagersUpdateCommandTest {
 
     @Test
     public void testExecute() throws Exception {
-        updatedManagerRows = new HashMap<>();
+        Map<UUID, Manager> updatedManagerRows = new HashMap<>();
         updatedManagerRows.put(mock(UUID.class), mock(Manager.class));
         MemberModifier.field(OvsdbManagersUpdateCommand.class, "updatedManagerRows").set(ovsdbManagersUpdateCommand,
                 updatedManagerRows);
@@ -87,7 +86,7 @@ public class OvsdbManagersUpdateCommandTest {
         PowerMockito.doReturn(updatedManagerRowsWithUri).when(ovsdbManagersUpdateCommand, "getUriManagerMap",
                 any(Map.class));
 
-        updatedOpenVSwitchRows = new HashMap<>();
+        Map<UUID, OpenVSwitch> updatedOpenVSwitchRows = new HashMap<>();
         updatedOpenVSwitchRows.put(mock(UUID.class), mock(OpenVSwitch.class));
         MemberModifier.field(OvsdbManagersUpdateCommand.class, "updatedOpenVSwitchRows").set(ovsdbManagersUpdateCommand,
                 updatedOpenVSwitchRows);
index f52677a64090e3dccfdb0ca21845e051a7720afd..eb18c76c43f9265272d6241e82b8479538f33ce9 100644 (file)
@@ -93,10 +93,9 @@ public class TransactionInvokerImplTest {
     public void testOnTransactionChainFailed() throws Exception {
         field(TransactionInvokerImpl.class, "failedTransactionQueue").set(transactionInvokerImpl,
                 failedTransactionQ);
-        TransactionChain<?, ?> chain = mock(TransactionChain.class);
         AsyncTransaction<?, ?> transaction = mock(AsyncTransaction.class);
         Throwable cause = mock(Throwable.class);
-        transactionInvokerImpl.onTransactionChainFailed(chain, transaction, cause);
+        transactionInvokerImpl.onTransactionChainFailed(mock(TransactionChain.class), transaction, cause);
         BlockingQueue<AsyncTransaction<?, ?>> testFailedTransactionQueue = Whitebox
                 .getInternalState(transactionInvokerImpl, "failedTransactionQueue");
         assertTrue(testFailedTransactionQueue.contains(transaction));
index 69f08f28c2b4b511566b00d17fbd12aabaf9e65b..9b9c770ea17797bc342332dd3ebb273c302716d6 100644 (file)
@@ -9,23 +9,22 @@ package org.opendaylight.ovsdb.utils.config;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNull;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-
 import static org.mockito.Mockito.eq;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import org.junit.Test;
+import org.junit.runner.RunWith;
 import org.osgi.framework.Bundle;
 import org.osgi.framework.BundleContext;
-import org.powermock.api.mockito.PowerMockito;
 import org.osgi.framework.FrameworkUtil;
+import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.PowerMockRunner;
 
 @RunWith(PowerMockRunner.class)
-@PrepareForTest( {System.class, FrameworkUtil.class} )
- public class ConfigPropertiesTest {
+@PrepareForTest({System.class, FrameworkUtil.class})
+public class ConfigPropertiesTest {
 
     private static final String TEST_PROPERTY_KEY1 = "foobar34465$3467";
     private static final String TEST_PROPERTY_MOCK_VALUE1 = "xbarMock1";
@@ -38,7 +37,6 @@ import org.powermock.modules.junit4.PowerMockRunner;
     public void testGetProperty() {
         Bundle bundleWithoutBundleNoContext = mock(Bundle.class);
         Bundle bundle = mock(Bundle.class);
-        BundleContext bundleContext = mock(BundleContext.class);
 
         // mock #1
         PowerMockito.mockStatic(FrameworkUtil.class);
@@ -46,6 +44,7 @@ import org.powermock.modules.junit4.PowerMockRunner;
         PowerMockito.when(FrameworkUtil.getBundle(ConfigPropertiesTestMockingBundleNoContext.class))
                 .thenReturn(bundleWithoutBundleNoContext);
         // mock #2
+        BundleContext bundleContext = mock(BundleContext.class);
         when(bundle.getBundleContext()).thenReturn(bundleContext);
         when(bundleWithoutBundleNoContext.getBundleContext()).thenReturn(null);
         // mock #3
@@ -62,7 +61,7 @@ import org.powermock.modules.junit4.PowerMockRunner;
         assertNull(FrameworkUtil.getBundle(ConfigPropertiesTestMocking.class));
         assertEquals(FrameworkUtil.getBundle(ConfigPropertiesTest.class), bundle);
         assertEquals(FrameworkUtil.getBundle(ConfigPropertiesTestMockingBundleNoContext.class),
-                     bundleWithoutBundleNoContext);
+                bundleWithoutBundleNoContext);
 
         // test 2. bundleContext is null
         assertNull(bundleWithoutBundleNoContext.getBundleContext());
@@ -77,25 +76,28 @@ import org.powermock.modules.junit4.PowerMockRunner;
         final String value41 = ConfigProperties.getProperty(ConfigPropertiesTestMocking.class, TEST_PROPERTY_KEY1);
         assertNull(value41);  // class has no bundle
         final String value42 = ConfigProperties.getProperty(ConfigPropertiesTestMockingBundleNoContext.class,
-                                                            TEST_PROPERTY_KEY1);
+                TEST_PROPERTY_KEY1);
         assertNull(value42);  // class has no bundleContext
         final String value43 = ConfigProperties.getProperty(this.getClass(), TEST_PROPERTY_KEY_NOT_FOUND);
         assertNull(value43);  // bundleContext will not know about key provided
 
         // test 5. value returned from ConfigProperties.getProperty is the default value provided
-        final String value5 = ConfigProperties.getProperty(this.getClass(), TEST_PROPERTY_KEY_NOT_FOUND, DEFAULT_PROPERTY_VALUE);
+        final String value5 =
+                ConfigProperties.getProperty(this.getClass(), TEST_PROPERTY_KEY_NOT_FOUND, DEFAULT_PROPERTY_VALUE);
         assertEquals(DEFAULT_PROPERTY_VALUE, value5);
 
         // test 6. value returned from ConfigProperties.getProperty is the mocked value
         final String value61 = ConfigProperties.getProperty(this.getClass(), TEST_PROPERTY_KEY1);
         assertEquals(TEST_PROPERTY_MOCK_VALUE1, value61);
-        final String value62 = ConfigProperties.getProperty(this.getClass(), TEST_PROPERTY_KEY1, DEFAULT_PROPERTY_VALUE);
+        final String value62 =
+                ConfigProperties.getProperty(this.getClass(), TEST_PROPERTY_KEY1, DEFAULT_PROPERTY_VALUE);
         assertEquals(TEST_PROPERTY_MOCK_VALUE1, value62);
     }
 
     // Helper classes used to de-mux mock behaviors
     private class ConfigPropertiesTestMockingBundleNoContext {
     }
+
     private class ConfigPropertiesTestMocking {
     }
 }
index 6470e6f210a6f449cdb7cc794c93868956d6ff89..5050ce893f5a712f878200ffb7530a08f7129f6b 100644 (file)
@@ -7,15 +7,13 @@
  */
 package org.opendaylight.ovsdb.utils.yang;
 
+import com.google.common.base.Preconditions;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.function.Function;
-
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
-import com.google.common.base.Preconditions;
-
 /**
  * YANG utility functions.
  */