Bug 3841 - wrong severity level: getTenantNetwork did not find network
authorFlavio Fernandes <ffernand@redhat.com>
Tue, 23 Jun 2015 15:33:24 +0000 (11:33 -0400)
committerFlavio Fernandes <ffernand@redhat.com>
Tue, 23 Jun 2015 16:04:16 +0000 (16:04 +0000)
when using normal ovsdb net-virt, I see benign logs like these:

WARN  | ntDispatcherImpl | TenantNetworkManagerImpl | 271 - org.opendaylight.ovsdb.openstack.net-virt - 1.1.0.SNAPSHOT | getTenantNetwork did not find network for patch-int

these should be debug at best; not warning.

Patch set 2: add changes from code review

Change-Id: I6f0b0aa6880c2b6892e5b9974ce5df6c0d217bf5
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/TenantNetworkManagerImpl.java

index f04f9df0c066dd15f4d6e260ec9ba6935611f192..1ecfa0168bb08c945d08f6df846c079601716eb8 100644 (file)
@@ -124,19 +124,16 @@ public class TenantNetworkManagerImpl implements ConfigInterface, TenantNetworkM
                 if (neutronNetwork != null) {
                     logger.debug("mapped to {}", neutronNetwork);
                 } else {
-                    logger.debug("getTenantNetwork: did not find neutronNetwork in cache");
+                    logger.debug("getTenantNetwork: did not find neutronNetwork in cache from neutronPort {}",
+                                 neutronPortId);
                 }
             } else {
-                logger.debug("getTenantNetwork: did not find neutronPort in cache");
+                logger.info("getTenantNetwork did not find neutronPort {} from termination point {}",
+                        neutronPortId, terminationPointAugmentation.getName());
             }
         } else {
             logger.debug("getTenantNetwork: did not find {} in external_ids", Constants.EXTERNAL_ID_INTERFACE_ID);
         }
-        if (neutronNetwork != null) {
-            logger.debug("mapped to {}", neutronNetwork);
-        } else {
-            logger.warn("getTenantNetwork did not find network for {}", terminationPointAugmentation.getName());
-        }
         return neutronNetwork;
     }