Use a global comparator 34/97134/1
authorRobert Varga <robert.varga@pantheon.tech>
Wed, 11 Aug 2021 12:01:40 +0000 (14:01 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Wed, 11 Aug 2021 12:02:38 +0000 (14:02 +0200)
Rather than instantiating a new comparator every time, just reuse a
single instance.

Change-Id: Ida1e9c1f41c5ab67a2847173bdcad6a1cd780c0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/DOMActionRoutingTableEntry.java

index 33bd80a285acfd6fdbf1127f3ae21fa9ce744ce8..0b539b4fae987970cbc224e1f873696c3b8e173f 100644 (file)
@@ -24,6 +24,9 @@ import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier.Absol
 @Beta
 final class DOMActionRoutingTableEntry extends AbstractDOMRoutingTableEntry<DOMDataTreeIdentifier,
         DOMActionImplementation, AvailabilityListener, Absolute> {
+    private static final Comparator<DOMActionImplementation> COMPARATOR =
+        Comparator.comparingLong(DOMActionImplementation::invocationCost);
+
     DOMActionRoutingTableEntry(final Absolute type,
             final Map<DOMDataTreeIdentifier, List<DOMActionImplementation>> implementations) {
         super(type, implementations);
@@ -37,7 +40,7 @@ final class DOMActionRoutingTableEntry extends AbstractDOMRoutingTableEntry<DOMD
 
     @Override
     protected Comparator<DOMActionImplementation> implComparator() {
-        return Comparator.comparingLong(DOMActionImplementation::invocationCost);
+        return COMPARATOR;
     }
 
     @Override