Document AbstractPeer.bindingChain visibility

This field accessed by a test, annotate it as such and also make
sure we comply with synchronization rules.

Change-Id: I4d1280b140cae493ed7cb69a37cb950b0af82bfa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/AbstractPeer.java b/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/AbstractPeer.java
index 3e3dd3bbac20e27b110009953f84b66c734a926c..4656a79ebfaebe90a0bcfde319818108b2e1d096 100644 (file)
--- a/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/AbstractPeer.java
+++ b/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/AbstractPeer.java
@@ -9,6 +9,7 @@ package org.opendaylight.protocol.bgp.rib.impl;
 
 import static org.opendaylight.protocol.bgp.rib.spi.RIBNodeIdentifiers.PEER_NID;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.util.concurrent.FluentFuture;
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.MoreExecutors;
@@ -77,6 +78,7 @@ abstract class AbstractPeer extends BGPPeerStateImpl implements BGPRouteEntryImp
     @GuardedBy("this")
     private DOMTransactionChain domChain;
     @GuardedBy("this")
+    @VisibleForTesting
     TransactionChain bindingChain;
     byte[] rawIdentifier;
     @GuardedBy("this")

diff --git a/bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/GracefulRestartTest.java b/bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/GracefulRestartTest.java
index 543c5ed662b6dc96319cdc7887c01dcb6a6f12b8..528207a0d170f19996a11e18b49b6657bc63e084 100644 (file)
--- a/bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/GracefulRestartTest.java
+++ b/bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/GracefulRestartTest.java
@@ -161,7 +161,9 @@ public class GracefulRestartTest extends AbstractAddPathTest {
         final Open open = createClassicOpen(true);
         this.sessionv6.writeAndFlush(open);
         checkIdleState(this.nonIpv4);
-        assertNull(this.nonIpv4.bindingChain);
+        synchronized (this.nonIpv4) {
+            assertNull(this.nonIpv4.bindingChain);
+        }
     }
 
     /**