Bug 2245 - Added private constructors to utility classes, in order to hide the implic... 80/14480/1
authorMartin Uhlir <martin.uhlir@pantheon.sk>
Mon, 26 Jan 2015 12:36:06 +0000 (13:36 +0100)
committerMartin Uhlir <martin.uhlir@pantheon.sk>
Mon, 26 Jan 2015 13:06:01 +0000 (14:06 +0100)
Change-Id: I9c0c0d0e2e91f87ca24c5ac5b7edb8931dbc7a2f
Signed-off-by: Martin Uhlir <martin.uhlir@pantheon.sk>
openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/util/BinContent.java
openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/util/EncodeConstants.java
openflow-protocol-api/src/main/java/org/opendaylight/openflowjava/protocol/api/util/OxmMatchConstants.java
openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/CodeKeyMakerFactory.java
openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/ListSerializer.java
openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/OpenflowUtils.java
openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/util/TypeKeyMakerFactory.java
util/src/main/java/org/opendaylight/openflowjava/util/ByteBufUtils.java
util/src/main/java/org/opendaylight/openflowjava/util/ExperimenterDeserializerKeyFactory.java

index aa322f915815548ccc7e2f5d90611f7509ab07c4..428b5004d143f7f4e4558c42a4bcdf1774efaa21 100644 (file)
@@ -14,6 +14,10 @@ package org.opendaylight.openflowjava.protocol.api.util;
  */
 public abstract class BinContent {
 
+    private BinContent() {
+        //not called
+    }
+    
     /**
      * @param value
      * @return int part wrapped in long
index cf857285ee8831ca660ea5eacbc35b412a3aac92..82a09282cb54688350370df6adb3647602b80ff7 100644 (file)
@@ -58,4 +58,7 @@ public abstract class EncodeConstants {
     /** OF v1.3 lenght of experimenter_ids - see Multipart TableFeatures (properties) message */
     public static final byte EXPERIMENTER_IDS_LENGTH = 8;
 
+    private EncodeConstants() {
+        //not called
+    }
 }
index 3bc7558ed204f1c3b99db393c78067cc337683d6..78a5871cc4322583b440fcaea355f3692c994419 100644 (file)
@@ -114,4 +114,8 @@ public abstract class OxmMatchConstants {
     public static final int NXM_NX_TUN_IPV4_DST = 32;
     /** NXM TCP_Flag value */
     public static final int NXM_NX_TCP_FLAG = 34;
+    
+    private OxmMatchConstants() {
+        //not called
+    }
 }
\ No newline at end of file
index 7713e355e4d30a5ca6b0d297c51dbb400f0d583b..8a03f5341c916979b37b0d51827c2376e3894d03 100644 (file)
@@ -24,6 +24,9 @@ import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants;
  */
 public abstract class CodeKeyMakerFactory {
 
+    private CodeKeyMakerFactory() {
+        //not called
+    }
     /**
      * @param version
      * @return
index f69c25b6e801e07fe1e6755f985a45d5957734f7..8b1c7f704a02b8368d2ba6b482063a92afb83403 100644 (file)
@@ -24,6 +24,10 @@ import org.opendaylight.yangtools.yang.binding.DataObject;
  */
 public abstract class ListSerializer {
 
+    private ListSerializer() {
+        //not called
+    }
+    
     /**
      * Serializes item list
      * @param list list of items to be serialized
index f865ac3d5075300615bbe4f5b3160f97c2a9a7cd..cb6e657e03cd3694dfef28e4d9a2ee5adb7613fc 100644 (file)
@@ -19,6 +19,10 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev13
  */
 public abstract class OpenflowUtils {
 
+    private OpenflowUtils() {
+        //not called
+    }
+    
     /**
      * Creates PortState (OF v1.0) from input
      * @param input value read from buffer
index 2c5b7def13768eb0ca2b572282163ac20c7b3723..d9fd13407f96d11364ed33f8c52555fb0127eb27 100644 (file)
@@ -29,6 +29,10 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.oxm.rev130731.oxm.
  */
 public abstract class TypeKeyMakerFactory {
 
+    private TypeKeyMakerFactory() {
+        //not called
+    }
+    
     /**
      * @param version openflow wire version that shall be used
      *  in lookup key
index 444cffc504ad9ffcdcc2e571f15d599012c603f0..4ac43f65322a7b05a7e2291d22571015fe043682 100644 (file)
@@ -35,6 +35,10 @@ public abstract class ByteBufUtils {
     public static final Splitter COLON_SPLITTER = Splitter.on(':');
     private static final char[] HEX_CHARS = "0123456789ABCDEF".toCharArray();
 
+    private ByteBufUtils() {
+        //not called
+    }
+
     /**
      * Converts ByteBuf into String
      * @param bb input ByteBuf
index 8ef85bc4272bdc8e5f18ad6c9609831efdacf0e2..1a7a5d26a688f4a0b64b7fcb2e2e1b75563a587a 100644 (file)
@@ -22,6 +22,10 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731
  */
 public abstract class ExperimenterDeserializerKeyFactory {
 
+    private ExperimenterDeserializerKeyFactory() {
+        //not called
+    }
+    
     /**
      * @param version openflow wire version
      * @param experimenterId experimenter / vendor ID