Coverage - StatisticsContextImpl

Change-Id: Ifee04a43a1a10498e47c50fb8fbb983ab78e5050
Signed-off-by: Michal Rehak <mirehak@cisco.com>

diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java
index 8df7d7f7bac8dcf01cada6137111d7b8fb974b0b..430c860a03e53d401a27f70607be05ee2abfa637 100644 (file)
--- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java
+++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java
@@ -170,7 +170,8 @@ public class StatisticsContextImpl implements StatisticsContext {
      *
      * @return
      */
-    private ListenableFuture<Boolean> deviceConnectionCheck() {
+    @VisibleForTesting
+    ListenableFuture<Boolean> deviceConnectionCheck() {
         if (!ConnectionContext.CONNECTION_STATE.WORKING.equals(deviceContext.getPrimaryConnectionContext().getConnectionState())) {
             ListenableFuture<Boolean> resultingFuture = SettableFuture.create();
             switch (deviceContext.getPrimaryConnectionContext().getConnectionState()) {

diff --git a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java
index bc41946055c193924d0981cf59d208835720da80..25a153592e731dc210d9b4443691afdc7c44f719 100644 (file)
--- a/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java
+++ b/openflowplugin-impl/src/test/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImplTest.java
@@ -13,32 +13,150 @@ package org.opendaylight.openflowplugin.impl.statistics;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.ListenableFuture;
+import java.util.Collections;
+import java.util.concurrent.ExecutionException;
+import org.junit.Assert;
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Matchers;
+import org.mockito.Mockito;
+import org.mockito.runners.MockitoJUnitRunner;
+import org.opendaylight.openflowplugin.api.openflow.connection.ConnectionContext;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContext;
+import org.opendaylight.openflowplugin.api.openflow.statistics.ofpspecific.EventIdentifier;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.MultipartType;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731.MultipartReply;
+import org.opendaylight.yangtools.yang.common.RpcResult;
+import org.opendaylight.yangtools.yang.common.RpcResultBuilder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
+@RunWith(MockitoJUnitRunner.class)
 public class StatisticsContextImplTest extends StatisticsContextImpMockInitiation {
 
-    private static final Long TEST_XID = 55l;
+    private static final Logger LOG = LoggerFactory.getLogger(StatisticsContextImplTest.class);
 
-    @Test
-    public void createRequestContextTest() {
+    private static final Long TEST_XID = 55L;
+    private StatisticsContextImpl statisticsContext;
+
+    @Before
+    public void setUp() throws Exception {
         when(mockedDeviceContext.getReservedXid()).thenReturn(TEST_XID);
+        initStatisticsContext();
+    }
 
-        StatisticsContextImpl statisticsContext = new StatisticsContextImpl(mockedDeviceContext);
+    private void initStatisticsContext() {
+        statisticsContext = new StatisticsContextImpl(mockedDeviceContext);
+        statisticsContext.setStatisticsGatheringService(mockedStatisticsGatheringService);
+        statisticsContext.setStatisticsGatheringOnTheFlyService(mockedStatisticsOnFlyGatheringService);
+    }
+
+    @Test
+    public void testCreateRequestContext() {
         RequestContext<Object> requestContext = statisticsContext.createRequestContext();
         assertNotNull(requestContext);
         assertEquals(TEST_XID, requestContext.getXid().getValue());
+        Assert.assertFalse(requestContext.getFuture().isDone());
     }
 
     /**
      * There is nothing to check in close method
      */
     @Test
-    public void closeTest() {
+    public void testClose() throws Exception {
         StatisticsContextImpl statisticsContext = new StatisticsContextImpl(mockedDeviceContext);
-        statisticsContext.createRequestContext();
+        final RequestContext<Object> requestContext = statisticsContext.createRequestContext();
         statisticsContext.close();
+        try {
+            Assert.assertTrue(requestContext.getFuture().isDone());
+            final RpcResult<?> rpcResult = requestContext.getFuture().get();
+            Assert.assertFalse(rpcResult.isSuccessful());
+            Assert.assertFalse(rpcResult.isSuccessful());
+        } catch (Exception e) {
+            LOG.error("request future value should be finished", e);
+            Assert.fail("request context closing failed");
+        }
+    }
+
+    @Test
+    public void testGatherDynamicData_none() throws Exception {
+        final ListenableFuture<Boolean> gatheringResult = statisticsContext.gatherDynamicData();
+        Assert.assertTrue(gatheringResult.isDone());
+        Assert.assertTrue(gatheringResult.get());
+        Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService);
+    }
+
+    @Test
+    public void testGatherDynamicData_all() throws Exception {
+        Mockito.reset(mockedDeviceState);
+        when(mockedDeviceState.isTableStatisticsAvailable()).thenReturn(true);
+        when(mockedDeviceState.isFlowStatisticsAvailable()).thenReturn(true);
+        when(mockedDeviceState.isGroupAvailable()).thenReturn(true);
+        when(mockedDeviceState.isMetersAvailable()).thenReturn(true);
+        when(mockedDeviceState.isPortStatisticsAvailable()).thenReturn(true);
+        when(mockedDeviceState.isQueueStatisticsAvailable()).thenReturn(true);
+        initStatisticsContext();
+
+        when(mockedStatisticsGatheringService.getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
+                .thenReturn(
+                        Futures.immediateFuture(RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build())
+                );
+        when(mockedStatisticsOnFlyGatheringService.getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class)))
+                .thenReturn(
+                        Futures.immediateFuture(RpcResultBuilder.success(Collections.<MultipartReply>emptyList()).build())
+                );
+
+        final ListenableFuture<Boolean> gatheringResult = statisticsContext.gatherDynamicData();
+        Assert.assertTrue(gatheringResult.isDone());
+        Assert.assertTrue(gatheringResult.get());
+        verify(mockedStatisticsGatheringService, times(7))
+                .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class));
+        verify(mockedStatisticsOnFlyGatheringService)
+                .getStatisticsOfType(Matchers.any(EventIdentifier.class), Matchers.any(MultipartType.class));
+        Mockito.verifyNoMoreInteractions(mockedStatisticsGatheringService, mockedStatisticsOnFlyGatheringService);
+    }
+
+    @Test
+    public void testDeviceConnectionCheck_WORKING() throws Exception {
+        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
+        Assert.assertNull(deviceConnectionCheckResult);
+    }
+
+    @Test
+    public void testDeviceConnectionCheck_RIP() throws Exception {
+        Mockito.reset(mockedConnectionContext);
+        when(mockedConnectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.RIP);
+        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
+        Assert.assertNotNull(deviceConnectionCheckResult);
+        Assert.assertTrue(deviceConnectionCheckResult.isDone());
+        try {
+            deviceConnectionCheckResult.get();
+            Assert.fail("connection in state RIP should have caused exception here");
+        } catch (Exception e) {
+            LOG.debug("expected behavior for RIP connection achieved");
+            Assert.assertTrue(e instanceof ExecutionException);
+        }
+    }
+
+    @Test
+    public void testDeviceConnectionCheck_HANSHAKING() throws Exception {
+        Mockito.reset(mockedConnectionContext);
+        when(mockedConnectionContext.getConnectionState()).thenReturn(ConnectionContext.CONNECTION_STATE.HANDSHAKING);
+        final ListenableFuture<Boolean> deviceConnectionCheckResult = statisticsContext.deviceConnectionCheck();
+        Assert.assertNotNull(deviceConnectionCheckResult);
+        Assert.assertTrue(deviceConnectionCheckResult.isDone());
+        try {
+            final Boolean checkPositive = deviceConnectionCheckResult.get();
+            Assert.assertTrue(checkPositive);
+        } catch (Exception e) {
+            Assert.fail("connection in state HANDSHAKING should NOT have caused exception here");
+        }
     }
 }