Pin git review to 1.78

The latest version of module trys to look for git hook
recursively within the submodules.

Error:
    Entering 'global-jjb'
    cannot stat '.git/hooks/commit-msg': Not a directory
    fatal: run_command returned non-zero status for global-jjb

Remove workaround that has been resolved in v1.28 and use
lf-activate-venv to install git-review

Issue: RELENG-3435
Signed-off-by: Anil Belur <[email protected]>
Change-Id: I6839e2466174b3d27df21853bf960aa7c7711526
Signed-off-by: Anil Belur <[email protected]>

diff --git a/jjb/autorelease/branch-cut.sh b/jjb/autorelease/branch-cut.sh
index 342786b8b6a78b24882412a6fbf2952015fb8a25..0c24b27c94f342d62a78328fb4dd521c2336952d 100644 (file)
--- a/jjb/autorelease/branch-cut.sh
+++ b/jjb/autorelease/branch-cut.sh
@@ -28,7 +28,10 @@ LOG_FILE="$WORKSPACE/archives/branch-cut.log"
 
 set -eu -o pipefail
 
-pip install --user --quiet --upgrade git-review
+# shellcheck disable=SC1090
+source ~/lf-env.sh
+
+lf-activate-venv "git-review==1.28"
 
 # Validate inputs
 if [ -z "$RELEASE" ]; then

diff --git a/jjb/autorelease/generate-release-notes.sh b/jjb/autorelease/generate-release-notes.sh
index 46efa078f2b52513a4d5a387cb9f8204a9f6ac07..3e5992ab99f90118ab44d6c328c121b970b17c56 100644 (file)
--- a/jjb/autorelease/generate-release-notes.sh
+++ b/jjb/autorelease/generate-release-notes.sh
@@ -13,7 +13,10 @@
 
 set -x
 
-pip install --user --quiet --upgrade git-review
+# shellcheck disable=SC1090
+source ~/lf-env.sh
+
+lf-activate-venv "git-review==1.28"
 
 RELEASE=${RELEASE:-$(echo "$GERRIT_EVENT_COMMENT_TEXT" | base64 -d | grep generate-release-notes | awk '{print $2}')}
 if [ -z "$RELEASE" ]; then

diff --git a/jjb/autorelease/version-bump.sh b/jjb/autorelease/version-bump.sh
index 1980f77df94a823286db48255891552b89a44589..f54e0a3e85a6c5f853b9edb6013a35e6c4ec223f 100644 (file)
--- a/jjb/autorelease/version-bump.sh
+++ b/jjb/autorelease/version-bump.sh
@@ -26,7 +26,10 @@ BRANCH="$GERRIT_BRANCH"
 # Ensure we fail the job if any steps fail.
 set -eu -o pipefail
 
-pip install --user --quiet --upgrade git-review
+# shellcheck disable=SC1090
+source ~/lf-env.sh
+
+lf-activate-venv "git-review==1.28"
 
 # Fail if branch cutting is not on master
 if [ "$BRANCH_CUT" = "true" ] && [ "$BRANCH" != "master" ]; then

diff --git a/jjb/docs/docs_version_bump_projects.sh b/jjb/docs/docs_version_bump_projects.sh
index ce7cd3ba3fd83ab7014caf1b706b0f5c6b761bb1..6db45944a56b4bf5b1a9327ad429869e442cb55c 100644 (file)
--- a/jjb/docs/docs_version_bump_projects.sh
+++ b/jjb/docs/docs_version_bump_projects.sh
@@ -28,12 +28,12 @@ while getopts :h: opts; do
         ;;
   esac
 done
-set +u  # Allow unbound variables for virtualenv
-virtualenv --quiet "/tmp/v/git-review"
-# shellcheck source=/tmp/v/git-review/bin/activate disable=SC1091
-source "/tmp/v/git-review/bin/activate"
-pip install --quiet --upgrade "pip==9.0.3" setuptools
-pip install --quiet --upgrade git-review
+
+# shellcheck disable=SC1090
+source ~/lf-env.sh
+
+lf-activate-venv "git-review==1.28"
+
 git config --global --add gitreview.username "jenkins-$SILO"
 cd "$WORKSPACE"/autorelease || exit
 GERRIT_PROJECT="releng/autorelease"