Fix logging issues in dhcpservice

Change-Id: If7a7e8f95dfc7509169c470068f1179c2c99730e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

diff --git a/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCP.java b/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCP.java
index 7e3b20599593705fa9a40e2f11399bd11b872f50..a648115b1a0e62fecf5d603a1c46d28e22c7d563 100644 (file)
--- a/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCP.java
+++ b/dhcpservice/api/src/main/java/org/opendaylight/netvirt/dhcpservice/api/DHCP.java
@@ -37,8 +37,8 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public class DHCP extends Packet {
-    protected static final Logger LOG = LoggerFactory
-            .getLogger(DHCP.class);
+    private static final Logger LOG = LoggerFactory.getLogger(DHCP.class);
+
     private static final String OP      = "Op";
     private static final String HTYPE   = "Htype";
     private static final String HLEN    = "Hlen";

diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java
index 38dbfbe95aa55afad86e7659385586bb43eb12af..068f871c131c51abd27d350d110c0b67bb25c2c1 100644 (file)
--- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java
+++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpExternalTunnelManager.java
@@ -764,7 +764,7 @@ public class DhcpExternalTunnelManager {
                 LOG.warn("RPC call to ITM.GetExternalTunnelInterfaceName failed with error: {}", rpcResult.getErrors());
             }
         } catch (NullPointerException | InterruptedException | ExecutionException e) {
-            LOG.error("Failed to get external tunnel interface name for sourceNode: {} and dstNode: {}: {} ",
+            LOG.error("Failed to get external tunnel interface name for sourceNode: {} and dstNode: {}",
                     sourceNode, dstNode, e);
         }
         return tunnelInterfaceName;

diff --git a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpSubnetListener.java b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpSubnetListener.java
index c69337a1afcb851c09a16a74f3845029a428a1ab..accb4f78f05e047724d2b76b529721bb75e470ad 100644 (file)
--- a/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpSubnetListener.java
+++ b/dhcpservice/impl/src/main/java/org/opendaylight/netvirt/dhcpservice/DhcpSubnetListener.java
@@ -180,7 +180,7 @@ public class DhcpSubnetListener extends AsyncClusteredDataTreeChangeListenerBase
             BigInteger designatedDpnId =
                     dhcpExternalTunnelManager.readDesignatedSwitchesForExternalTunnel(tunnelIp, networkId.getValue());
             LOG.trace("CR-DHCP DhcpSubnetListener update Install DIRECT vmMacAddress: {} tunnelIp: {} "
-                    + "designatedDpnId : {} ListOf Dpn:",
+                    + "designatedDpnId : {} ListOf Dpn: {}",
                     vmMacAddress, tunnelIp, designatedDpnId, listOfDpns);
             dhcpExternalTunnelManager.installDhcpFlowsForVms(tunnelIp, networkId.getValue(), listOfDpns,
                     designatedDpnId, vmMacAddress);