Enforce findbug and checkstyle under BMP SPI

Change-Id: I6e0de407586040e6de8d86bf45bedb614a769d4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

diff --git a/bmp/bmp-spi/pom.xml b/bmp/bmp-spi/pom.xml
index 2b4ff17ee7a0377ca97e14461b341e8ddacf14ac..6e4abb65f1202fafbcf6415c960eecf8aa2d0e2d 100644 (file)
--- a/bmp/bmp-spi/pom.xml
+++ b/bmp/bmp-spi/pom.xml
@@ -123,6 +123,13 @@
                     <propertyExpansion>checkstyle.violationSeverity=error</propertyExpansion>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.codehaus.mojo</groupId>
+                <artifactId>findbugs-maven-plugin</artifactId>
+                <configuration>
+                    <failOnError>true</failOnError>
+                </configuration>
+            </plugin>
         </plugins>
     </build>
 

diff --git a/bmp/bmp-spi/src/main/java/org/opendaylight/protocol/bmp/api/BmpSessionFactory.java b/bmp/bmp-spi/src/main/java/org/opendaylight/protocol/bmp/api/BmpSessionFactory.java
index 7345e5f03fac39b54383c74f8fb0c72701c41b72..777b146c187aae8e4522c21231ae5c95c8836425 100644 (file)
--- a/bmp/bmp-spi/src/main/java/org/opendaylight/protocol/bmp/api/BmpSessionFactory.java
+++ b/bmp/bmp-spi/src/main/java/org/opendaylight/protocol/bmp/api/BmpSessionFactory.java
@@ -10,7 +10,6 @@ package org.opendaylight.protocol.bmp.api;
 
 import io.netty.channel.Channel;
 import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
 
 public interface BmpSessionFactory {
     /**
@@ -20,6 +19,7 @@ public interface BmpSessionFactory {
      * @param sessionListenerFactory listener factory
      * @return bmp session
      */
-    @Nonnull BmpSession getSession(@Nonnull Channel channel,
-            @Nullable BmpSessionListenerFactory sessionListenerFactory);
+    @Nonnull
+    BmpSession getSession(@Nonnull Channel channel,
+            @Nonnull BmpSessionListenerFactory sessionListenerFactory);
 }