TopologySessionListener is not AutoCloseable

Using AutoCloseable hides internal callers. We also will need an
asynchronous shutdown facility, so let's just define a close() method
we can evolve.

JIRA: BGPCEP-1005
Change-Id: I95be847237ad38644e57bc6400bb38be64af2784
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java b/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java
index 15e48ff6fbd1abf3ce0c1b08e5df0fe2bea138cb..90a2fb4ec5462186786c0cc95aa5197c9fe24bc0 100644 (file)
--- a/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java
+++ b/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/AbstractTopologySessionListener.java
@@ -370,6 +370,7 @@ public abstract class AbstractTopologySessionListener implements TopologySession
      */
     protected abstract boolean onMessage(MessageContext ctx, Message message);
 
+    // Non-final for mocking
     @Override
     public void close() {
         synchronized (serverSessionManager) {

diff --git a/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologySessionListener.java b/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologySessionListener.java
index 8aa5855a65ce81a500bc698b1455c4de6b80eda0..c7d0272a8511008ede0c4bf0248ab41b05a0e4c1 100644 (file)
--- a/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologySessionListener.java
+++ b/pcep/topology/topology-provider/src/main/java/org/opendaylight/bgpcep/pcep/topology/provider/TopologySessionListener.java
@@ -9,7 +9,7 @@ package org.opendaylight.bgpcep.pcep.topology.provider;
 
 import org.opendaylight.protocol.pcep.PCEPSessionListener;
 
-interface TopologySessionListener extends AutoCloseable, PCEPSessionListener, TopologySessionRPCs {
-    @Override
+interface TopologySessionListener extends PCEPSessionListener, TopologySessionRPCs {
+    // FIXME: this needs to provide a future which completes when everything is cleaned up
     void close();
 }
\ No newline at end of file