Bug 3367 - StatManagerImpl scalable statPolling per stat type on device

Note: Running all stats for all device statistics in one time is
realy not good idea. So we'd like to bring a possibility for
scalable statistics aproach (one stat in one device in one time).

* remove gatherDynamicData(MultipartType multipartType) method

Change-Id: I3078cfe871b28fd11c09b7001f783b8e2cfbaa0d
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

diff --git a/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/statistics/StatisticsContext.java b/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/statistics/StatisticsContext.java
index 224b42cf5a45b65e2014e9760aa7755e14eb8587..a9f818259176b16a0b93bcba3f6c4babd402e68a 100644 (file)
--- a/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/statistics/StatisticsContext.java
+++ b/openflowplugin-api/src/main/java/org/opendaylight/openflowplugin/api/openflow/statistics/StatisticsContext.java
@@ -9,9 +9,7 @@
 package org.opendaylight.openflowplugin.api.openflow.statistics;
 
 import com.google.common.util.concurrent.ListenableFuture;
-import javax.annotation.CheckForNull;
 import org.opendaylight.openflowplugin.api.openflow.device.RequestContextStack;
-import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.MultipartType;
 
 /**
  * Created by Martin Bobak <mbobak@cisco.com> on 27.2.2015.
@@ -20,6 +18,4 @@ public interface StatisticsContext extends RequestContextStack, AutoCloseable {
 
     ListenableFuture<Boolean> gatherDynamicData();
 
-    ListenableFuture<Boolean> gatherDynamicData(@CheckForNull MultipartType multipartType);
-
 }

diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java
index 6458956ff22025f9fbb457af85975671e1d73973..8b5848c4a1dfe3eb890ae3113289f361df681aba 100644 (file)
--- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java
+++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/statistics/StatisticsContextImpl.java
@@ -88,16 +88,6 @@ public class StatisticsContextImpl implements StatisticsContext {
         return settableStatResultFuture;
     }
 
-    @Override
-    public ListenableFuture<Boolean> gatherDynamicData(final MultipartType multipartType) {
-        Preconditions.checkArgument(multipartType != null);
-        final ListenableFuture<Boolean> resultingFuture = deviceConnectionCheck();
-        if (resultingFuture != null) {
-            return resultingFuture;
-        }
-        return choiseStat(multipartType);
-    }
-
     private ListenableFuture<Boolean> choiseStat(final MultipartType multipartType) {
         switch (multipartType) {
             case OFPMPFLOW: