Fix BindingDOMOperationProviderServiceAdapter

This class did not have proper supressions and missing @Override
annotations.

Change-Id: I4850593c95527679462284a61f4d8e036fc50e55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding2/mdsal-binding2-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/javav2/dom/adapter/impl/operation/BindingDOMOperationProviderServiceAdapter.java b/binding2/mdsal-binding2-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/javav2/dom/adapter/impl/operation/BindingDOMOperationProviderServiceAdapter.java
index 52f4b07e7e0bc28cf8274e611786717b006ca114..f80087271ec821d489f63097c18a69d5b0526206 100644 (file)
--- a/binding2/mdsal-binding2-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/javav2/dom/adapter/impl/operation/BindingDOMOperationProviderServiceAdapter.java
+++ b/binding2/mdsal-binding2-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/javav2/dom/adapter/impl/operation/BindingDOMOperationProviderServiceAdapter.java
@@ -147,12 +147,12 @@ public class BindingDOMOperationProviderServiceAdapter implements RpcActionProvi
 
         public static final class RpcAdapter extends AbstractImplAdapter<Rpc> implements DOMRpcImplementation {
 
-            RpcAdapter(BindingNormalizedNodeCodecRegistry codec, Class<? extends Operation> clazz,
-                    Rpc<?, ?> delegate) {
+            RpcAdapter(final BindingNormalizedNodeCodecRegistry codec, final Class<? extends Operation> clazz,
+                    final Rpc<?, ?> delegate) {
                 super(codec, clazz, delegate);
             }
 
-            @SuppressWarnings("checkstyle:illegalCatch, unchecked")
+            @SuppressWarnings("unchecked")
             @Nonnull
             @Override
             public FluentFuture<DOMRpcResult> invokeRpc(@Nonnull final DOMRpcIdentifier rpc,
@@ -161,11 +161,13 @@ public class BindingDOMOperationProviderServiceAdapter implements RpcActionProvi
                 final SettableFuture<RpcResult<?>> bindingResult = SettableFuture.create();
                 CompletableFuture.runAsync(() -> delegate.invoke((Input<?>) bindingInput,
                     new RpcCallback<Output<?>>() {
-                        public void onSuccess(Output<?> output) {
+                        @Override
+                        public void onSuccess(final Output<?> output) {
                             bindingResult.set(RpcResultBuilder.success(output).build());
                         }
 
-                        public void onFailure(Throwable error) {
+                        @Override
+                        public void onFailure(final Throwable error) {
                             bindingResult.set(RpcResultBuilder.failed().withError(ErrorType.APPLICATION,
                                 error.getMessage(), error).build());
                         }
@@ -178,25 +180,28 @@ public class BindingDOMOperationProviderServiceAdapter implements RpcActionProvi
         public static final class ActionAdapter extends AbstractImplAdapter<Action>
                 implements DOMActionImplementation {
 
-            ActionAdapter(BindingNormalizedNodeCodecRegistry codec, Class<? extends Operation> clazz,
-                    Action<?, ?, ?, ?> delegate) {
+            ActionAdapter(final BindingNormalizedNodeCodecRegistry codec, final Class<? extends Operation> clazz,
+                    final Action<?, ?, ?, ?> delegate) {
                 super(codec, clazz, delegate);
             }
 
-            @SuppressWarnings("checkstyle:illegalCatch, unchecked")
+            @Override
+            @SuppressWarnings("unchecked")
             @Nonnull
-            public FluentFuture<? extends DOMActionResult> invokeAction(SchemaPath type, DOMDataTreeIdentifier path,
-                    ContainerNode input) {
+            public FluentFuture<? extends DOMActionResult> invokeAction(final SchemaPath type,
+                    final DOMDataTreeIdentifier path, final ContainerNode input) {
                 final TreeNode bindingInput = input != null ? deserialize(type, input) : null;
                 final SettableFuture<RpcResult<?>> bindingResult = SettableFuture.create();
                 CompletableFuture.runAsync(() -> delegate.invoke((Input<?>) bindingInput,
                     codec.fromYangInstanceIdentifier(path.getRootIdentifier()),
                     new RpcCallback<Output<?>>() {
-                        public void onSuccess(Output<?> output) {
+                        @Override
+                        public void onSuccess(final Output<?> output) {
                             bindingResult.set(RpcResultBuilder.success(output).build());
                         }
 
-                        public void onFailure(Throwable error) {
+                        @Override
+                        public void onFailure(final Throwable error) {
                             bindingResult.set(RpcResultBuilder.failed().withError(ErrorType.APPLICATION,
                                 error.getMessage(), error).build());
                         }