Use checkState() in ModuleInfoBackedContext 10/84410/1
authorRobert Varga <robert.varga@pantheon.tech>
Tue, 23 Jul 2019 12:03:43 +0000 (14:03 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Fri, 13 Sep 2019 15:49:30 +0000 (17:49 +0200)
This simplifies the code a bit, by performing a checkState()
instead of explicit if/throw.

Change-Id: I1479c664a0f2c68585648df7ef9f3275aed16329
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f69090cba3c0a62733963d433e70d9c111a722c8)

binding/mdsal-binding-generator-impl/src/main/java/org/opendaylight/mdsal/binding/generator/impl/ModuleInfoBackedContext.java

index c2f17402c274fd5e9406647c82c67bf24768ab42..742f3661c3c7dc66df7424c7076013eb4c05c58d 100644 (file)
@@ -7,6 +7,8 @@
  */
 package org.opendaylight.mdsal.binding.generator.impl;
 
+import static com.google.common.base.Preconditions.checkState;
+
 import com.google.common.annotations.Beta;
 import com.google.common.cache.CacheBuilder;
 import com.google.common.cache.CacheLoader;
@@ -90,11 +92,8 @@ public final class ModuleInfoBackedContext extends GeneratedClassLoadingStrategy
     @Override
     public SchemaContext getSchemaContext() {
         final Optional<SchemaContext> contextOptional = tryToCreateSchemaContext();
-        if (contextOptional.isPresent()) {
-            return contextOptional.get();
-
-        }
-        throw new IllegalStateException("Unable to recreate SchemaContext, error while parsing");
+        checkState(contextOptional.isPresent(), "Unable to recreate SchemaContext, error while parsing");
+        return contextOptional.get();
     }
 
     @Override