Revert "Relax identity statement argument checks"

This reverts commit ea997a6251751745bb5553c8540313dda7fc4106.

Change-Id: I582b8a577f433c82a95944f819088e69936cde28
JIRA: YANGTOOLS-867
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/identity/AbstractIdentityStatementSupport.java b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/identity/AbstractIdentityStatementSupport.java
index 47677bb0bc4db3476be335db125b153c21429ae0..d4499bd610ef0b2aa20c37b566b7c57570b188a9 100644 (file)
--- a/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/identity/AbstractIdentityStatementSupport.java
+++ b/yang/yang-parser-rfc7950/src/main/java/org/opendaylight/yangtools/yang/parser/rfc7950/stmt/identity/AbstractIdentityStatementSupport.java
@@ -15,37 +15,17 @@ import org.opendaylight.yangtools.yang.parser.spi.IdentityNamespace;
 import org.opendaylight.yangtools.yang.parser.spi.meta.AbstractQNameStatementSupport;
 import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext;
 import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils;
-import org.opendaylight.yangtools.yang.parser.spi.source.SourceException;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 abstract class AbstractIdentityStatementSupport
         extends AbstractQNameStatementSupport<IdentityStatement, EffectiveStatement<QName, IdentityStatement>> {
-    private static final Logger LOG = LoggerFactory.getLogger(AbstractIdentityStatementSupport.class);
 
     AbstractIdentityStatementSupport() {
         super(YangStmtMapping.IDENTITY);
     }
 
     @Override
-    @SuppressWarnings({ "checkstyle:illegalCatch", "checkstyle:avoidHidingCauseException" })
     public final QName parseArgumentValue(final StmtContext<?, ?, ?> ctx, final String value) {
-        try {
-            return StmtContextUtils.parseIdentifier(ctx, value);
-        } catch (SourceException e) {
-            // FIXME: YANGTOOLS-867: remove this workaround
-            final QName ret;
-            try {
-                ret = StmtContextUtils.qnameFromArgument(ctx, value);
-            } catch (RuntimeException re) {
-                // Lenient parsing failed, report the original exception
-                LOG.debug("Lenient identity parsing failed", re);
-                throw e;
-            }
-
-            LOG.warn("Worked around illegal identity argument '{}' using lenient parsing", value, e);
-            return ret;
-        }
+        return StmtContextUtils.parseIdentifier(ctx, value);
     }
 
     @Override