Fix preparing result of action 17/79417/2
authorAnna Bencurova <Anna.Bencurova@pantheon.tech>
Thu, 10 Jan 2019 14:21:17 +0000 (15:21 +0100)
committerAnna Bencurova <anna.bencurova@pantheon.tech>
Fri, 11 Jan 2019 11:25:40 +0000 (11:25 +0000)
NullPointerException was thrown when action with no output
was defined and used and OK reply returned.

Change-Id: I2bcf846c501a650d754c943d2e1dc69e73a8dd37
JIRA: NETCONF-567
Signed-off-by: Anna Bencurova <Anna.Bencurova@pantheon.tech>
netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/schema/mapping/NetconfMessageTransformer.java

index 2bd1ce4b4afb594d18b0158d92bd997596b890f3..6bad890cd9ac0b6c661283239f6200373c692d87 100644 (file)
@@ -317,7 +317,11 @@ public class NetconfMessageTransformer implements MessageTransformer<NetconfMess
         Preconditions.checkNotNull(actionDefinition, "Action does not exist: %s", action);
         ContainerNode normalizedNode = (ContainerNode) parseResult(message, actionDefinition);
 
-        return new SimpleDOMActionResult(normalizedNode, Collections.<RpcError>emptyList());
+        if (normalizedNode == null) {
+            return new SimpleDOMActionResult(Collections.<RpcError>emptyList());
+        } else {
+            return new SimpleDOMActionResult(normalizedNode, Collections.<RpcError>emptyList());
+        }
     }
 
     private NormalizedNode<?, ?> parseResult(final NetconfMessage message,