Minor Logging issues and removing an annoying error false positive message

Change-Id: I0439972846bd69e96555e6e8cc97c4dc226bc3d1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>

diff --git a/neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/OF10ProviderManager.java b/neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/OF10ProviderManager.java
index 75297c826a44345168f4f95bbdde45c595f8d565..83d34e02ef577ba3bbb0bee7522185992f442b9a 100644 (file)
--- a/neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/OF10ProviderManager.java
+++ b/neutron/src/main/java/org/opendaylight/ovsdb/neutron/provider/OF10ProviderManager.java
@@ -132,7 +132,7 @@ class OF10ProviderManager extends ProviderNetworkManager {
             IForwardingRulesManager frm = (IForwardingRulesManager) ServiceHelper.getInstance(
                     IForwardingRulesManager.class, "default", this);
             if (frm.getStaticFlow(flowName, ofNode) != null) {
-                logger.debug("Remove Egress Flow exists : {} for Flow {} on {} / {}", flowName, ofNode, node);
+                logger.debug("Remote Egress Flow exists : {} for Flow {} on {} / {}", flowName, ofNode, node);
                 return;
             }
             FlowConfig flow = new FlowConfig();

diff --git a/ovsdb/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java b/ovsdb/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java
index a1345883d2ea49c91f5dc8f0ea99d0b57411aa23..f32060feeb25b8ed2ba7a369585e145b711c84a3 100644 (file)
--- a/ovsdb/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java
+++ b/ovsdb/src/main/java/org/opendaylight/ovsdb/lib/jsonrpc/JsonRpcEndpoint.java
@@ -109,6 +109,7 @@ public class JsonRpcEndpoint {
 
     public void processResult(JsonNode response) throws NoSuchMethodException {
 
+        logger.trace("Response : {}", response.toString());
         CallContext returnCtxt = methodContext.get(response.get("id").asText());
         if (returnCtxt == null) return;
 
@@ -119,11 +120,11 @@ public class JsonRpcEndpoint {
             JavaType javaType =  TypeFactory.defaultInstance().constructType (retType.getType());
 
             JsonNode result = response.get("result");
-            logger.trace("Response : {}", result.toString());
+            logger.trace("Result : {}", result.toString());
 
             Object result1 = objectMapper.convertValue(result, javaType);
             JsonNode error = response.get("error");
-            if (error != null) {
+            if (error != null && !error.isNull()) {
                 logger.error("Error : {}", error.toString());
             }
 

diff --git a/ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/ConnectionService.java b/ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/ConnectionService.java
index 729686e326c725c3041d6fbc11d5479feffdd8ca..90c04de241feda2ada4df2d0b0ad437434433700 100755 (executable)
--- a/ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/ConnectionService.java
+++ b/ovsdb/src/main/java/org/opendaylight/ovsdb/plugin/ConnectionService.java
@@ -272,7 +272,7 @@ public class ConnectionService implements IPluginInConnectionService, IConnectio
     }
 
     public void channelClosed(Node node) throws Exception {
-        logger.error("Connection to Node : {} closed", node);
+        logger.info("Connection to Node : {} closed", node);
         inventoryServiceInternal.removeNode(node);
     }