Clean up NonCachingCodec

Use requireNonNull() and make the codec final, as it is only used as-is.

Change-Id: I59c25c4bcf795e193ac7af764cee9fa868c8435f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodec.java b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodec.java
index 1b3504d108a906ba1859cb1ab5c9780320e1b273..187ca066a33d0d220dca4a90bf743a5720fb6648 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodec.java
+++ b/binding/mdsal-binding-dom-codec/src/main/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodec.java
@@ -7,17 +7,18 @@
  */
 package org.opendaylight.mdsal.binding.dom.codec.impl;
 
+import static java.util.Objects.requireNonNull;
+
 import org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeCachingCodec;
 import org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeCodec;
 import org.opendaylight.yangtools.yang.binding.DataObject;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 
-class NonCachingCodec<D extends DataObject> implements BindingNormalizedNodeCachingCodec<D> {
-
+final class NonCachingCodec<D extends DataObject> implements BindingNormalizedNodeCachingCodec<D> {
     private final BindingNormalizedNodeCodec<D> delegate;
 
-    protected NonCachingCodec(final BindingNormalizedNodeCodec<D> delegate) {
-        this.delegate = delegate;
+    NonCachingCodec(final BindingNormalizedNodeCodec<D> delegate) {
+        this.delegate = requireNonNull(delegate);
     }
 
     @Override
@@ -34,5 +35,4 @@ class NonCachingCodec<D extends DataObject> implements BindingNormalizedNodeCach
     public void close() {
         // NOOP
     }
-
 }

diff --git a/binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodecTest.java b/binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodecTest.java
index 8cf69a473ceefad3a56b918d8303e1dffe67383d..3a4017a50cc3f41effe09b7a00d59123e2bafb94 100644 (file)
--- a/binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodecTest.java
+++ b/binding/mdsal-binding-dom-codec/src/test/java/org/opendaylight/mdsal/binding/dom/codec/impl/NonCachingCodecTest.java
@@ -36,7 +36,7 @@ public class NonCachingCodecTest {
 
     @Test
     public void basicTest() {
-        try (NonCachingCodec<DataObject> nonCachingCodec = new NonCachingCodec<>(codec)) {
+        try (var nonCachingCodec = new NonCachingCodec<>(codec)) {
             nonCachingCodec.serialize(object);
             verify(codec).serialize(object);
             nonCachingCodec.deserialize(node);