Clarify ShiroWebEnvironmentLoaderListener FIXMEs 96/101696/2
authorRobert Varga <robert.varga@pantheon.tech>
Sun, 3 Jul 2022 00:35:32 +0000 (02:35 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Sun, 3 Jul 2022 01:24:45 +0000 (03:24 +0200)
The two fixmes deal with configuration injection. Update the fixme.

Change-Id: Ifa0a905af81012183333a48b7b6bcf3903325012
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
aaa-shiro/impl/src/main/java/org/opendaylight/aaa/shiro/web/env/ShiroWebEnvironmentLoaderListener.java

index 81a0061d2c3056e3c52dcc5c60cb068fde242a43..34ede37f7a23643d4638500b7084d8f2a946442d 100644 (file)
@@ -39,7 +39,8 @@ public final class ShiroWebEnvironmentLoaderListener extends EnvironmentLoaderLi
     private final PasswordHashService passwordHashService;
 
     // FIXME: @Inject for CDI, except we have ShiroConfiguration injected
-    // FIXME: @Activate for OSGi @Component, except we have ShiroConfiguration which needs to come from somewhere
+    // FIXME: @Activate for OSGi @Component
+    // Both of these have problem with how do we inject ShiroConfiguration?
     public ShiroWebEnvironmentLoaderListener(final ShiroConfiguration shiroConfiguration, final DataBroker dataBroker,
                                              final ICertificateManager certificateManager,
                                              final AuthenticationService authenticationService,