Cleanup LearnCodec

This is just some minor house keeping.

Change-Id: I35a176b847885cb7f96ea52ef0f06fe9ada48bea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/extension/openflowjava-extension-nicira/src/main/java/org/opendaylight/openflowjava/nx/codec/action/LearnCodec.java b/extension/openflowjava-extension-nicira/src/main/java/org/opendaylight/openflowjava/nx/codec/action/LearnCodec.java
index fe29a2297eee8ecdeaebb7710f8e5fc883ee57c6..241b1549bd6da2cb52362d09b584b30fd4c59e87 100644 (file)
--- a/extension/openflowjava-extension-nicira/src/main/java/org/opendaylight/openflowjava/nx/codec/action/LearnCodec.java
+++ b/extension/openflowjava-extension-nicira/src/main/java/org/opendaylight/openflowjava/nx/codec/action/LearnCodec.java
@@ -35,8 +35,8 @@ public class LearnCodec extends AbstractActionCodec {
 
     @Override
     public void serialize(final Action input, final ByteBuf outBuffer) {
-        ActionLearn action = (ActionLearn) input.getActionChoice();
-        int length = LearnCodecUtil.calcLength(action);
+        final ActionLearn action = (ActionLearn) input.getActionChoice();
+        final int length = LearnCodecUtil.calcLength(action);
         int lengthMod = length % MUL_LENGTH;
         if (lengthMod != 0) {
             lengthMod = MUL_LENGTH - lengthMod;
@@ -50,28 +50,25 @@ public class LearnCodec extends AbstractActionCodec {
         if (lengthMod != 0) {
             outBuffer.writeZero(lengthMod);
         }
-
     }
 
     @Override
     public Action deserialize(final ByteBuf message) {
-        ActionBuilder actionBuilder = new ActionBuilder();
-        actionBuilder.setExperimenterId(new ExperimenterId(NiciraConstants.NX_VENDOR_ID));
 
         short length = LearnCodecUtil.deserializeHeader(message);
-        final ActionLearnBuilder actionLearnBuilder = new ActionLearnBuilder();
 
-        NxActionLearnBuilder nxActionLearnBuilder = new NxActionLearnBuilder();
+        final var nxActionLearnBuilder = new NxActionLearnBuilder();
         LearnCodecUtil.deserializeLearnHeader(message, nxActionLearnBuilder);
 
         length -= LearnCodecUtil.HEADER_LENGTH;
 
         LearnCodecUtil.buildFlowModSpecs(nxActionLearnBuilder, message, length);
 
-        actionLearnBuilder.setNxActionLearn(nxActionLearnBuilder.build());
-
-        actionBuilder.setActionChoice(actionLearnBuilder.build());
-
-        return actionBuilder.build();
+        return new ActionBuilder()
+            .setExperimenterId(new ExperimenterId(NiciraConstants.NX_VENDOR_ID))
+            .setActionChoice(new ActionLearnBuilder()
+                .setNxActionLearn(nxActionLearnBuilder.build())
+                .build())
+            .build();
     }
 }