Do not instantiate Shorts 86/19586/2
authorRobert Varga <rovarga@cisco.com>
Sun, 22 Mar 2015 22:58:34 +0000 (23:58 +0100)
committerLori Jakab <lojakab@cisco.com>
Fri, 15 May 2015 06:08:05 +0000 (06:08 +0000)
Speed up comparison by not instantiating an explicit Short instace, but
use autoboxing, which should result in better performance.

Change-Id: I260bf69935c2712162cb42404806e664f41a0cff
Signed-off-by: Robert Varga <rovarga@cisco.com>
mappingservice/api/src/main/java/org/opendaylight/lispflowmapping/type/lisp/LocatorRecord.java

index 66274bb35f8c9c77037de5d94e0d21799615c4ca..57abd4f5eb23d238a150596bc97dfc7aa57fde92 100644 (file)
@@ -157,7 +157,7 @@ public class LocatorRecord {
         if (priority != 0) {
              boolean isValidRange = false;
              List<Range<Short>> rangeConstraints = new ArrayList<>();
-             rangeConstraints.add(Range.closed(new Short("0"), new Short("255")));
+             rangeConstraints.add(Range.closed((short)0, (short)255));
              for (Range<Short> r : rangeConstraints) {
                  if (r.contains(priority)) {
                  isValidRange = true;
@@ -188,7 +188,7 @@ public class LocatorRecord {
        if (value != 0) {
             boolean isValidRange = false;
             List<Range<Short>> rangeConstraints = new ArrayList<>();
-            rangeConstraints.add(Range.closed(new Short("0"), new Short("255")));
+            rangeConstraints.add(Range.closed((short) 0, (short)255));
             for (Range<Short> r : rangeConstraints) {
                 if (r.contains(value)) {
                 isValidRange = true;