* Update docs/submodules/openflowplugin from branch 'master'
to
a862a00411d1eadd7db500711723f9bc273580db
- OPNFLWPLUG-984: always use ingress node for link discovery
Using the LLDP destination (packet-in ingress) guarantees that the
receiving controller is the owner of the device. Relying on the LLDP
source can cause a scenario where the LLDP packet never appears in the
entity-owner of the source device.
Change-Id: I8ad4171cdae395d260b754b95e5d9b75138fb79b
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
(cherry picked from commit
36722d99c3a17bb23d4299a906591f11a9847f03)
- Enable findbugs in parent pom
Change-Id: Ib9c64da593973b23c0bf2d3bf499adc95e16df54
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in test-provider and drop-test-karaf
- Field only ever set to null
- int value cast to float and then passed to Math.round
- Possible null pointer dereference in method on exception path
- Non-virtual method call passes null for non-null parameter
- Comparison of String parameter using == or !=
- Should be a static inner class
- Private method is never called
- int value cast to float and then passed to Math.round
- Unread field
- Unread field: should this field be static?
- Unused field
- Dead store to local variable
- Private method is never called
- Method uses the same code for two switch clauses
- Write to static field from instance method
- Field not initialized in constructor but dereferenced without null check
Change-Id: Ib09380d626ab9162c4308810fae9db90522269cf
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in openflowplugin-impl
- Method ignores exceptional return value
- Check for sign of bitwise operation
- Consider using Locale parameterized version of invoked method
- Reliance on default encoding
- Synchronization performed on util.concurrent instance
- Unchecked/unconfirmed cast
- Unchecked/unconfirmed cast of return value from method
- Return value of method without side effect is ignored
- Dead store to local variable
- Method uses the same code for two branches
- Load of known null value
- Parameter must be non-null but is marked as nullable
- Field not initialized in constructor but dereferenced without null check
Change-Id: I92e00a5772038111d1ab8d9f53d52c43e3f4909d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in openflowplugin
- Comparison of String parameter using == or !=
- Comparator doesn't implement Serializable
- Field is a mutable collection
- Incorrect lazy initialization of static field
- Inefficient use of keySet iterator instead of entrySet iterator
- Private method is never called
- Unsigned right shift cast to short/byte
- Class is final but declares protected field
- Consider returning a zero length array rather than null
Change-Id: I714bd4005a33a772b0b76b0c0f89f28b8517cd06
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in extensions
- Dead store to local variable
- Unchecked/unconfirmed cast
- Field not initialized in constructor but dereferenced without null check
- Method ignores return value
- Private method is never called
Change-Id: I7a3fe1700439b456cb7dce6d84f63a9840fd68a7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in samples
- Inconsistent synchronization
- Using notify() rather than notifyAll()
- Method ignores return value
- Read of unwritten field
- Field not initialized in constructor but dereferenced without null check
Change-Id: I12e8ae3ab25cc41ba05b99e9e4c85f2606a2814d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in liblldp
- Method call passes null for non-null parameter
- Class defines clone() but doesn't implement Cloneable
- Clone method may return null
- clone method does not call super.clone()
- equals() method does not check for null argument
- Reliance on default encoding
- May expose internal representation by returning reference to mutable object
- Field is a mutable collection which should be package protected - malicious code vulnerability
- Field should be package protected - malicious code vulnerability
- Inefficient use of keySet iterator instead of entrySet iterator
- Boxing/unboxing to parse a primitive - use parseXXX method
- Redundant nullcheck of value known to be non-null
Change-Id: I6d551d31d618a1adfc877ac59f29d02727201df6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in applications
- Method ignores return value
- Consider using Locale parameterized version of invoked method
- Reliance on default encoding
- Write to static field from instance method
- Inefficient use of keySet iterator instead of entrySet iterator
- Dead store to local variable
- Consider returning a zero length array rather than null
- Consider using Locale parameterized version of invoked method
- Boxing/unboxing to parse a primitive - use parseXXX method
- Unread field
- Dead store to local variable
- Non-transient non-serializable instance field in serializable class
- Parameter must be non-null but is marked as nullable
- Field not initialized in constructor but dereferenced without null check
- Nullcheck of value previously dereferenced
- Redundant nullcheck of value known to be non-null
Change-Id: I1887f775f61fb8e3e6989113edf7faf4f9b06b34
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
- Fix findbugs violations in openflowjava
- Invocation of toString on an array
- Check for sign of bitwise operation:
Example: ((event.detail & SWT.SELECTED) > 0)
Using bit arithmetic and then comparing with the greater than operator
can lead to unexpected results (of course depending on the value of
SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
for a bug. Even when SWT.SELECTED is not negative, it seems good practice
to use '!= 0' instead of '> 0'
- Reliance on default encoding - performs a byte to String (or String to byte)
conversion, and will assume that the default platform encoding is suitable.
- Primitive value is boxed then unboxed to perform primitive coercion
- Unread field
- Result of integer multiplication cast to long - possible overflow
- Dead store to local variable - assigns a value to a local variable, but
the value is not read or used in any subsequent instruction.
- Method uses the same code for two switch clauses
- Load of known null value
- Consider returning a zero length array rather than null
- Redundant nullcheck of value known to be non-null
- Field not initialized in constructor but dereferenced without null check
- Non-transient non-serializable instance field in serializable class
- Class implements same interface as superclass
Change-Id: I28b533c9f9805de539e35b729c5163fd22e75354
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>