Fix mdsal-binding-dom-adapter checkstyle

Upgraded checkstyle is finding a few issues, fix them up.

Change-Id: Ifdafb339f112749b891ef288420e28af124b306e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 77e364296fc00da513a7eb651ca90872c29d50c2)

diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMDataTreeChangeServiceAdapterTest.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMDataTreeChangeServiceAdapterTest.java
index d060aef6755a2e0df975caba8a53d61b97131489..7e246b73721e8bb4b234a67da8ed800771d559b9 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMDataTreeChangeServiceAdapterTest.java
+++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMDataTreeChangeServiceAdapterTest.java
@@ -93,15 +93,17 @@ public class BindingDOMDataTreeChangeServiceAdapterTest {
                 && yangID.equals(arg.getRootIdentifier()));
     }
 
-    private static class TestClusteredDataTreeChangeListener implements ClusteredDataTreeChangeListener<Top> {
+    private static final class TestClusteredDataTreeChangeListener implements ClusteredDataTreeChangeListener<Top> {
         @Override
         public void onDataTreeChanged(final Collection<DataTreeModification<Top>> changes) {
+            // No-op
         }
     }
 
-    private static class TestDataTreeChangeListener implements DataTreeChangeListener<Top> {
+    private static final class TestDataTreeChangeListener implements DataTreeChangeListener<Top> {
         @Override
         public void onDataTreeChanged(final Collection<DataTreeModification<Top>> changes) {
+            // No-op
         }
     }
 }

diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcIntegrationTest.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcIntegrationTest.java
index 2c370d5d221bb469f939b338798fedbd22eb0ec3..e09492b41cb3ae21c11d1721170b72e3cc499b8f 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcIntegrationTest.java
+++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcIntegrationTest.java
@@ -161,9 +161,9 @@ public class BindingDOMRpcIntegrationTest {
         return testContext.getCodec().currentSerializer().toNormalizedNodeRpcData(from);
     }
 
-    private static class OpendaylightKnockKnockRpcServiceImpl implements OpendaylightKnockKnockRpcService {
-        private ListenableFuture<RpcResult<KnockKnockOutput>> knockKnockResult;
+    private static final class OpendaylightKnockKnockRpcServiceImpl implements OpendaylightKnockKnockRpcService {
         private final Multimap<InstanceIdentifier<?>, KnockKnockInput> receivedKnocks = HashMultimap.create();
+        private ListenableFuture<RpcResult<KnockKnockOutput>> knockKnockResult;
         private ObjectRegistration<OpendaylightKnockKnockRpcServiceImpl> registration;
 
         OpendaylightKnockKnockRpcServiceImpl setKnockKnockResult(

diff --git a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/Mdsal500Test.java b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/Mdsal500Test.java
index bc54e670eaeb1bcae19f415df417f25feb2aa716..c3d4c2234d50e17abb6c458029bb223df5431217 100644 (file)
--- a/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/Mdsal500Test.java
+++ b/binding/mdsal-binding-dom-adapter/src/test/java/org/opendaylight/mdsal/binding/dom/adapter/Mdsal500Test.java
@@ -141,9 +141,9 @@ public class Mdsal500Test {
         return testContext.getCodec().currentSerializer().toNormalizedNodeRpcData(from);
     }
 
-    private static class Mdsal500ServiceImpl implements Mdsal500Service {
-        private ListenableFuture<RpcResult<SwitchOutput>> switchResult;
+    private static final class Mdsal500ServiceImpl implements Mdsal500Service {
         private final Multimap<String, SwitchInput> receivedSwitch = HashMultimap.create();
+        private ListenableFuture<RpcResult<SwitchOutput>> switchResult;
 
         Mdsal500ServiceImpl setSwitchResult(final ListenableFuture<RpcResult<SwitchOutput>> switchOutput) {
             switchResult = switchOutput;
@@ -167,5 +167,4 @@ public class Mdsal500Test {
             return switchResult;
         }
     }
-
 }