Mark classes/fields as final

Making sure that we follow coding patterns, will actually improve what
the JIT can do for us.

Change-Id: I125a6c058ea603d2e9545c42ff8ab969372c371d
Signed-off-by: Robert Varga <rovarga@cisco.com>

diff --git a/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/EnumerationCodec.java b/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/EnumerationCodec.java
index e5788fe11c8eb504616d5253c91952cad641eaf3..a35a5621a2d904b49fa2e861c9b4a5bfba164769 100644 (file)
--- a/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/EnumerationCodec.java
+++ b/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/EnumerationCodec.java
@@ -17,16 +17,15 @@ import org.opendaylight.yangtools.yang.binding.BindingMapping;
 import org.opendaylight.yangtools.yang.model.api.type.EnumTypeDefinition;
 import org.opendaylight.yangtools.yang.model.api.type.EnumTypeDefinition.EnumPair;
 
-class EnumerationCodec extends ReflectionBasedCodec implements SchemaUnawareCodec {
+final class EnumerationCodec extends ReflectionBasedCodec implements SchemaUnawareCodec {
 
-    ImmutableBiMap<String, Enum<?>> yangValueToBinding;
+    private final ImmutableBiMap<String, Enum<?>> yangValueToBinding;
 
     public EnumerationCodec(final Class<? extends Enum<?>> enumeration, final Map<String, Enum<?>> schema) {
         super(enumeration);
         yangValueToBinding = ImmutableBiMap.copyOf(schema);
     }
 
-
     static Callable<EnumerationCodec> loader(final Class<?> returnType,
             final EnumTypeDefinition enumSchema) {
         Preconditions.checkArgument(Enum.class.isAssignableFrom(returnType));
@@ -51,7 +50,6 @@ class EnumerationCodec extends ReflectionBasedCodec implements SchemaUnawareCode
         };
     }
 
-
     @Override
     public Object deserialize(final Object input) {
         Enum<?> value = yangValueToBinding.get(input);

diff --git a/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/UnionTypeCodec.java b/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/UnionTypeCodec.java
index ed8a2bc80ae37a632f03bb3024d5d129ed202c98..00702f07296d5e92d886d9020a746f9d67e3bd3a 100644 (file)
--- a/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/UnionTypeCodec.java
+++ b/code-generator/binding-data-codec/src/main/java/org/opendaylight/yangtools/binding/data/codec/impl/UnionTypeCodec.java
@@ -8,14 +8,12 @@
 package org.opendaylight.yangtools.binding.data.codec.impl;
 
 import com.google.common.collect.ImmutableSet;
-
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.HashSet;
 import java.util.Set;
 import java.util.concurrent.Callable;
-
 import org.opendaylight.yangtools.concepts.Codec;
 import org.opendaylight.yangtools.yang.binding.BindingMapping;
 import org.opendaylight.yangtools.yang.model.api.TypeDefinition;
@@ -24,8 +22,8 @@ import org.opendaylight.yangtools.yang.model.util.UnionType;
 
 final class UnionTypeCodec extends ReflectionBasedCodec {
 
-    private Constructor<?> charConstructor;
-    private ImmutableSet<UnionValueOptionContext> typeCodecs;
+    private final ImmutableSet<UnionValueOptionContext> typeCodecs;
+    private final Constructor<?> charConstructor;
 
     private UnionTypeCodec(final Class<?> unionCls,final Set<UnionValueOptionContext> codecs) {
         super(unionCls);
@@ -37,7 +35,7 @@ final class UnionTypeCodec extends ReflectionBasedCodec {
         }
     }
 
-    static final Callable<UnionTypeCodec> loader(final Class<?> unionCls, final UnionTypeDefinition unionType) {
+    static Callable<UnionTypeCodec> loader(final Class<?> unionCls, final UnionTypeDefinition unionType) {
         return new Callable<UnionTypeCodec>() {
             @Override
             public UnionTypeCodec call() throws NoSuchMethodException, SecurityException {
@@ -54,7 +52,7 @@ final class UnionTypeCodec extends ReflectionBasedCodec {
         };
     }
 
-    private static Codec<Object, Object> getCodecForType(Class valueType, TypeDefinition subtype) {
+    private static Codec<Object, Object> getCodecForType(final Class<?> valueType, final TypeDefinition<?> subtype) {
         if (subtype.getBaseType() instanceof UnionType) {
             try {
                 return UnionTypeCodec.loader(valueType, (UnionType) subtype.getBaseType()).call();
@@ -77,10 +75,10 @@ final class UnionTypeCodec extends ReflectionBasedCodec {
 
     @Override
     public Object serialize(final Object input) {
-        if(input != null) {
-            for(UnionValueOptionContext valCtx : typeCodecs) {
+        if (input != null) {
+            for (UnionValueOptionContext valCtx : typeCodecs) {
                 Object domValue = valCtx.serialize(input);
-                if(domValue != null) {
+                if (domValue != null) {
                     return domValue;
                 }
             }