NETCONF-526 : edit-config payload default-operation needs to be set to default-value 97/70997/1
authorBalaji Varadaraju <bvaradar@luminanetworks.com>
Wed, 14 Mar 2018 06:40:46 +0000 (01:40 -0500)
committerAtul Gosain <agosain@luminanetworks.com>
Mon, 16 Apr 2018 22:18:18 +0000 (22:18 +0000)
For the PUT/POST calls right now default-operation tag in the edit-config is set to
"none". As per RFC with this value devices can reject a config operation when
elements present in the request whose structure is not already present in the tree.
For example a nested parent-child structure where parent structure does not yet exist
yet in the tree may result in an error based on implementation.
We should  leave this field out ( which will default to merge) and let the device make
the right decision.

Change-Id: I8b85ef072785381897a19724dc94003b8f315bd4
Signed-off-by: Balaji Varadaraju <bvaradar@luminanetworks.com>
(cherry picked from commit 011fbb4e78b64748c4be16c43b3deb46a5c3b23c)

netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/AbstractWriteTx.java

index 14926d99f20d0e45b494c572970ecd04ab924b13..9393860b39c3b2241a36ef3e6808eaf852a52dae 100644 (file)
@@ -105,7 +105,7 @@ public abstract class AbstractWriteTx implements DOMDataWriteTransaction {
         final DataContainerChild<?, ?> editStructure =
                 netOps.createEditConfigStrcture(Optional.<NormalizedNode<?, ?>>fromNullable(data),
                         Optional.of(ModifyAction.REPLACE), path);
-        editConfig(path, Optional.fromNullable(data), editStructure, Optional.of(ModifyAction.NONE), "put");
+        editConfig(path, Optional.fromNullable(data), editStructure, Optional.<ModifyAction>absent(), "put");
     }
 
     @Override