Iterate over simple array 24/102424/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 22 Sep 2022 09:48:29 +0000 (11:48 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 22 Sep 2022 09:48:29 +0000 (11:48 +0200)
There is no point in using Arrays.asList(), as we end up only iterating
over the list anyway.

Change-Id: I7e0345ea6ae92fc61d8814a0424837c51719612c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
aaa-filterchain/src/main/java/org/opendaylight/aaa/filterchain/configuration/impl/CustomFilterAdapterConfigurationImpl.java

index 0b1ec8a571f5ef9e1a80b8c185aff6817827f01f..0890da97ce2356a2458fad0159a1ba27cf533456 100644 (file)
@@ -12,7 +12,6 @@ import static java.util.Objects.requireNonNull;
 import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.Iterators;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Enumeration;
@@ -256,11 +255,8 @@ public final class CustomFilterAdapterConfigurationImpl implements CustomFilterA
         final String customFilterListValue = configuration.get(CUSTOM_FILTER_LIST_KEY);
         final ImmutableList.Builder<FilterDTO> customFilterListBuilder = ImmutableList.builder();
         if (customFilterListValue != null) {
-            // Creates the list from comma separate values; whitespace is
-            // removed first
-            final List<String> filterClazzNames = Arrays
-                    .asList(customFilterListValue.replaceAll("\\s", "").split(FILTER_DTO_SEPARATOR));
-            for (String filterClazzName : filterClazzNames) {
+            // Creates the list from comma separate values; whitespace is removed first
+            for (String filterClazzName : customFilterListValue.replaceAll("\\s", "").split(FILTER_DTO_SEPARATOR)) {
                 if (!Strings.isNullOrEmpty(filterClazzName)) {
                     final Map<String, String> applicableConfigs = extractPropertiesForFilter(filterClazzName,
                             configuration);