Mark ConntrackConvertor methods static 53/92353/2
authorRobert Varga <robert.varga@pantheon.tech>
Mon, 31 Aug 2020 14:04:13 +0000 (16:04 +0200)
committerRobert Varga <robert.varga@pantheon.tech>
Mon, 7 Sep 2020 08:12:51 +0000 (10:12 +0200)
There are two utility methods which can be static, mark them as
such to improve clarity.

Change-Id: I54620d97a22b69d8808e1f60d32641b87aa6195f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
extension/openflowplugin-extension-nicira/src/main/java/org/opendaylight/openflowplugin/extension/vendor/nicira/convertor/action/ConntrackConvertor.java

index a1a705a473f94622c6436db902938e40381a1037..ff0749399540a78a8784f3d72e9e20e4ad3aff29 100644 (file)
@@ -108,8 +108,8 @@ public class ConntrackConvertor implements
         }
     }
 
-    private List<org.opendaylight.yang.gen.v1.urn.opendaylight.openflowjava.nx.action.rev140421.ofj.nx.action.conntrack
-                                .grouping.nx.action.conntrack.CtActions> getCtAction(final NxConntrack action) {
+    private static List<org.opendaylight.yang.gen.v1.urn.opendaylight.openflowjava.nx.action.rev140421.ofj.nx.action
+                        .conntrack.grouping.nx.action.conntrack.CtActions> getCtAction(final NxConntrack action) {
         if (action.getCtActions() == null) {
             return null;
         }
@@ -162,7 +162,7 @@ public class ConntrackConvertor implements
         return ctActions;
     }
 
-    private List<CtActions> getCtAction(final NxActionConntrack action) {
+    private static List<CtActions> getCtAction(final NxActionConntrack action) {
         if (action.getCtActions() == null) {
             return null;
         }