Simplify LinkstateGraphBuilder.getLinkAttributes()

If have too many if/else statements here and a blind cast. Refactor
checks and use a simple return.

Change-Id: I158914f2e972f5f0265438f51eb287076b436459
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/LinkstateGraphBuilder.java b/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/LinkstateGraphBuilder.java
index eee5fd630a6333951fd03b361bb6d8fb18ffd5e6..f05f4f01015f3237a81f368c77577b96c5098bce 100644 (file)
--- a/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/LinkstateGraphBuilder.java
+++ b/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/LinkstateGraphBuilder.java
@@ -183,19 +183,14 @@ public class LinkstateGraphBuilder extends AbstractTopologyBuilder<LinkstateRout
      * @return Link Attributes
      */
     private static LinkAttributes getLinkAttributes(final Attributes attributes) {
-        final LinkAttributes la;
         final Attributes1 attr = attributes.augmentation(Attributes1.class);
         if (attr != null) {
             final LinkStateAttribute attrType = attr.getLinkStateAttribute();
-            if (attrType != null) {
-                la = ((LinkAttributesCase) attrType).getLinkAttributes();
-            } else {
-                return null;
+            if (attrType instanceof LinkAttributesCase) {
+                return ((LinkAttributesCase) attrType).getLinkAttributes();
             }
-        } else {
-            return null;
         }
-        return la;
+        return null;
     }
 
     /**