Fix checkstyle warnings for impl/datastore package

See also: bug 8607

Change-Id: I7701b8b611648a3c7af90686847ecefd1970bf8a
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>

diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/MultipartWriterProviderFactory.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/MultipartWriterProviderFactory.java
index bc0d817d28b73e2e90288af34513504e3008d518..ba72af1438efc0c822c813b7b09d316c5b35b0b5 100644 (file)
--- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/MultipartWriterProviderFactory.java
+++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/MultipartWriterProviderFactory.java
@@ -27,12 +27,13 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev13
 import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
 
 /**
- * Multipart writer provider factory
+ * Multipart writer provider factory.
  */
 public class MultipartWriterProviderFactory {
 
     /**
-     * Create default #{@link MultipartWriterProvider}
+     * Create default #{@link MultipartWriterProvider}.
+     *
      * @param deviceContext device context
      * @return the statistics writer provider
      */
@@ -44,18 +45,27 @@ public class MultipartWriterProviderFactory {
         provider.register(MultipartType.OFPMPTABLE, new TableStatsMultipartWriter(deviceContext, instanceIdentifier));
         provider.register(MultipartType.OFPMPGROUP, new GroupStatsMultipartWriter(deviceContext, instanceIdentifier));
         provider.register(MultipartType.OFPMPMETER, new MeterStatsMultipartWriter(deviceContext, instanceIdentifier));
-        provider.register(MultipartType.OFPMPPORTSTATS, new PortStatsMultipartWriter(deviceContext, instanceIdentifier, deviceContext.getPrimaryConnectionContext().getFeatures()));
+        provider.register(MultipartType.OFPMPPORTSTATS, new PortStatsMultipartWriter(deviceContext,
+                instanceIdentifier, deviceContext.getPrimaryConnectionContext().getFeatures()));
         provider.register(MultipartType.OFPMPQUEUE, new QueueStatsMultipartWriter(deviceContext, instanceIdentifier));
-        provider.register(MultipartType.OFPMPFLOW, new FlowStatsMultipartWriter(deviceContext, instanceIdentifier, deviceContext, deviceContext.getDeviceInfo().getVersion()));
-        provider.register(MultipartType.OFPMPGROUPDESC, new GroupDescMultipartWriter(deviceContext, instanceIdentifier, deviceContext));
-        provider.register(MultipartType.OFPMPMETERCONFIG, new MeterConfigMultipartWriter(deviceContext, instanceIdentifier, deviceContext));
+        provider.register(MultipartType.OFPMPFLOW, new FlowStatsMultipartWriter(deviceContext, instanceIdentifier,
+                deviceContext, deviceContext.getDeviceInfo().getVersion()));
+        provider.register(MultipartType.OFPMPGROUPDESC, new GroupDescMultipartWriter(deviceContext,
+                instanceIdentifier, deviceContext));
+        provider.register(MultipartType.OFPMPMETERCONFIG, new MeterConfigMultipartWriter(deviceContext,
+                instanceIdentifier, deviceContext));
 
         // Device initialization writers
-        provider.register(MultipartType.OFPMPDESC, new DescMultipartWriter(deviceContext, instanceIdentifier, deviceContext.getPrimaryConnectionContext()));
-        provider.register(MultipartType.OFPMPGROUPFEATURES, new GroupFeaturesMultipartWriter(deviceContext, instanceIdentifier));
-        provider.register(MultipartType.OFPMPMETERFEATURES, new MeterFeaturesMultipartWriter(deviceContext, instanceIdentifier));
-        provider.register(MultipartType.OFPMPTABLEFEATURES, new TableFeaturesMultipartWriter(deviceContext, instanceIdentifier));
-        provider.register(MultipartType.OFPMPPORTDESC, new PortDescMultipartWriter(deviceContext, instanceIdentifier, deviceContext.getPrimaryConnectionContext().getFeatures()));
+        provider.register(MultipartType.OFPMPDESC, new DescMultipartWriter(deviceContext, instanceIdentifier,
+                deviceContext.getPrimaryConnectionContext()));
+        provider.register(MultipartType.OFPMPGROUPFEATURES, new GroupFeaturesMultipartWriter(deviceContext,
+                instanceIdentifier));
+        provider.register(MultipartType.OFPMPMETERFEATURES, new MeterFeaturesMultipartWriter(deviceContext,
+                instanceIdentifier));
+        provider.register(MultipartType.OFPMPTABLEFEATURES, new TableFeaturesMultipartWriter(deviceContext,
+                instanceIdentifier));
+        provider.register(MultipartType.OFPMPPORTDESC, new PortDescMultipartWriter(deviceContext, instanceIdentifier,
+                deviceContext.getPrimaryConnectionContext().getFeatures()));
 
         return provider;
     }

diff --git a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/multipart/AbstractMultipartWriter.java b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/multipart/AbstractMultipartWriter.java
index 28a2d2c390c40f9f882746e0f83764a474b4605a..48e548294cc206555858d74119188a442c56927e 100644 (file)
--- a/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/multipart/AbstractMultipartWriter.java
+++ b/openflowplugin-impl/src/main/java/org/opendaylight/openflowplugin/impl/datastore/multipart/AbstractMultipartWriter.java
@@ -32,6 +32,7 @@ public abstract class AbstractMultipartWriter<T extends DataContainer> {
 
     /**
      * Creates put operation using provided data in underlying transaction chain.
+     *
      * @param path path
      * @param data data
      * @param <O> data type
@@ -47,7 +48,8 @@ public abstract class AbstractMultipartWriter<T extends DataContainer> {
     }
 
     /**
-     * Get instance identifier
+     * Get instance identifier.
+     *
      * @return instance identifier
      */
     protected InstanceIdentifier<Node> getInstanceIdentifier() {
@@ -55,7 +57,8 @@ public abstract class AbstractMultipartWriter<T extends DataContainer> {
     }
 
     /**
-     * Write dataContainer
+     * Write dataContainer.
+     *
      * @param dataContainer dataContainer
      * @param withParents write missing parents if needed (slower)
      * @return true if we have correct dataContainer type
@@ -72,18 +75,19 @@ public abstract class AbstractMultipartWriter<T extends DataContainer> {
     }
 
     /**
-     * Get type of writer
+     * Get type of writer.
+     *
      * @return type of writer
      */
     protected abstract Class<T> getType();
 
     /**
-     * Write statistics
+     * Write statistics.
+     *
      * @param statistics statistics
      * @param withParents write missing parents if needed (slower)
      */
-    protected abstract void storeStatistics(final T statistics,
-                                            final boolean withParents);
+    protected abstract void storeStatistics(T statistics, boolean withParents);
 
 
 }