Fix various warnings

We can make methods static and do not have to specify generic
arguments. Fix these Eclipse-reported notices.

Change-Id: Ia5825d6c7a48cec489266b162605f7e3984f4a2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

diff --git a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecorator.java b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecorator.java
index 2db109b29464ab93a24f37464906a85681c37e55..85870820852669526b470cf23cd38d0390a93b03 100644 (file)
--- a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecorator.java
+++ b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/SyncReactorGuardDecorator.java
@@ -63,7 +63,7 @@ public class SyncReactorGuardDecorator implements SyncReactor {
                                                          final long stampBeforeGuard,
                                                          final long stampAfterGuard,
                                                          final NodeId nodeId) {
-        return new FutureCallback<Boolean>() {
+        return new FutureCallback<>() {
             @Override
             public void onSuccess(final Boolean result) {
                 if (LOG.isDebugEnabled()) {

diff --git a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImpl.java b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImpl.java
index 3205102408d8280b3a9e8a3a22cf30db219be4ee..8c0661e9d4a4b6bc14b3397e160c5bbc1e1a5ae0 100644 (file)
--- a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImpl.java
+++ b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/impl/strategy/SyncPlanPushStrategyFlatBatchImpl.java
@@ -155,10 +155,9 @@ public class SyncPlanPushStrategyFlatBatchImpl implements SyncPlanPushStrategy {
         return resultVehicle;
     }
 
-    private FutureCallback<RpcResult<ProcessFlatBatchOutput>> createCounterCallback(final List<Batch> inputBatchBag,
-                                                                                    final int failureIndexLimit,
-                                                                                    final SyncCrudCounters counters) {
-        return new FutureCallback<RpcResult<ProcessFlatBatchOutput>>() {
+    private static FutureCallback<RpcResult<ProcessFlatBatchOutput>> createCounterCallback(
+            final List<Batch> inputBatchBag, final int failureIndexLimit, final SyncCrudCounters counters) {
+        return new FutureCallback<>() {
             @Override
             public void onSuccess(final RpcResult<ProcessFlatBatchOutput> result) {
                 if (!result.isSuccessful() && result.getResult() != null

diff --git a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/FxChainUtil.java b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/FxChainUtil.java
index 3da1068e0bb81fc870807ba73a0dabad997d72e4..82afa6709a630d314d821834eaff479c2af69f2f 100644 (file)
--- a/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/FxChainUtil.java
+++ b/applications/forwardingrules-sync/src/main/java/org/opendaylight/openflowplugin/applications/frsync/util/FxChainUtil.java
@@ -31,7 +31,7 @@ public final class FxChainUtil {
 
 
     public static FutureCallback<RpcResult<Void>> logResultCallback(final NodeId nodeId, final String prefix) {
-        return new FutureCallback<RpcResult<Void>>() {
+        return new FutureCallback<>() {
             @Override
             public void onSuccess(final RpcResult<Void> result) {
                 if (result != null) {

diff --git a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java
index 15d4a2418eac5e127f10cc8082fda35d1c078636..051ad29bb86b1df4c1c35d51d65a9c7b725c5c0f 100644 (file)
--- a/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java
+++ b/applications/forwardingrules-sync/src/test/java/org/opendaylight/openflowplugin/applications/frsync/util/ReconcileUtilTest.java
@@ -298,7 +298,7 @@ public class ReconcileUtilTest {
         Assert.assertEquals(6, ReconcileUtil.countTotalUpdated(syncPlan));
     }
 
-    private ItemSyncBox<String> createSyncBox(final String pushes, final String updates) {
+    private static ItemSyncBox<String> createSyncBox(final String pushes, final String updates) {
         ItemSyncBox<String> syncBox1 = new ItemSyncBox<>();
         syncBox1.getItemsToPush().addAll(COMMA_SPLITTER.splitToList(pushes));
         for (String orig : COMMA_SPLITTER.splitToList(updates)) {