Make x3 more useful error-prone rules errors instead of warnings

* http://errorprone.info/bugpattern/IntLongMath
* http://errorprone.info/bugpattern/FloatCast
* http://errorprone.info/bugpattern/ClassNewInstance
* http://errorprone.info/bugpattern/ConstructorInvokesOverridable
* http://errorprone.info/bugpattern/ThreeLetterTimeZoneID
* http://errorprone.info/bugpattern/UnsafeFinalization

and handle their impacts

Change-Id: I87d7cd5f4fe3f5b810acaab421ac9e5da8fb9c0b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

diff --git a/inject-guice-testutils/src/main/java/org/opendaylight/infrautils/inject/guice/testutils/GuiceRule.java b/inject-guice-testutils/src/main/java/org/opendaylight/infrautils/inject/guice/testutils/GuiceRule.java
index 012b3292eb1b6f65c93b91b9dd726c336ae7eecd..a98473b2dfd426f14b59ea98930e43eee8e42ddf 100644 (file)
--- a/inject-guice-testutils/src/main/java/org/opendaylight/infrautils/inject/guice/testutils/GuiceRule.java
+++ b/inject-guice-testutils/src/main/java/org/opendaylight/infrautils/inject/guice/testutils/GuiceRule.java
@@ -64,11 +64,11 @@ public class GuiceRule implements MethodRule {
         this.stage = DEFAULT_STAGE;
     }
 
-    protected Iterable<? extends Module> createModules(List<Class<? extends Module>> moduleClasses) {
+    private static Iterable<? extends Module> createModules(List<Class<? extends Module>> moduleClasses) {
         return moduleClasses.stream().map(klass -> {
             try {
-                return klass.newInstance();
-            } catch (InstantiationException | IllegalAccessException e) {
+                return klass.getConstructor().newInstance();
+            } catch (ReflectiveOperationException | IllegalArgumentException | SecurityException e) {
                 throw new IllegalArgumentException("newInstance() failed: " + klass.getName(), e);
             }
         }).collect(Collectors.toList());