BindingDOMRpcImplementationAdapter code clean-up 73/53973/3
authorMartin Ciglan <mciglan@cisco.com>
Tue, 28 Mar 2017 11:12:08 +0000 (13:12 +0200)
committerMartin Ciglan <mciglan@cisco.com>
Tue, 28 Mar 2017 11:44:54 +0000 (11:44 +0000)
- warnings
- package-private access
- typo
- white-spaces

Change-Id: I78f73f503d1f5570b9776f19ce5e0ef88750afad
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingDOMRpcImplementationAdapter.java

index 095302941a1259555bdd6e2b42895915cec6a4a3..5ebf65632fb4a0f56331c93d26ee837536471aa8 100644 (file)
@@ -18,6 +18,7 @@ import java.util.HashMap;
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.concurrent.ExecutionException;
+import javax.annotation.Nonnull;
 import org.opendaylight.mdsal.dom.api.DOMRpcException;
 import org.opendaylight.mdsal.dom.api.DOMRpcIdentifier;
 import org.opendaylight.mdsal.dom.api.DOMRpcImplementation;
@@ -45,7 +46,7 @@ public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation
     private final RpcService delegate;
     private final QName inputQname;
 
-    public <T extends RpcService> BindingDOMRpcImplementationAdapter(final BindingNormalizedNodeCodecRegistry codec,
+    <T extends RpcService> BindingDOMRpcImplementationAdapter(final BindingNormalizedNodeCodecRegistry codec,
             final Class<T> type, final Map<SchemaPath, Method> localNameToMethod, final T delegate) {
         try {
             this.invoker = SERVICE_INVOKERS.get(type, () -> {
@@ -65,12 +66,14 @@ public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation
         inputQname = QName.create(BindingReflections.getQNameModule(type), "input").intern();
     }
 
+    @Nonnull
     @Override
-    public CheckedFuture<DOMRpcResult, DOMRpcException> invokeRpc(final DOMRpcIdentifier rpc,
+    public CheckedFuture<DOMRpcResult, DOMRpcException> invokeRpc(@Nonnull final DOMRpcIdentifier rpc,
             final NormalizedNode<?, ?> input) {
+
         final SchemaPath schemaPath = rpc.getType();
-        final DataObject bindingInput = input != null ? deserilialize(rpc.getType(),input) : null;
-        final ListenableFuture<RpcResult<?>> bindingResult = invoke(schemaPath,bindingInput);
+        final DataObject bindingInput = input != null ? deserialize(rpc.getType(), input) : null;
+        final ListenableFuture<RpcResult<?>> bindingResult = invoke(schemaPath, bindingInput);
         return transformResult(bindingResult);
     }
 
@@ -79,7 +82,7 @@ public class BindingDOMRpcImplementationAdapter implements DOMRpcImplementation
         return COST;
     }
 
-    private DataObject deserilialize(final SchemaPath rpcPath, final NormalizedNode<?, ?> input) {
+    private DataObject deserialize(final SchemaPath rpcPath, final NormalizedNode<?, ?> input) {
         if (input instanceof LazySerializedContainerNode) {
             return ((LazySerializedContainerNode) input).bindingData();
         }