BUG 5399: HWVTEP Tunnels not added to OperDS

Populating tunnels list in physical switch table is not updating topology
operational DS. PhysicalSwitchUpdate.setTunnels() is making a wrong check for
isEmpty() to determine if data needs to be added to data store or not. It should be !isEmpty()

Change-Id: Iec4f773210fb07d019299558fb63f949b05788a7
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

diff --git a/hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transactions/md/PhysicalSwitchUpdateCommand.java b/hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transactions/md/PhysicalSwitchUpdateCommand.java
index c7ef2916f8431ca83e09fd4f2768ccca23fcb981..696bc8a737d8322e7800b86880e5d89f25c4d4b2 100644 (file)
--- a/hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transactions/md/PhysicalSwitchUpdateCommand.java
+++ b/hwvtepsouthbound/hwvtepsouthbound-impl/src/main/java/org/opendaylight/ovsdb/hwvtepsouthbound/transactions/md/PhysicalSwitchUpdateCommand.java
@@ -125,7 +125,7 @@ public class PhysicalSwitchUpdateCommand extends AbstractTransactionCommand {
     private void setTunnels(Node node, PhysicalSwitchAugmentationBuilder psAugmentationBuilder,
             PhysicalSwitch pSwitch) {
         if (pSwitch.getTunnels() != null && pSwitch.getTunnels().getData() != null
-                && pSwitch.getTunnels().getData().isEmpty()) {
+                && !pSwitch.getTunnels().getData().isEmpty()) {
             Set<UUID> uuidList = pSwitch.getTunnels().getData();
             List<Tunnels> tunnelList = new ArrayList<>();
             TunnelsBuilder tBuilder = new TunnelsBuilder();