Make packer templates fail on any problems

Change-Id: If5e49cabb8ea9e26d2bb723f66bb11a228ed78e3
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

diff --git a/packer/provision/baseline.sh b/packer/provision/baseline.sh
index 976cf4cf6c1dc820f62c213f56b455a3d834f4ea..cd367fd3f8f5cf1f189376e5c4a3881c79da86a8 100644 (file)
--- a/packer/provision/baseline.sh
+++ b/packer/provision/baseline.sh
@@ -2,6 +2,9 @@
 
 # vim: ts=4 sw=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 rh_systems() {
     # Handle the occurance where SELINUX is actually disabled
     SELINUX=$(grep -E '^SELINUX=(disabled|permissive|enforcing)$' /etc/selinux/config)

diff --git a/packer/provision/devstack-pre-pip.sh b/packer/provision/devstack-pre-pip.sh
index 575d0072bf0daa547a959421d3e54be92c26fceb..58ce0660121bdfce71d20130f079340026102aed 100644 (file)
--- a/packer/provision/devstack-pre-pip.sh
+++ b/packer/provision/devstack-pre-pip.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # add in a test copr repo
 wget http://copr.fedoraproject.org/coprs/tykeal/odl-updates/repo/epel-7/tykeal-odl-updates-epel-7.repo -O /etc/yum.repos.d/tykeal-odl-updates-epel-7.repo
 # Install xpath

diff --git a/packer/provision/devstack.sh b/packer/provision/devstack.sh
index 4671599253042c0a50aa0dba12137c5c3c15c71a..7583344d24f383713c5879d1d9fc4bf15726370f 100644 (file)
--- a/packer/provision/devstack.sh
+++ b/packer/provision/devstack.sh
@@ -1,5 +1,8 @@
 #!/bin/bash
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # add in a test copr repo
 wget http://copr.fedoraproject.org/coprs/tykeal/odl-updates/repo/epel-7/tykeal-odl-updates-epel-7.repo -O /etc/yum.repos.d/tykeal-odl-updates-epel-7.repo
 # Install xpath

diff --git a/packer/provision/docker.sh b/packer/provision/docker.sh
index cdd8cb051adf45da4cbceebdf5fb98361a5221ef..8d620a0baeb560db2e6aaa1687723430c50580df 100644 (file)
--- a/packer/provision/docker.sh
+++ b/packer/provision/docker.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 rh_changes() {
     echo "---> RH changes"
     # install docker and enable it

diff --git a/packer/provision/gbp.sh b/packer/provision/gbp.sh
index dc461c94ccdb12f73c46f3978897dd5d584ec986..d856b26851828123e16f7be581354830552d5d75 100644 (file)
--- a/packer/provision/gbp.sh
+++ b/packer/provision/gbp.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # Ensure that necessary variables are set to enable noninteractive mode in
 # commands.
 export DEBIAN_FRONTEND=noninteractive

diff --git a/packer/provision/java-builder.sh b/packer/provision/java-builder.sh
index 0777292fdcc50363d82802075fcd95eceabdbfa1..c3620a5334c5f0e67da52e2f4932f5dff13b962d 100644 (file)
--- a/packer/provision/java-builder.sh
+++ b/packer/provision/java-builder.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # The following packages are not needed by all projects, but they are
 # needed by enough to make them useful everywhere
 yum install -y @development perl-{Digest-SHA,ExtUtils-MakeMaker} \

diff --git a/packer/provision/mininet-ovs-2.3.sh b/packer/provision/mininet-ovs-2.3.sh
index 8938a5f743083e06ef143433e0f57da668526fa5..253364c988f07a97097bff1b3b3133ea7a9c036a 100644 (file)
--- a/packer/provision/mininet-ovs-2.3.sh
+++ b/packer/provision/mininet-ovs-2.3.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # Ensure that necessary variables are set to enable noninteractive mode in
 # commands.
 export DEBIAN_FRONTEND=noninteractive

diff --git a/packer/provision/mininet-ovs-2.5.sh b/packer/provision/mininet-ovs-2.5.sh
index d90d4c8af77e070f1eac62dcef390a4fde5e22dc..2270a24b00971658113f0e618c57ca82ea6a8869 100644 (file)
--- a/packer/provision/mininet-ovs-2.5.sh
+++ b/packer/provision/mininet-ovs-2.5.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # Ensure that necessary variables are set to enable noninteractive mode in
 # commands.
 export DEBIAN_FRONTEND=noninteractive

diff --git a/packer/provision/mininet.sh b/packer/provision/mininet.sh
index 4d0d7a95295dfb3bea586c4d5a286c8f81a9abdc..55ff05eb74525ab714508720ba5a469eff10c553 100644 (file)
--- a/packer/provision/mininet.sh
+++ b/packer/provision/mininet.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # Ensure that necessary variables are set to enable noninteractive mode in
 # commands.
 export DEBIAN_FRONTEND=noninteractive

diff --git a/packer/provision/robot.sh b/packer/provision/robot.sh
index b24dd1f57aa95f75d76444b0fdcc1250b261ac6c..9e1390686bb9e24743bc7cab505e170601297d46 100644 (file)
--- a/packer/provision/robot.sh
+++ b/packer/provision/robot.sh
@@ -2,6 +2,9 @@
 
 # vim: sw=4 ts=4 sts=4 et tw=72 :
 
+# force any errors to cause the script and job to end in failure
+set -xeu -o pipefile
+
 # Install minimal python requirements to get virtualenv going
 # Additional python dependencies should be installed via JJB configuration
 # inside project jobs using a virtualenv setup.